From: Steven Rostedt <rostedt@goodmis.org>
To: peter enderborg <peter.enderborg@sony.com>
Cc: "Stephen Smalley" <stephen.smalley.work@gmail.com>,
"Casey Schaufler" <casey@schaufler-ca.com>,
"Thiébaud Weksteen" <tweek@google.com>,
"Paul Moore" <paul@paul-moore.com>,
"Nick Kralevich" <nnk@google.com>,
"Eric Paris" <eparis@parisplace.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Mauro Carvalho Chehab" <mchehab+huawei@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Rob Herring" <robh@kernel.org>, "Arnd Bergmann" <arnd@arndb.de>,
linux-kernel@vger.kernel.org, selinux@vger.kernel.org
Subject: Re: [PATCH v2 2/2] selinux: add basic filtering for audit trace events
Date: Thu, 13 Aug 2020 15:16:46 -0400 [thread overview]
Message-ID: <20200813151646.513423a3@oasis.local.home> (raw)
In-Reply-To: <c1f8c9a9-d123-df96-4918-890355db0301@sony.com>
On Thu, 13 Aug 2020 20:18:55 +0200
peter enderborg <peter.enderborg@sony.com> wrote:
> > The "%p" gets obfuscated when printed from the trace file by default
> > now. But they are consistent (where the same pointer shows up as the
> > same hash).
> >
> > It's used mainly to map together events. For example, if you print the
> > address of a skb in the networking events, it's good to know what
> > events reference the same skb, and the pointer is used for that.
>
> So what is your opinion on ssid? I dont mind removing them
> now since people dont like it and the strong use-case is not
> strong (yet). Is there any problem to put getting them back
> later if useful? And then before the strings so the evaluation
> of filter first come on number before stings Or is there already
> some mechanism that optimize for that?
It's up to the owner of the trace event. I only replied to why pointers
in general are useful, but they are mostly just "ids" to map to other
trace events.
We have the libtraceevent that should be used for parsing raw trace
events in binary form. The library (which currently lives in the
kernel's tools/lib/traceeevnt directory) I'm trying to get to have its
own home that distros can package. It should never be an issue adding
another field to an event, as the library gives the tools the ability
to find a field of an event regardless of where it is positioned, and
also let the tools know if the field exists or not.
If that's what you are asking.
-- Steve
next prev parent reply other threads:[~2020-08-13 19:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 14:48 [PATCH v2 1/2] selinux: add tracepoint on denials Thiébaud Weksteen
2020-08-13 14:48 ` [PATCH v2 2/2] selinux: add basic filtering for audit trace events Thiébaud Weksteen
2020-08-13 15:05 ` Casey Schaufler
2020-08-13 15:35 ` peter enderborg
2020-08-13 15:49 ` Stephen Smalley
2020-08-13 16:10 ` peter enderborg
2020-08-13 17:14 ` peter enderborg
2020-08-13 17:38 ` Steven Rostedt
2020-08-13 18:18 ` peter enderborg
2020-08-13 19:16 ` Steven Rostedt [this message]
2020-08-13 15:41 ` [PATCH v2 1/2] selinux: add tracepoint on denials Stephen Smalley
2020-08-14 13:05 ` Thiébaud Weksteen
2020-08-14 16:51 ` Stephen Smalley
2020-08-14 17:07 ` peter enderborg
2020-08-14 17:08 ` Stephen Smalley
2020-08-14 17:22 ` peter enderborg
2020-08-14 17:46 ` Steven Rostedt
2020-08-14 18:06 ` peter enderborg
2020-08-14 18:30 ` Steven Rostedt
2020-08-14 18:50 ` peter enderborg
2020-08-14 18:56 ` Steven Rostedt
2020-08-15 7:17 ` peter enderborg
2020-08-15 8:45 ` peter enderborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200813151646.513423a3@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=arnd@arndb.de \
--cc=casey@schaufler-ca.com \
--cc=davem@davemloft.net \
--cc=eparis@parisplace.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=mingo@redhat.com \
--cc=nnk@google.com \
--cc=paul@paul-moore.com \
--cc=peter.enderborg@sony.com \
--cc=robh@kernel.org \
--cc=selinux@vger.kernel.org \
--cc=stephen.smalley.work@gmail.com \
--cc=tweek@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.