All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Xingxing Su <suxingxing@loongson.cn>,
	Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] seqlock: Fix build errors
Date: Fri, 14 Aug 2020 12:20:35 +0200	[thread overview]
Message-ID: <20200814102035.GA2367157@gmail.com> (raw)
In-Reply-To: <20200814083552.GE3982@worktop.programming.kicks-ass.net>


* Peter Zijlstra <peterz@infradead.org> wrote:

> > Signed-off-by: Xingxing Su <suxingxing@loongson.cn>
> > ---
> >  v2:  update the commit message
> > 
> >  include/linux/seqlock.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/include/linux/seqlock.h b/include/linux/seqlock.h
> > index 54bc204..4763c13 100644
> > --- a/include/linux/seqlock.h
> > +++ b/include/linux/seqlock.h
> > @@ -17,6 +17,7 @@
> >  #include <linux/lockdep.h>
> >  #include <linux/compiler.h>
> >  #include <linux/kcsan-checks.h>
> > +#include <linux/smp.h>
> >  #include <asm/processor.h>
> 
> Wrong place, it's lockdep_assert_preemption_disabled() that requires
> asm/percpu.h, and thus lockdep.h should include linux/smp. before
> asm/percpu.h

It already does that upstream:

 #ifndef __LINUX_LOCKDEP_H
 #define __LINUX_LOCKDEP_H

 #include <linux/lockdep_types.h>
 #include <linux/smp.h>
 #include <asm/percpu.h>

So it would be interesting to know what kernel version the build error 
occurs on.

Thanks,

	Ingo

  reply	other threads:[~2020-08-14 10:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-14  4:12 [PATCH v2] seqlock: Fix build errors Xingxing Su
2020-08-14  8:35 ` Peter Zijlstra
2020-08-14 10:20   ` Ingo Molnar [this message]
2020-08-14 10:30   ` Xingxing Su

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200814102035.GA2367157@gmail.com \
    --to=mingo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=suxingxing@loongson.cn \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.