From: Christoph Hellwig <hch@lst.de>
To: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: axboe@kernel.dk, ming.lei@redhat.com, hch@lst.de,
baolin.wang7@gmail.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND 5/5] block: Remove __blk_mq_sched_bio_merge() helper
Date: Mon, 17 Aug 2020 08:32:41 +0200 [thread overview]
Message-ID: <20200817063241.GE12248@lst.de> (raw)
In-Reply-To: <4ad0888df567a8bd75676b618ad87147c634d7b0.1597637287.git.baolin.wang@linux.alibaba.com>
On Mon, Aug 17, 2020 at 12:09:19PM +0800, Baolin Wang wrote:
> The blk_mq_sched_bio_merge() just wrap the __blk_mq_sched_bio_merge(), and
> no other places will use __blk_mq_sched_bio_merge(). Thus we can combine
> these 2 similar functions into one function.
I think the idea was to avoid the function call for the nomerges fast
path. Not sure if that is really worth it.
next prev parent reply other threads:[~2020-08-17 6:32 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 4:09 [PATCH RESEND 0/5] Some clean-ups for bio merge Baolin Wang
2020-08-17 4:09 ` [PATCH RESEND 1/5] block: Move bio merge related functions into blk-merge.c Baolin Wang
2020-08-17 6:15 ` Christoph Hellwig
2020-08-17 4:09 ` [PATCH RESEND 2/5] block: Remove redundant blk_mq_sched_allow_merge() validation Baolin Wang
2020-08-17 6:22 ` Christoph Hellwig
2020-08-17 12:06 ` Baolin Wang
2020-08-17 4:09 ` [PATCH RESEND 3/5] block: Add a new helper to attempt to merge a bio Baolin Wang
2020-08-17 6:26 ` Christoph Hellwig
2020-08-17 12:10 ` Baolin Wang
2020-08-17 12:24 ` Christoph Hellwig
2020-08-18 3:30 ` Baolin Wang
2020-08-17 7:55 ` kernel test robot
2020-08-17 7:55 ` kernel test robot
2020-08-17 7:55 ` [PATCH] block: fix boolconv.cocci warnings kernel test robot
2020-08-17 7:55 ` kernel test robot
2020-08-17 4:09 ` [PATCH RESEND 4/5] block: Remove blk_mq_attempt_merge() function Baolin Wang
2020-08-17 6:31 ` Christoph Hellwig
2020-08-17 12:10 ` Baolin Wang
2020-08-17 4:09 ` [PATCH RESEND 5/5] block: Remove __blk_mq_sched_bio_merge() helper Baolin Wang
2020-08-17 6:32 ` Christoph Hellwig [this message]
2020-08-17 12:14 ` Baolin Wang
2020-08-17 12:26 ` Christoph Hellwig
2020-08-18 3:29 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817063241.GE12248@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=baolin.wang7@gmail.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.