From: Kalle Valo <kvalo@codeaurora.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: QCA ath9k Development <ath9k-devel@qca.qualcomm.com>,
Jakub Kicinski <kuba@kernel.org>,
Vasanthakumar Thiagarajan <vasanth@atheros.com>,
"John W. Linville" <linville@tuxdriver.com>,
Senthil Balasubramanian <senthilkumar@atheros.com>,
Sujith <Sujith.Manoharan@atheros.com>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ath9k: Fix potential out of bounds in ath9k_htc_txcompletion_cb()
Date: Mon, 17 Aug 2020 10:24:14 +0000 [thread overview]
Message-ID: <20200817102414.F1F20C43387@smtp.codeaurora.org> (raw)
In-Reply-To: <20200813141253.GA457408@mwanda>
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The value of "htc_hdr->endpoint_id" comes from skb->data so Smatch marks
> it as untrusted so we have to check it before using it as an array
> offset.
>
> This is similar to a bug that syzkaller found in commit e4ff08a4d727
> ("ath9k: Fix use-after-free Write in ath9k_htc_rx_msg") so it is
> probably a real issue.
>
> Fixes: fb9987d0f748 ("ath9k_htc: Support for AR9271 chipset.")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
2705cd7558e7 ath9k: Fix potential out of bounds in ath9k_htc_txcompletion_cb()
--
https://patchwork.kernel.org/patch/11712553/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: QCA ath9k Development <ath9k-devel@qca.qualcomm.com>,
Jakub Kicinski <kuba@kernel.org>,
Vasanthakumar Thiagarajan <vasanth@atheros.com>,
"John W. Linville" <linville@tuxdriver.com>,
Senthil Balasubramanian <senthilkumar@atheros.com>,
Sujith <Sujith.Manoharan@atheros.com>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ath9k: Fix potential out of bounds in ath9k_htc_txcompletion_cb()
Date: Mon, 17 Aug 2020 10:24:14 +0000 (UTC) [thread overview]
Message-ID: <20200817102414.F1F20C43387@smtp.codeaurora.org> (raw)
In-Reply-To: <20200813141253.GA457408@mwanda>
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The value of "htc_hdr->endpoint_id" comes from skb->data so Smatch marks
> it as untrusted so we have to check it before using it as an array
> offset.
>
> This is similar to a bug that syzkaller found in commit e4ff08a4d727
> ("ath9k: Fix use-after-free Write in ath9k_htc_rx_msg") so it is
> probably a real issue.
>
> Fixes: fb9987d0f748 ("ath9k_htc: Support for AR9271 chipset.")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
2705cd7558e7 ath9k: Fix potential out of bounds in ath9k_htc_txcompletion_cb()
--
https://patchwork.kernel.org/patch/11712553/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-08-17 10:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 14:12 [PATCH] ath9k: Fix potential out of bounds in ath9k_htc_txcompletion_cb() Dan Carpenter
2020-08-13 14:12 ` Dan Carpenter
2020-08-17 10:24 ` Kalle Valo [this message]
2020-08-17 10:24 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817102414.F1F20C43387@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=Sujith.Manoharan@atheros.com \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=senthilkumar@atheros.com \
--cc=vasanth@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.