From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: qemu-devel@nongnu.org, Jason Wang <jasowang@redhat.com>,
qemu-trivial@nongnu.org, qemu-arm@nongnu.org,
Peter Maydell <peter.maydell@linaro.org>,
Alistair Francis <alistair@alistair23.me>
Subject: Re: [PATCH] hw/net/xilinx_axienet: Remove unused code
Date: Mon, 17 Aug 2020 16:04:46 +0200 [thread overview]
Message-ID: <20200817140446.GC2954729@toto> (raw)
In-Reply-To: <20200814133007.16850-1-f4bug@amsat.org>
On Fri, Aug 14, 2020 at 03:30:07PM +0200, Philippe Mathieu-Daudé wrote:
> Most of the MDIOBus fields are unused. The ADVERTISE_10HALF
> definition is unused. Remove unused code.
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/net/xilinx_axienet.c | 23 -----------------------
> 1 file changed, 23 deletions(-)
>
> diff --git a/hw/net/xilinx_axienet.c b/hw/net/xilinx_axienet.c
> index 1e48eb70c9..2e89f236b4 100644
> --- a/hw/net/xilinx_axienet.c
> +++ b/hw/net/xilinx_axienet.c
> @@ -54,7 +54,6 @@
> TYPE_XILINX_AXI_ENET_CONTROL_STREAM)
>
> /* Advertisement control register. */
> -#define ADVERTISE_10HALF 0x0020 /* Try for 10mbps half-duplex */
> #define ADVERTISE_10FULL 0x0040 /* Try for 10mbps full-duplex */
> #define ADVERTISE_100HALF 0x0080 /* Try for 100mbps half-duplex */
> #define ADVERTISE_100FULL 0x0100 /* Try for 100mbps full-duplex */
> @@ -169,28 +168,6 @@ tdk_init(struct PHY *phy)
> }
>
> struct MDIOBus {
> - /* bus. */
> - int mdc;
> - int mdio;
> -
> - /* decoder. */
> - enum {
> - PREAMBLE,
> - SOF,
> - OPC,
> - ADDR,
> - REQ,
> - TURNAROUND,
> - DATA
> - } state;
> - unsigned int drive;
> -
> - unsigned int cnt;
> - unsigned int addr;
> - unsigned int opc;
> - unsigned int req;
> - unsigned int data;
> -
> struct PHY *devs[32];
> };
>
> --
> 2.21.3
>
WARNING: multiple messages have this Message-ID (diff)
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-trivial@nongnu.org, Jason Wang <jasowang@redhat.com>,
Alistair Francis <alistair@alistair23.me>,
qemu-devel@nongnu.org, qemu-arm@nongnu.org
Subject: Re: [PATCH] hw/net/xilinx_axienet: Remove unused code
Date: Mon, 17 Aug 2020 16:04:46 +0200 [thread overview]
Message-ID: <20200817140446.GC2954729@toto> (raw)
In-Reply-To: <20200814133007.16850-1-f4bug@amsat.org>
On Fri, Aug 14, 2020 at 03:30:07PM +0200, Philippe Mathieu-Daudé wrote:
> Most of the MDIOBus fields are unused. The ADVERTISE_10HALF
> definition is unused. Remove unused code.
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/net/xilinx_axienet.c | 23 -----------------------
> 1 file changed, 23 deletions(-)
>
> diff --git a/hw/net/xilinx_axienet.c b/hw/net/xilinx_axienet.c
> index 1e48eb70c9..2e89f236b4 100644
> --- a/hw/net/xilinx_axienet.c
> +++ b/hw/net/xilinx_axienet.c
> @@ -54,7 +54,6 @@
> TYPE_XILINX_AXI_ENET_CONTROL_STREAM)
>
> /* Advertisement control register. */
> -#define ADVERTISE_10HALF 0x0020 /* Try for 10mbps half-duplex */
> #define ADVERTISE_10FULL 0x0040 /* Try for 10mbps full-duplex */
> #define ADVERTISE_100HALF 0x0080 /* Try for 100mbps half-duplex */
> #define ADVERTISE_100FULL 0x0100 /* Try for 100mbps full-duplex */
> @@ -169,28 +168,6 @@ tdk_init(struct PHY *phy)
> }
>
> struct MDIOBus {
> - /* bus. */
> - int mdc;
> - int mdio;
> -
> - /* decoder. */
> - enum {
> - PREAMBLE,
> - SOF,
> - OPC,
> - ADDR,
> - REQ,
> - TURNAROUND,
> - DATA
> - } state;
> - unsigned int drive;
> -
> - unsigned int cnt;
> - unsigned int addr;
> - unsigned int opc;
> - unsigned int req;
> - unsigned int data;
> -
> struct PHY *devs[32];
> };
>
> --
> 2.21.3
>
next prev parent reply other threads:[~2020-08-17 14:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 13:30 [PATCH] hw/net/xilinx_axienet: Remove unused code Philippe Mathieu-Daudé
2020-08-14 13:30 ` Philippe Mathieu-Daudé
2020-08-14 13:30 ` Philippe Mathieu-Daudé
2020-08-14 15:05 ` Alistair Francis
2020-08-14 15:05 ` Alistair Francis
2020-08-17 14:04 ` Edgar E. Iglesias [this message]
2020-08-17 14:04 ` Edgar E. Iglesias
2020-09-01 9:29 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817140446.GC2954729@toto \
--to=edgar.iglesias@gmail.com \
--cc=alistair@alistair23.me \
--cc=f4bug@amsat.org \
--cc=jasowang@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.