From: Kalle Valo <kvalo@codeaurora.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: amitkarwar@gmail.com, ganapathi.bhat@nxp.com,
huxinming820@gmail.com, davem@davemloft.net, kuba@kernel.org,
yogeshp@marvell.com, bzhao@marvell.com, linville@tuxdriver.com,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] mwifiex: Do not use GFP_KERNEL in atomic context
Date: Tue, 18 Aug 2020 12:52:28 +0000 [thread overview]
Message-ID: <20200818125228.4CFD3C433AF@smtp.codeaurora.org> (raw)
In-Reply-To: <20200809092906.744621-1-christophe.jaillet@wanadoo.fr>
Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> A possible call chain is as follow:
> mwifiex_sdio_interrupt (sdio.c)
> --> mwifiex_main_process (main.c)
> --> mwifiex_process_cmdresp (cmdevt.c)
> --> mwifiex_process_sta_cmdresp (sta_cmdresp.c)
> --> mwifiex_ret_802_11_scan (scan.c)
> --> mwifiex_parse_single_response_buf (scan.c)
>
> 'mwifiex_sdio_interrupt()' is an interrupt function.
>
> Also note that 'mwifiex_ret_802_11_scan()' already uses GFP_ATOMIC.
>
> So use GFP_ATOMIC instead of GFP_KERNEL when memory is allocated in
> 'mwifiex_parse_single_response_buf()'.
>
> Fixes: 7c6fa2a843c5 ("mwifiex: use cfg80211 dynamic scan table and cfg80211_get_bss API")
> or
> Fixes: 601216e12c65e ("mwifiex: process RX packets in SDIO IRQ thread directly")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Patch applied to wireless-drivers-next.git, thanks.
d2ab7f00f432 mwifiex: Do not use GFP_KERNEL in atomic context
--
https://patchwork.kernel.org/patch/11706587/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: amitkarwar@gmail.com, ganapathi.bhat@nxp.com,
huxinming820@gmail.com, davem@davemloft.net, kuba@kernel.org,
yogeshp@marvell.com, bzhao@marvell.com, linville@tuxdriver.com,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: Re: [PATCH] mwifiex: Do not use GFP_KERNEL in atomic context
Date: Tue, 18 Aug 2020 12:52:28 +0000 (UTC) [thread overview]
Message-ID: <20200818125228.4CFD3C433AF@smtp.codeaurora.org> (raw)
In-Reply-To: <20200809092906.744621-1-christophe.jaillet@wanadoo.fr>
Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> A possible call chain is as follow:
> mwifiex_sdio_interrupt (sdio.c)
> --> mwifiex_main_process (main.c)
> --> mwifiex_process_cmdresp (cmdevt.c)
> --> mwifiex_process_sta_cmdresp (sta_cmdresp.c)
> --> mwifiex_ret_802_11_scan (scan.c)
> --> mwifiex_parse_single_response_buf (scan.c)
>
> 'mwifiex_sdio_interrupt()' is an interrupt function.
>
> Also note that 'mwifiex_ret_802_11_scan()' already uses GFP_ATOMIC.
>
> So use GFP_ATOMIC instead of GFP_KERNEL when memory is allocated in
> 'mwifiex_parse_single_response_buf()'.
>
> Fixes: 7c6fa2a843c5 ("mwifiex: use cfg80211 dynamic scan table and cfg80211_get_bss API")
> or
> Fixes: 601216e12c65e ("mwifiex: process RX packets in SDIO IRQ thread directly")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Patch applied to wireless-drivers-next.git, thanks.
d2ab7f00f432 mwifiex: Do not use GFP_KERNEL in atomic context
--
https://patchwork.kernel.org/patch/11706587/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-08-18 12:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-09 9:29 [PATCH] mwifiex: Do not use GFP_KERNEL in atomic context Christophe JAILLET
2020-08-09 9:29 ` Christophe JAILLET
2020-08-18 12:52 ` Kalle Valo [this message]
2020-08-18 12:52 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200818125228.4CFD3C433AF@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=amitkarwar@gmail.com \
--cc=bzhao@marvell.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=ganapathi.bhat@nxp.com \
--cc=huxinming820@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=yogeshp@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.