[PATCH] Add directory /var/empty in base-files

[PATCH] Add directory /var/empty in base-files

[lachlan.archibald]

/var/empty is commonly used as the home directory for system users that do not
have any other dedicated directory.

Signed-off-by: Lachlan Archibald <lachlan.archibald@opengear.com>
---
 meta/recipes-core/base-files/base-files_3.0.14.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-core/base-files/base-files_3.0.14.bb b/meta/recipes-core/base-files/base-files_3.0.14.bb
index 94299431f6..ff706637fa 100644
--- a/meta/recipes-core/base-files/base-files_3.0.14.bb
+++ b/meta/recipes-core/base-files/base-files_3.0.14.bb
@@ -39,7 +39,7 @@ dirs755 = "/boot /dev ${base_bindir} ${base_sbindir} ${base_libdir} \
            ${libdir} ${sbindir} ${datadir} \
            ${datadir}/common-licenses ${datadir}/dict ${infodir} \
            ${mandir} ${datadir}/misc ${localstatedir} \
-           ${localstatedir}/backups ${localstatedir}/lib \
+           ${localstatedir}/backups ${localstatedir}/empty ${localstatedir}/lib \
            ${localstatedir}/lib/misc ${localstatedir}/spool \
            ${localstatedir}/volatile \
            ${localstatedir}/${@'volatile/' if oe.types.boolean('${VOLATILE_LOG_DIR}') else ''}log \
-- 
2.26.2

✗ patchtest: failure for Add directory /var/empty in base-files

[Patchwork]

== Series Details ==

Series: Add directory /var/empty in base-files
Revision: 1
URL   : https://patchwork.openembedded.org/series/25673/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Patch            Add directory /var/empty in base-files
 Issue             Shortlog does not follow expected format [test_shortlog_format] 
  Suggested fix    Commit shortlog (first line of commit message) should follow the format "<target>: <summary>"



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe

[PATCH v2] base-files: Add directory /var/empty

[Lachlan Archibald]

/var/empty is commonly used as the home directory for system users that do not
have any other dedicated directory.

Signed-off-by: Lachlan Archibald <lachlan.archibald@opengear.com>
---
 meta/recipes-core/base-files/base-files_3.0.14.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-core/base-files/base-files_3.0.14.bb b/meta/recipes-core/base-files/base-files_3.0.14.bb
index 94299431f6..ff706637fa 100644
--- a/meta/recipes-core/base-files/base-files_3.0.14.bb
+++ b/meta/recipes-core/base-files/base-files_3.0.14.bb
@@ -39,7 +39,7 @@ dirs755 = "/boot /dev ${base_bindir} ${base_sbindir} ${base_libdir} \
            ${libdir} ${sbindir} ${datadir} \
            ${datadir}/common-licenses ${datadir}/dict ${infodir} \
            ${mandir} ${datadir}/misc ${localstatedir} \
-           ${localstatedir}/backups ${localstatedir}/lib \
+           ${localstatedir}/backups ${localstatedir}/empty ${localstatedir}/lib \
            ${localstatedir}/lib/misc ${localstatedir}/spool \
            ${localstatedir}/volatile \
            ${localstatedir}/${@'volatile/' if oe.types.boolean('${VOLATILE_LOG_DIR}') else ''}log \
-- 
2.26.2

Re: [OE-core] [PATCH v2] base-files: Add directory /var/empty

[Khem Raj]

On Tue, Aug 18, 2020 at 11:14 PM Lachlan Archibald
<lachlan.archibald@opengear.com> wrote:
>
> /var/empty is commonly used as the home directory for system users that do not
> have any other dedicated directory.
>

There is no "standard" empty directory specified in FHS so we need to
justify why we should always create this directory
which dameons need it or other applications that depend on /var/empty


> Signed-off-by: Lachlan Archibald <lachlan.archibald@opengear.com>
> ---
>  meta/recipes-core/base-files/base-files_3.0.14.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/base-files/base-files_3.0.14.bb b/meta/recipes-core/base-files/base-files_3.0.14.bb
> index 94299431f6..ff706637fa 100644
> --- a/meta/recipes-core/base-files/base-files_3.0.14.bb
> +++ b/meta/recipes-core/base-files/base-files_3.0.14.bb
> @@ -39,7 +39,7 @@ dirs755 = "/boot /dev ${base_bindir} ${base_sbindir} ${base_libdir} \
>             ${libdir} ${sbindir} ${datadir} \
>             ${datadir}/common-licenses ${datadir}/dict ${infodir} \
>             ${mandir} ${datadir}/misc ${localstatedir} \
> -           ${localstatedir}/backups ${localstatedir}/lib \
> +           ${localstatedir}/backups ${localstatedir}/empty ${localstatedir}/lib \
>             ${localstatedir}/lib/misc ${localstatedir}/spool \
>             ${localstatedir}/volatile \
>             ${localstatedir}/${@'volatile/' if oe.types.boolean('${VOLATILE_LOG_DIR}') else ''}log \
> --
> 2.26.2
>
> 

Re: [OE-core] [PATCH v2] base-files: Add directory /var/empty

[Randy MacLeod]

On 2020-08-19 2:50 a.m., Khem Raj wrote:
> On Tue, Aug 18, 2020 at 11:14 PM Lachlan Archibald
> <lachlan.archibald@opengear.com> wrote:
>>
>> /var/empty is commonly used as the home directory for system users that do not
>> have any other dedicated directory.
>>
> 
> There is no "standard" empty directory specified in FHS so we need to
> justify why we should always create this directory
> which dameons need it or other applications that depend on /var/empty
> 

Lachlan,

Can you resubmit listing the daemons that use /var/empty in
the commit log?

../Randy

> 
>> Signed-off-by: Lachlan Archibald <lachlan.archibald@opengear.com>
>> ---
>>   meta/recipes-core/base-files/base-files_3.0.14.bb | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-core/base-files/base-files_3.0.14.bb b/meta/recipes-core/base-files/base-files_3.0.14.bb
>> index 94299431f6..ff706637fa 100644
>> --- a/meta/recipes-core/base-files/base-files_3.0.14.bb
>> +++ b/meta/recipes-core/base-files/base-files_3.0.14.bb
>> @@ -39,7 +39,7 @@ dirs755 = "/boot /dev ${base_bindir} ${base_sbindir} ${base_libdir} \
>>              ${libdir} ${sbindir} ${datadir} \
>>              ${datadir}/common-licenses ${datadir}/dict ${infodir} \
>>              ${mandir} ${datadir}/misc ${localstatedir} \
>> -           ${localstatedir}/backups ${localstatedir}/lib \
>> +           ${localstatedir}/backups ${localstatedir}/empty ${localstatedir}/lib \
>>              ${localstatedir}/lib/misc ${localstatedir}/spool \
>>              ${localstatedir}/volatile \
>>              ${localstatedir}/${@'volatile/' if oe.types.boolean('${VOLATILE_LOG_DIR}') else ''}log \
>> --
>> 2.26.2
>>
>>
>>
>> 


-- 
# Randy MacLeod
# Wind River Linux