From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Łukasz Stelmach" <l.stelmach@samsung.com>
Cc: Kukjin Kim <kgene@kernel.org>, Andi Shyti <andi@etezian.org>,
Mark Brown <broonie@kernel.org>,
linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, m.szyprowski@samsung.com,
b.zolnierkie@samsung.com
Subject: Re: [PATCH 2/8] spi: spi-s3s64xx: Add S3C64XX_SPI_QUIRK_CS_AUTO for Exynos3250
Date: Wed, 19 Aug 2020 14:39:14 +0200 [thread overview]
Message-ID: <20200819123914.GC18122@kozik-lap> (raw)
In-Reply-To: <20200819123208.12337-3-l.stelmach@samsung.com>
On Wed, Aug 19, 2020 at 02:32:02PM +0200, Łukasz Stelmach wrote:
> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
Add a quirk - why? There is here no commit msg, no explanation.
Best regards,
Krzysztof
> ---
> drivers/spi/spi-s3c64xx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
> index fb5e2ba4b6b9..8fe44451d303 100644
> --- a/drivers/spi/spi-s3c64xx.c
> +++ b/drivers/spi/spi-s3c64xx.c
> @@ -1372,6 +1372,7 @@ static struct s3c64xx_spi_port_config exynos4_spi_port_config = {
> .tx_st_done = 25,
> .high_speed = true,
> .clk_from_cmu = true,
> + .quirks = S3C64XX_SPI_QUIRK_CS_AUTO,
> };
>
> static struct s3c64xx_spi_port_config exynos7_spi_port_config = {
> --
> 2.26.2
>
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Łukasz Stelmach" <l.stelmach@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org, b.zolnierkie@samsung.com,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
Mark Brown <broonie@kernel.org>, Kukjin Kim <kgene@kernel.org>,
Andi Shyti <andi@etezian.org>,
linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com
Subject: Re: [PATCH 2/8] spi: spi-s3s64xx: Add S3C64XX_SPI_QUIRK_CS_AUTO for Exynos3250
Date: Wed, 19 Aug 2020 14:39:14 +0200 [thread overview]
Message-ID: <20200819123914.GC18122@kozik-lap> (raw)
In-Reply-To: <20200819123208.12337-3-l.stelmach@samsung.com>
On Wed, Aug 19, 2020 at 02:32:02PM +0200, Łukasz Stelmach wrote:
> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
Add a quirk - why? There is here no commit msg, no explanation.
Best regards,
Krzysztof
> ---
> drivers/spi/spi-s3c64xx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
> index fb5e2ba4b6b9..8fe44451d303 100644
> --- a/drivers/spi/spi-s3c64xx.c
> +++ b/drivers/spi/spi-s3c64xx.c
> @@ -1372,6 +1372,7 @@ static struct s3c64xx_spi_port_config exynos4_spi_port_config = {
> .tx_st_done = 25,
> .high_speed = true,
> .clk_from_cmu = true,
> + .quirks = S3C64XX_SPI_QUIRK_CS_AUTO,
> };
>
> static struct s3c64xx_spi_port_config exynos7_spi_port_config = {
> --
> 2.26.2
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-19 12:39 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200819123225eucas1p28be1b1920ade0ba8997bc17da97599b6@eucas1p2.samsung.com>
2020-08-19 12:32 ` [PATCH 0/8] Some fixes for spi-s3c64xx Łukasz Stelmach
2020-08-19 12:32 ` Łukasz Stelmach
2020-08-19 12:32 ` [PATCH 1/8] spi: spi-s3c64xx: swap s3c64xx_spi_set_cs() and s3c64xx_enable_datapath() Łukasz Stelmach
2020-08-19 12:32 ` Łukasz Stelmach
2020-08-19 12:38 ` Krzysztof Kozlowski
2020-08-19 12:38 ` Krzysztof Kozlowski
2020-08-19 12:51 ` Lukasz Stelmach
2020-08-19 12:51 ` Lukasz Stelmach
2020-08-19 12:58 ` Krzysztof Kozlowski
2020-08-19 12:58 ` Krzysztof Kozlowski
2020-08-19 13:16 ` Mark Brown
2020-08-19 13:16 ` Mark Brown
2020-08-19 14:01 ` Lukasz Stelmach
2020-08-19 14:01 ` Lukasz Stelmach
2020-08-19 19:12 ` Mark Brown
2020-08-19 19:12 ` Mark Brown
2020-08-20 10:12 ` Lukasz Stelmach
2020-08-20 10:12 ` Lukasz Stelmach
2020-08-19 12:32 ` [PATCH 2/8] spi: spi-s3s64xx: Add S3C64XX_SPI_QUIRK_CS_AUTO for Exynos3250 Łukasz Stelmach
2020-08-19 12:32 ` Łukasz Stelmach
2020-08-19 12:39 ` Krzysztof Kozlowski [this message]
2020-08-19 12:39 ` Krzysztof Kozlowski
2020-08-19 13:01 ` Lukasz Stelmach
2020-08-19 13:01 ` Lukasz Stelmach
2020-08-19 13:06 ` Krzysztof Kozlowski
2020-08-19 13:06 ` Krzysztof Kozlowski
2020-08-19 19:38 ` Mark Brown
2020-08-19 19:38 ` Mark Brown
2020-08-20 10:47 ` Lukasz Stelmach
2020-08-20 10:47 ` Lukasz Stelmach
2020-08-19 12:32 ` [PATCH 3/8] spi: spi-s3c64xx: Report more information when errors occur Łukasz Stelmach
2020-08-19 12:32 ` Łukasz Stelmach
2020-08-19 12:43 ` Krzysztof Kozlowski
2020-08-19 12:43 ` Krzysztof Kozlowski
2020-08-19 12:32 ` [PATCH 4/8] spi: spi-s3c64xx: Rename S3C64XX_SPI_SLAVE_* to S3C64XX_SPI_CS_* Łukasz Stelmach
2020-08-19 12:32 ` Łukasz Stelmach
2020-08-19 12:44 ` Krzysztof Kozlowski
2020-08-19 12:44 ` Krzysztof Kozlowski
2020-08-19 12:32 ` [PATCH 5/8] spi: spi-s3c64xx: Fix doc comment for struct s3c64xx_spi_driver_data Łukasz Stelmach
2020-08-19 12:32 ` Łukasz Stelmach
2020-08-19 12:37 ` Krzysztof Kozlowski
2020-08-19 12:37 ` Krzysztof Kozlowski
2020-08-19 13:25 ` Lukasz Stelmach
2020-08-19 13:25 ` Lukasz Stelmach
2020-08-19 12:32 ` [PATCH 6/8] spi: spi-s3c64xx: Check return values Łukasz Stelmach
2020-08-19 12:32 ` Łukasz Stelmach
2020-08-19 12:48 ` Krzysztof Kozlowski
2020-08-19 12:48 ` Krzysztof Kozlowski
2020-08-19 15:41 ` Lukasz Stelmach
2020-08-19 15:41 ` Lukasz Stelmach
2020-08-19 16:13 ` Krzysztof Kozlowski
2020-08-19 16:13 ` Krzysztof Kozlowski
2020-08-19 12:32 ` [PATCH 7/8] spi: spi-s3c64xx: Increase transfer timeout Łukasz Stelmach
2020-08-19 12:32 ` Łukasz Stelmach
2020-08-19 12:49 ` Krzysztof Kozlowski
2020-08-19 12:49 ` Krzysztof Kozlowski
2020-08-19 13:39 ` Lukasz Stelmach
2020-08-19 13:39 ` Lukasz Stelmach
2020-08-21 7:10 ` Krzysztof Kozlowski
2020-08-21 7:10 ` Krzysztof Kozlowski
2020-08-19 12:32 ` [PATCH 8/8] spi: spi-s3c64xx: Turn on interrupts upon resume Łukasz Stelmach
2020-08-19 12:32 ` Łukasz Stelmach
2020-08-19 12:53 ` Krzysztof Kozlowski
2020-08-19 12:53 ` Krzysztof Kozlowski
2020-08-19 13:33 ` Lukasz Stelmach
2020-08-19 13:33 ` Lukasz Stelmach
2020-08-19 12:50 ` [PATCH 0/8] Some fixes for spi-s3c64xx Krzysztof Kozlowski
2020-08-19 12:50 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200819123914.GC18122@kozik-lap \
--to=krzk@kernel.org \
--cc=andi@etezian.org \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=kgene@kernel.org \
--cc=l.stelmach@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.