From: gregkh <gregkh@linuxfoundation.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: "João Henrique" <johnnyonflame@hotmail.com>,
stable@vger.kernel.org,
"Linus Walleij" <linus.walleij@linaro.org>
Subject: Re: [BACKPORT v5.4 PATCH] pinctrl: ingenic: Properly detect GPIO direction when configured for IRQ
Date: Wed, 19 Aug 2020 16:02:43 +0200 [thread overview]
Message-ID: <20200819140243.GA3333888@kroah.com> (raw)
In-Reply-To: <20200819134953.25842-1-paul@crapouillou.net>
On Wed, Aug 19, 2020 at 03:49:53PM +0200, Paul Cercueil wrote:
> The PAT1 register contains information about the IRQ type (edge/level)
> for input GPIOs with IRQ enabled, and the direction for non-IRQ GPIOs.
> So it makes sense to read it only if the GPIO has no interrupt
> configured, otherwise input GPIOs configured for level IRQs are
> misdetected as output GPIOs.
>
> Fixes: ebd6651418b6 ("pinctrl: ingenic: Implement .get_direction for GPIO chips")
> Reported-by: João Henrique <johnnyonflame@hotmail.com>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> Cc: stable@vger.kernel.org
> Link: https://lore.kernel.org/r/20200622214548.265417-2-paul@crapouillou.net
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>
> Notes:
> Original git commit ID: 84e7a946da71f678affacea301f6d5cb4d9784e8
Now queued up, thanks!
greg k-h
prev parent reply other threads:[~2020-08-19 14:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 11:48 FAILED: patch "[PATCH] pinctrl: ingenic: Properly detect GPIO direction when" failed to apply to 5.4-stable tree gregkh
2020-08-19 13:49 ` [BACKPORT v5.4 PATCH] pinctrl: ingenic: Properly detect GPIO direction when configured for IRQ Paul Cercueil
2020-08-19 14:02 ` gregkh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200819140243.GA3333888@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=johnnyonflame@hotmail.com \
--cc=linus.walleij@linaro.org \
--cc=paul@crapouillou.net \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.