All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Tony Lindgren <tony@atomide.com>
Cc: kernel list <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-omap@vger.kernel.org, sre@kernel.org, nekit1000@gmail.com,
	mpartap@gmx.net, merlijn@wizzup.org, martin_rysavy@centrum.cz,
	linux-pm@vger.kernel.org, "Arthur D." <spinal.by@gmail.com>
Subject: Re: [RFC] Limiting charge current on Droid 4 (and N900)
Date: Thu, 20 Aug 2020 08:58:56 +0200	[thread overview]
Message-ID: <20200820065855.GA9738@amd> (raw)
In-Reply-To: <20200820041512.GH2994@atomide.com>

[-- Attachment #1: Type: text/plain, Size: 1390 bytes --]

Hi!

> > > Droid 4 has same problem as N900: it is often neccessary to manually
> > > tweak current draw from USB, for example when using thin charging cable.
> > > 
> > > N900 creates unique attribute by hand, but I believe
> > > POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT looks suitable. (Should N900 be
> > > converted?)
> > > 
> > > Comments? Would the patch be acceptable after fixing whitespace?
> > 
> > Looks OK to me. Until we have better charger vs host vs usb3 charging hub
> > detection in place this seems like a good thing to do.
> 
> FYI, I'm cleaning up the pending charger and battery patches to send out
> for review. So that includes my earlier RFC battery status patches, and
> Spinal's additions, and this patch. It will likely be several days before
> I have the series ready for posting though.

Thanks for heads-up.

I had issue when I could not charge _empty_ droid4 battery from
powerbank. Green light was blinking and current was going up and down
but never stabilized. I thought I had dmesg from that but can't find
it now :-(.

Plus, I left D4 on charger overnight, and found battery empty in the
morning. It apparently charged in the evening but then discharged.

Best regards,
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Tony Lindgren <tony@atomide.com>
Cc: mpartap@gmx.net, linux-pm@vger.kernel.org, merlijn@wizzup.org,
	martin_rysavy@centrum.cz,
	kernel list <linux-kernel@vger.kernel.org>,
	sre@kernel.org, nekit1000@gmail.com, linux-omap@vger.kernel.org,
	"Arthur D." <spinal.by@gmail.com>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC] Limiting charge current on Droid 4 (and N900)
Date: Thu, 20 Aug 2020 08:58:56 +0200	[thread overview]
Message-ID: <20200820065855.GA9738@amd> (raw)
In-Reply-To: <20200820041512.GH2994@atomide.com>


[-- Attachment #1.1: Type: text/plain, Size: 1390 bytes --]

Hi!

> > > Droid 4 has same problem as N900: it is often neccessary to manually
> > > tweak current draw from USB, for example when using thin charging cable.
> > > 
> > > N900 creates unique attribute by hand, but I believe
> > > POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT looks suitable. (Should N900 be
> > > converted?)
> > > 
> > > Comments? Would the patch be acceptable after fixing whitespace?
> > 
> > Looks OK to me. Until we have better charger vs host vs usb3 charging hub
> > detection in place this seems like a good thing to do.
> 
> FYI, I'm cleaning up the pending charger and battery patches to send out
> for review. So that includes my earlier RFC battery status patches, and
> Spinal's additions, and this patch. It will likely be several days before
> I have the series ready for posting though.

Thanks for heads-up.

I had issue when I could not charge _empty_ droid4 battery from
powerbank. Green light was blinking and current was going up and down
but never stabilized. I thought I had dmesg from that but can't find
it now :-(.

Plus, I left D4 on charger overnight, and found battery empty in the
morning. It apparently charged in the evening but then discharged.

Best regards,
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-08-20  6:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-15 14:05 [RFC] Limiting charge current on Droid 4 (and N900) Pavel Machek
2020-06-15 14:05 ` Pavel Machek
2020-06-27 11:01 ` Merlijn Wajer
2020-06-27 11:01   ` Merlijn Wajer
2020-06-29 21:49   ` Pavel Machek
2020-06-29 21:49     ` Pavel Machek
2020-06-29 15:55 ` Tony Lindgren
2020-06-29 15:55   ` Tony Lindgren
2020-08-20  4:15   ` Tony Lindgren
2020-08-20  4:15     ` Tony Lindgren
2020-08-20  6:58     ` Pavel Machek [this message]
2020-08-20  6:58       ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200820065855.GA9738@amd \
    --to=pavel@ucw.cz \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=martin_rysavy@centrum.cz \
    --cc=merlijn@wizzup.org \
    --cc=mpartap@gmx.net \
    --cc=nekit1000@gmail.com \
    --cc=spinal.by@gmail.com \
    --cc=sre@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.