From: Sudeep Holla <sudeep.holla@arm.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Sumit Gupta <sumitg@nvidia.com>,
rjw@rjwysocki.net, catalin.marinas@arm.com,
thierry.reding@gmail.com, jonathanh@nvidia.com,
linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, bbasu@nvidia.com,
wangkefeng.wang@huawei.com, Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [Patch] cpufreq: replace cpu_logical_map with read_cpuid_mpir
Date: Thu, 20 Aug 2020 13:37:11 +0100 [thread overview]
Message-ID: <20200820123711.GA19989@bogus> (raw)
In-Reply-To: <20200820053945.xlwtpkvbt4o23flk@vireshk-i7>
On Thu, Aug 20, 2020 at 11:09:45AM +0530, Viresh Kumar wrote:
> On 12-08-20, 01:13, Sumit Gupta wrote:
> > Commit eaecca9e7710 ("arm64: Fix __cpu_logical_map undefined issue")
> > fixes the issue with building tegra194 cpufreq driver as module. But
> > the fix might cause problem while supporting physical cpu hotplug[1].
> >
> > This patch fixes the original problem by avoiding use of cpu_logical_map().
> > Instead calling read_cpuid_mpidr() to get MPIDR on target cpu.
> >
> > [1] https://lore.kernel.org/linux-arm-kernel/20200724131059.GB6521@bogus/
> >
> > Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
> > Signed-off-by: Sumit Gupta <sumitg@nvidia.com>
> > ---
> > drivers/cpufreq/tegra194-cpufreq.c | 10 +++++++---
> > 1 file changed, 7 insertions(+), 3 deletions(-)
>
> Applied. Thanks.
Just to confirm, is this going as a fix ? We want to drop exporting
cpu_logical_map in v5.9 so this needs to go as fix. I missed it earlier,
actually,
Fixes: df320f89359c ("cpufreq: Add Tegra194 cpufreq driver")
is appropriate here so that we can drop export symbol which was part of
Commit eaecca9e7710 ("arm64: Fix __cpu_logical_map undefined issue")
as a workaround to fix the build.
--
Regards,
Sudeep
WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <sudeep.holla@arm.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: bbasu@nvidia.com, wangkefeng.wang@huawei.com,
linux-pm@vger.kernel.org, catalin.marinas@arm.com,
rjw@rjwysocki.net, linux-kernel@vger.kernel.org,
jonathanh@nvidia.com, thierry.reding@gmail.com,
Sudeep Holla <sudeep.holla@arm.com>,
linux-tegra@vger.kernel.org, Sumit Gupta <sumitg@nvidia.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [Patch] cpufreq: replace cpu_logical_map with read_cpuid_mpir
Date: Thu, 20 Aug 2020 13:37:11 +0100 [thread overview]
Message-ID: <20200820123711.GA19989@bogus> (raw)
In-Reply-To: <20200820053945.xlwtpkvbt4o23flk@vireshk-i7>
On Thu, Aug 20, 2020 at 11:09:45AM +0530, Viresh Kumar wrote:
> On 12-08-20, 01:13, Sumit Gupta wrote:
> > Commit eaecca9e7710 ("arm64: Fix __cpu_logical_map undefined issue")
> > fixes the issue with building tegra194 cpufreq driver as module. But
> > the fix might cause problem while supporting physical cpu hotplug[1].
> >
> > This patch fixes the original problem by avoiding use of cpu_logical_map().
> > Instead calling read_cpuid_mpidr() to get MPIDR on target cpu.
> >
> > [1] https://lore.kernel.org/linux-arm-kernel/20200724131059.GB6521@bogus/
> >
> > Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
> > Signed-off-by: Sumit Gupta <sumitg@nvidia.com>
> > ---
> > drivers/cpufreq/tegra194-cpufreq.c | 10 +++++++---
> > 1 file changed, 7 insertions(+), 3 deletions(-)
>
> Applied. Thanks.
Just to confirm, is this going as a fix ? We want to drop exporting
cpu_logical_map in v5.9 so this needs to go as fix. I missed it earlier,
actually,
Fixes: df320f89359c ("cpufreq: Add Tegra194 cpufreq driver")
is appropriate here so that we can drop export symbol which was part of
Commit eaecca9e7710 ("arm64: Fix __cpu_logical_map undefined issue")
as a workaround to fix the build.
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-20 12:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 19:43 [Patch] cpufreq: replace cpu_logical_map with read_cpuid_mpir Sumit Gupta
2020-08-11 19:43 ` Sumit Gupta
2020-08-20 5:39 ` Viresh Kumar
2020-08-20 5:39 ` Viresh Kumar
2020-08-20 12:37 ` Sudeep Holla [this message]
2020-08-20 12:37 ` Sudeep Holla
2020-08-21 5:22 ` Viresh Kumar
2020-08-21 5:22 ` Viresh Kumar
2020-08-21 18:18 ` Rafael J. Wysocki
2020-08-21 18:18 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200820123711.GA19989@bogus \
--to=sudeep.holla@arm.com \
--cc=bbasu@nvidia.com \
--cc=catalin.marinas@arm.com \
--cc=jonathanh@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sumitg@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=viresh.kumar@linaro.org \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.