Re: [PATCH 2/2] usb: dwc3: pci: Allow Elkhart Lake to utilize DSM method for PM functionality

[Heikki Krogerus <heikki.krogerus@linux.intel.com>]

On Mon, Aug 17, 2020 at 04:09:26PM +0300, Felipe Balbi wrote:
> Raymond Tan <raymond.tan@intel.com> writes:
> 
> > Similar to some other IA platforms, Elkhart Lake too depends on the PMU
> > register write to request transition of Dx power state.
> >
> > Thus, we add the PCI_DEVICE_ID_INTEL_EHL to the list of devices that shall
> > execute the ACPI _DSM method during D0/D3 sequence.
> >
> > Signed-off-by: Raymond Tan <raymond.tan@intel.com>
> > ---
> >  drivers/usb/dwc3/dwc3-pci.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c
> > index 4f436b3..4d50187 100644
> > --- a/drivers/usb/dwc3/dwc3-pci.c
> > +++ b/drivers/usb/dwc3/dwc3-pci.c
> > @@ -149,7 +149,8 @@ static int dwc3_pci_quirks(struct dwc3_pci *dwc)
> >  
> >  	if (pdev->vendor == PCI_VENDOR_ID_INTEL) {
> >  		if (pdev->device == PCI_DEVICE_ID_INTEL_BXT ||
> > -				pdev->device == PCI_DEVICE_ID_INTEL_BXT_M) {
> > +		    pdev->device == PCI_DEVICE_ID_INTEL_BXT_M ||
> > +		    pdev->device == PCI_DEVICE_ID_INTEL_EHL) {
> 
> this looks like a bug fix which could be added during -rc cycle. As
> such, it should be patch 1 in this series. Renaming the macro is less
> critical. Can you update your series so I can take patch 1 during -rc
> and patch 2 for next merge window? Please, don't forget to add the
> Fixes: tag ;-)

Raymond, I'll take care of this patch (and the other one too). I have
now some changes that need to be made on top of this patch, and I
don't want to wait with them anymore, so I'll include these in my
series.


thanks,

-- 
heikki