All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@kernel.org>
To: Raymond Tan <raymond.tan@intel.com>, linux-usb@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Raymond Tan <raymond.tan@intel.com>
Subject: Re: [PATCH 2/2] usb: dwc3: pci: Allow Elkhart Lake to utilize DSM method for PM functionality
Date: Mon, 17 Aug 2020 16:09:26 +0300	[thread overview]
Message-ID: <87a6ytzaex.fsf@kernel.org> (raw)
In-Reply-To: <1596478284-69661-3-git-send-email-raymond.tan@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1306 bytes --]

Raymond Tan <raymond.tan@intel.com> writes:

> Similar to some other IA platforms, Elkhart Lake too depends on the PMU
> register write to request transition of Dx power state.
>
> Thus, we add the PCI_DEVICE_ID_INTEL_EHL to the list of devices that shall
> execute the ACPI _DSM method during D0/D3 sequence.
>
> Signed-off-by: Raymond Tan <raymond.tan@intel.com>
> ---
>  drivers/usb/dwc3/dwc3-pci.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c
> index 4f436b3..4d50187 100644
> --- a/drivers/usb/dwc3/dwc3-pci.c
> +++ b/drivers/usb/dwc3/dwc3-pci.c
> @@ -149,7 +149,8 @@ static int dwc3_pci_quirks(struct dwc3_pci *dwc)
>  
>  	if (pdev->vendor == PCI_VENDOR_ID_INTEL) {
>  		if (pdev->device == PCI_DEVICE_ID_INTEL_BXT ||
> -				pdev->device == PCI_DEVICE_ID_INTEL_BXT_M) {
> +		    pdev->device == PCI_DEVICE_ID_INTEL_BXT_M ||
> +		    pdev->device == PCI_DEVICE_ID_INTEL_EHL) {

this looks like a bug fix which could be added during -rc cycle. As
such, it should be patch 1 in this series. Renaming the macro is less
critical. Can you update your series so I can take patch 1 during -rc
and patch 2 for next merge window? Please, don't forget to add the
Fixes: tag ;-)

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]

  reply	other threads:[~2020-08-17 13:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-03 18:11 [PATCH 0/2] usb: dwc3: pci: Allow Elkhart Lake to utilize DSM method for PM functionality Raymond Tan
2020-08-03 18:11 ` [PATCH 1/2] usb: dwc3: pci: Fix DEFINE for Intel Elkhart Lake Raymond Tan
2020-08-03 18:11 ` [PATCH 2/2] usb: dwc3: pci: Allow Elkhart Lake to utilize DSM method for PM functionality Raymond Tan
2020-08-17 13:09   ` Felipe Balbi [this message]
2020-08-20 13:07     ` Heikki Krogerus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6ytzaex.fsf@kernel.org \
    --to=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=raymond.tan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.