All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
To: Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Support Opensource <support.opensource@diasemi.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@st.com>,
	Icenowy Zheng <icenowy@aosc.io>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com
Subject: [PATCH 04/12] regulator: fixed: Fix W=1 build warnings when CONFIG_OF=n
Date: Thu, 20 Aug 2020 15:34:36 +0800	[thread overview]
Message-ID: <20200820153436.39088071@xhacker.debian> (raw)
In-Reply-To: <20200820152926.42c48840@xhacker.debian>

Fix below warnings when CONFIG_OF=n:

drivers/regulator/fixed.c:48:36: warning: ‘fixed_clkenable_data’ defined but not used [-Wunused-const-variable=]
   48 | static const struct fixed_dev_type fixed_clkenable_data = {
      |                                    ^~~~~~~~~~~~~~~~~~~~
drivers/regulator/fixed.c:44:36: warning: ‘fixed_voltage_data’ defined but not used [-Wunused-const-variable=]
   44 | static const struct fixed_dev_type fixed_voltage_data = {
      |                                    ^~~~~~~~~~~~~~~~~~

Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
---
 drivers/regulator/fixed.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/regulator/fixed.c b/drivers/regulator/fixed.c
index d54830e48b8d..2d92a471ebc1 100644
--- a/drivers/regulator/fixed.c
+++ b/drivers/regulator/fixed.c
@@ -41,14 +41,6 @@ struct fixed_dev_type {
 	bool has_enable_clock;
 };
 
-static const struct fixed_dev_type fixed_voltage_data = {
-	.has_enable_clock = false,
-};
-
-static const struct fixed_dev_type fixed_clkenable_data = {
-	.has_enable_clock = true,
-};
-
 static int reg_clock_enable(struct regulator_dev *rdev)
 {
 	struct fixed_voltage_data *priv = rdev_get_drvdata(rdev);
@@ -260,6 +252,14 @@ static int reg_fixed_voltage_probe(struct platform_device *pdev)
 }
 
 #if defined(CONFIG_OF)
+static const struct fixed_dev_type fixed_voltage_data = {
+	.has_enable_clock = false,
+};
+
+static const struct fixed_dev_type fixed_clkenable_data = {
+	.has_enable_clock = true,
+};
+
 static const struct of_device_id fixed_of_match[] = {
 	{
 		.compatible = "regulator-fixed",
-- 
2.28.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
To: Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Support Opensource <support.opensource@diasemi.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@st.com>,
	Icenowy Zheng <icenowy@aosc.io>
Cc: linux-kernel@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH 04/12] regulator: fixed: Fix W=1 build warnings when CONFIG_OF=n
Date: Thu, 20 Aug 2020 15:34:36 +0800	[thread overview]
Message-ID: <20200820153436.39088071@xhacker.debian> (raw)
In-Reply-To: <20200820152926.42c48840@xhacker.debian>

Fix below warnings when CONFIG_OF=n:

drivers/regulator/fixed.c:48:36: warning: ‘fixed_clkenable_data’ defined but not used [-Wunused-const-variable=]
   48 | static const struct fixed_dev_type fixed_clkenable_data = {
      |                                    ^~~~~~~~~~~~~~~~~~~~
drivers/regulator/fixed.c:44:36: warning: ‘fixed_voltage_data’ defined but not used [-Wunused-const-variable=]
   44 | static const struct fixed_dev_type fixed_voltage_data = {
      |                                    ^~~~~~~~~~~~~~~~~~

Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
---
 drivers/regulator/fixed.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/regulator/fixed.c b/drivers/regulator/fixed.c
index d54830e48b8d..2d92a471ebc1 100644
--- a/drivers/regulator/fixed.c
+++ b/drivers/regulator/fixed.c
@@ -41,14 +41,6 @@ struct fixed_dev_type {
 	bool has_enable_clock;
 };
 
-static const struct fixed_dev_type fixed_voltage_data = {
-	.has_enable_clock = false,
-};
-
-static const struct fixed_dev_type fixed_clkenable_data = {
-	.has_enable_clock = true,
-};
-
 static int reg_clock_enable(struct regulator_dev *rdev)
 {
 	struct fixed_voltage_data *priv = rdev_get_drvdata(rdev);
@@ -260,6 +252,14 @@ static int reg_fixed_voltage_probe(struct platform_device *pdev)
 }
 
 #if defined(CONFIG_OF)
+static const struct fixed_dev_type fixed_voltage_data = {
+	.has_enable_clock = false,
+};
+
+static const struct fixed_dev_type fixed_clkenable_data = {
+	.has_enable_clock = true,
+};
+
 static const struct of_device_id fixed_of_match[] = {
 	{
 		.compatible = "regulator-fixed",
-- 
2.28.0


  parent reply	other threads:[~2020-08-20  7:56 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200820152926.42c48840@xhacker.debian>
2020-08-20  7:32 ` [PATCH 01/12] regulator: 88pg86x: Fix W=1 build warning when CONFIG_OF=n Jisheng Zhang
2020-08-20  7:32   ` Jisheng Zhang
2020-08-20  7:33 ` [PATCH 02/12] regulator: da9210: " Jisheng Zhang
2020-08-20  7:33   ` Jisheng Zhang
2020-08-20  7:34 ` [PATCH 03/12] regulator: fan53555: " Jisheng Zhang
2020-08-20  7:34   ` Jisheng Zhang
2020-08-20  7:34 ` Jisheng Zhang [this message]
2020-08-20  7:34   ` [PATCH 04/12] regulator: fixed: Fix W=1 build warnings " Jisheng Zhang
2020-08-20  7:35 ` [PATCH 05/12] regulator: ltc3589: Fix W=1 build warning " Jisheng Zhang
2020-08-20  7:35   ` Jisheng Zhang
2020-08-20  7:36 ` [PATCH 06/12] regulator: ltc3676: " Jisheng Zhang
2020-08-20  7:36   ` Jisheng Zhang
2020-08-20  7:37 ` [PATCH 07/12] regulator: max1586: " Jisheng Zhang
2020-08-20  7:37   ` Jisheng Zhang
2020-08-20  7:37 ` [PATCH 08/12] regulator: max77826: " Jisheng Zhang
2020-08-20  7:37   ` Jisheng Zhang
2020-08-20  7:38 ` [PATCH 09/12] regulator: pwm: " Jisheng Zhang
2020-08-20  7:38   ` Jisheng Zhang
2020-08-20  7:46 ` [PATCH 11/12] regulator: stm32-vrefbuf: " Jisheng Zhang
2020-08-20  7:46   ` Jisheng Zhang
2020-08-20  8:13   ` Fabrice Gasnier
2020-08-20  8:13     ` Fabrice Gasnier
2020-08-20  8:32     ` Jisheng Zhang
2020-08-20  8:32       ` Jisheng Zhang
2020-08-20 10:51       ` Mark Brown
2020-08-20 10:51         ` Mark Brown
2020-08-20  7:47 ` [PATCH 12/12] regulator: sy8106a: " Jisheng Zhang
2020-08-20  7:47   ` Jisheng Zhang
2020-08-20  8:00 ` [PATCH 10/12] regulator: stm32-pwr: " Jisheng Zhang
2020-08-20  8:00   ` Jisheng Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200820153436.39088071@xhacker.debian \
    --to=jisheng.zhang@synaptics.com \
    --cc=alexandre.torgue@st.com \
    --cc=broonie@kernel.org \
    --cc=icenowy@aosc.io \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=support.opensource@diasemi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.