All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Rapoport <rppt@kernel.org>
To: ira.weiny@intel.com
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/highmem: Clean up endif comments
Date: Thu, 20 Aug 2020 19:31:38 +0300	[thread overview]
Message-ID: <20200820163138.GC752365@kernel.org> (raw)
In-Reply-To: <20200819184635.112579-1-ira.weiny@intel.com>

On Wed, Aug 19, 2020 at 11:46:35AM -0700, ira.weiny@intel.com wrote:
> From: Ira Weiny <ira.weiny@intel.com>
> 
> The #endif at the end of the file matches up with the '#if
> defined(HASHED_PAGE_VIRTUAL)' on line 374.  Not the CONFIG_HIGHMEM #if
> earlier.
> 
> Fix comments on both of the #endif's to indicate the correct end of
> blocks for each.
> 
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>

Reviewed-by: Mike Rapoport <rppt@linux.ibm.com>

> ---
>  mm/highmem.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/highmem.c b/mm/highmem.c
> index 64d8dea47dd1..1352a27951e3 100644
> --- a/mm/highmem.c
> +++ b/mm/highmem.c
> @@ -369,7 +369,7 @@ void kunmap_high(struct page *page)
>  }
>  
>  EXPORT_SYMBOL(kunmap_high);
> -#endif
> +#endif	/* CONFIG_HIGHMEM */
>  
>  #if defined(HASHED_PAGE_VIRTUAL)
>  
> @@ -481,4 +481,4 @@ void __init page_address_init(void)
>  	}
>  }
>  
> -#endif	/* defined(CONFIG_HIGHMEM) && !defined(WANT_PAGE_VIRTUAL) */
> +#endif	/* defined(HASHED_PAGE_VIRTUAL) */
> -- 
> 2.25.1
> 
> 

-- 
Sincerely yours,
Mike.


      reply	other threads:[~2020-08-20 16:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-19 18:46 [PATCH] mm/highmem: Clean up endif comments ira.weiny
2020-08-20 16:31 ` Mike Rapoport [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200820163138.GC752365@kernel.org \
    --to=rppt@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=ira.weiny@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.