From: Benjamin Poirier <benjamin.poirier@gmail.com>
To: Coiby Xu <coiby.xu@gmail.com>
Cc: Michal Kubecek <mkubecek@suse.cz>,
"open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>,
GR-Linux-NIC-Dev@marvell.com, Manish Chopra <manishc@marvell.com>,
netdev@vger.kernel.org, open list <linux-kernel@vger.kernel.org>,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [RFC 1/3] Initialize devlink health dump framework for the dlge driver
Date: Fri, 21 Aug 2020 14:23:08 +0900 [thread overview]
Message-ID: <20200821052308.GA12235@f3> (raw)
In-Reply-To: <20200821030822.huyuxa5o5tcvtv2o@Rk>
On 2020-08-21 11:08 +0800, Coiby Xu wrote:
[...]
> > > diff --git a/drivers/staging/qlge/qlge_health.h b/drivers/staging/qlge/qlge_health.h
> > > new file mode 100644
> > > index 000000000000..07d3bafab845
> > > --- /dev/null
> > > +++ b/drivers/staging/qlge/qlge_health.h
> > > @@ -0,0 +1,2 @@
> > > +#include <net/devlink.h>
> > > +int qlge_health_create_reporters(struct qlge_devlink *priv);
> >
> > I would suggest to put this in qlge.h instead of creating a new file.
>
> Although there are only two lines for now, is it possible qlge will add
> more devlink code? If that's the case, a file to single out these code
I would say that if there's more content in the future, it can move to a
separate file in the future.
If you feel strongly about putting this in its own file right away, then
make sure to add the usual
#ifndef QLGE_HEALTH_H
#define QLGE_HEALTH_H
...
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Poirier <benjamin.poirier@gmail.com>
To: Coiby Xu <coiby.xu@gmail.com>
Cc: netdev@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
Manish Chopra <manishc@marvell.com>,
GR-Linux-NIC-Dev@marvell.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Michal Kubecek <mkubecek@suse.cz>,
open list <linux-kernel@vger.kernel.org>,
"open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>
Subject: Re: [RFC 1/3] Initialize devlink health dump framework for the dlge driver
Date: Fri, 21 Aug 2020 14:23:08 +0900 [thread overview]
Message-ID: <20200821052308.GA12235@f3> (raw)
In-Reply-To: <20200821030822.huyuxa5o5tcvtv2o@Rk>
On 2020-08-21 11:08 +0800, Coiby Xu wrote:
[...]
> > > diff --git a/drivers/staging/qlge/qlge_health.h b/drivers/staging/qlge/qlge_health.h
> > > new file mode 100644
> > > index 000000000000..07d3bafab845
> > > --- /dev/null
> > > +++ b/drivers/staging/qlge/qlge_health.h
> > > @@ -0,0 +1,2 @@
> > > +#include <net/devlink.h>
> > > +int qlge_health_create_reporters(struct qlge_devlink *priv);
> >
> > I would suggest to put this in qlge.h instead of creating a new file.
>
> Although there are only two lines for now, is it possible qlge will add
> more devlink code? If that's the case, a file to single out these code
I would say that if there's more content in the future, it can move to a
separate file in the future.
If you feel strongly about putting this in its own file right away, then
make sure to add the usual
#ifndef QLGE_HEALTH_H
#define QLGE_HEALTH_H
...
next prev parent reply other threads:[~2020-08-21 5:23 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 16:05 [Linux-kernel-mentees] [RFC 0/3] staging: qlge: Re-writing the debugging features Coiby Xu
2020-08-14 16:05 ` Coiby Xu
2020-08-14 16:05 ` [Linux-kernel-mentees] [RFC 1/3] Initialize devlink health dump framework for the dlge driver Coiby Xu
2020-08-14 16:05 ` Coiby Xu
2020-08-16 2:56 ` [Linux-kernel-mentees] " Benjamin Poirier
2020-08-16 2:56 ` Benjamin Poirier
2020-08-21 3:08 ` [Linux-kernel-mentees] " Coiby Xu
2020-08-21 3:08 ` Coiby Xu
2020-08-21 5:23 ` Benjamin Poirier [this message]
2020-08-21 5:23 ` Benjamin Poirier
2020-10-05 2:33 ` [Linux-kernel-mentees] " Coiby Xu
2020-10-05 2:33 ` Coiby Xu
2020-08-14 16:06 ` [Linux-kernel-mentees] [RFC 2/3] staging: qlge: coredump via devlink health reporter Coiby Xu
2020-08-14 16:06 ` Coiby Xu
2020-08-14 16:06 ` [Linux-kernel-mentees] [RFC 3/3] staging: qlge: clean up code that dump info to dmesg Coiby Xu
2020-08-14 16:06 ` Coiby Xu
2020-08-16 2:57 ` [Linux-kernel-mentees] " Benjamin Poirier
2020-08-16 2:57 ` Benjamin Poirier
2020-08-21 3:14 ` [Linux-kernel-mentees] " Coiby Xu
2020-08-21 3:14 ` Coiby Xu
2020-08-26 7:52 ` [Linux-kernel-mentees] [RFC 0/3] staging: qlge: Re-writing the debugging features Shung-Hsi Yu
2020-08-26 7:52 ` Shung-Hsi Yu
2020-08-27 9:54 ` [Linux-kernel-mentees] " Shung-Hsi Yu
2020-08-27 9:54 ` Shung-Hsi Yu
2020-10-08 12:52 ` Coiby Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200821052308.GA12235@f3 \
--to=benjamin.poirier@gmail.com \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=coiby.xu@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manishc@marvell.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.