Re: [PATCH 1/3] prueth-hsr/prp: Update hsr/prp firmwares to latest

["Denys Dmytriyenko" <denys@ti.com>]

On Fri, Aug 21, 2020 at 01:02:36PM +0530, Lokesh Vutla wrote:
> Update the hsr/prp firmwares to latest that includes support for
> timestamping rx packets. Unfortunately version number is not
> incremented for this update.
> 
> Also rename the bb file to add PV in it.

This is fine, but you need to choose which one provides the correct PV. 
Currently you have it duplicated:

pruhsr-fw_2.15.23.bb will set PV = "2.15.23" automatically from the filename, 
but you also have existing PV = "2.15.23" inside the recipe. Same for other 
recipe.

The recommendation is to set PV in the filename for released tarballs.

When the code is pulled directly from git, it is acceptable (and sometimes 
even preferred) to use _git in the filename and set PV explicitly inside the 
recipe. And if you expect these to be updated regularly, you can avoid churn 
of renaming the recipe with the new version. Also that's preferred for 
packages (probably not in this case) that need to be AUTOREV-ed to the latest 
for any nightly CI atuomation...

-- 
Denys
 

> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> ---
>  .../pruhsr-fw/{pruhsr-fw_git.bb => pruhsr-fw_2.15.23.bb}      | 4 +++-
>  .../pruprp-fw/{pruprp-fw_git.bb => pruprp-fw_2.15.23.bb}      | 4 +++-
>  2 files changed, 6 insertions(+), 2 deletions(-)
>  rename recipes-bsp/pruhsr-fw/{pruhsr-fw_git.bb => pruhsr-fw_2.15.23.bb} (93%)
>  rename recipes-bsp/pruprp-fw/{pruprp-fw_git.bb => pruprp-fw_2.15.23.bb} (93%)
> 
> diff --git a/recipes-bsp/pruhsr-fw/pruhsr-fw_git.bb b/recipes-bsp/pruhsr-fw/pruhsr-fw_2.15.23.bb
> similarity index 93%
> rename from recipes-bsp/pruhsr-fw/pruhsr-fw_git.bb
> rename to recipes-bsp/pruhsr-fw/pruhsr-fw_2.15.23.bb
> index 0c7e7148..aebe255e 100644
> --- a/recipes-bsp/pruhsr-fw/pruhsr-fw_git.bb
> +++ b/recipes-bsp/pruhsr-fw/pruhsr-fw_2.15.23.bb
> @@ -7,11 +7,13 @@ PV = "2.15.23"
>  PE = "1"
>  PR = "r0"
>  
> +CLEANBROKEN = "1"
> +
>  COMPATIBLE_MACHINE = "ti33x|ti43x|am57xx-evm|am57xx-hs-evm"
>  
>  PACKAGE_ARCH = "${MACHINE_ARCH}"
>  
> -SRCREV = "313e20f312a286bc07b97ef9aca70ef3ce96af29"
> +SRCREV = "7ba9722b74608ad4472790972917e1205eb3c049"
>  BRANCH ?= "ti-linux-firmware"
>  
>  SRC_URI = "git://git.ti.com/processor-firmware/ti-linux-firmware.git;protocol=git;branch=${BRANCH}"
> diff --git a/recipes-bsp/pruprp-fw/pruprp-fw_git.bb b/recipes-bsp/pruprp-fw/pruprp-fw_2.15.23.bb
> similarity index 93%
> rename from recipes-bsp/pruprp-fw/pruprp-fw_git.bb
> rename to recipes-bsp/pruprp-fw/pruprp-fw_2.15.23.bb
> index 046e8dad..e0e36c2d 100644
> --- a/recipes-bsp/pruprp-fw/pruprp-fw_git.bb
> +++ b/recipes-bsp/pruprp-fw/pruprp-fw_2.15.23.bb
> @@ -7,11 +7,13 @@ PV = "2.15.23"
>  PE = "1"
>  PR = "r0"
>  
> +CLEANBROKEN = "1"
> +
>  COMPATIBLE_MACHINE = "ti33x|ti43x|am57xx-evm|am57xx-hs-evm"
>  
>  PACKAGE_ARCH = "${MACHINE_ARCH}"
>  
> -SRCREV = "313e20f312a286bc07b97ef9aca70ef3ce96af29"
> +SRCREV = "7ba9722b74608ad4472790972917e1205eb3c049"
>  BRANCH ?= "ti-linux-firmware"
>  
>  SRC_URI = "git://git.ti.com/processor-firmware/ti-linux-firmware.git;protocol=git;branch=${BRANCH}"
> -- 
> 2.23.0
>