From: Vivek Goyal <vgoyal@redhat.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: linux-fsdevel@vger.kernel.org, virtio-fs-list <virtio-fs@redhat.com>
Subject: Re: [Virtio-fs] [PATCH 4/5] fuse: For sending setattr in case of open(O_TRUNC)
Date: Fri, 21 Aug 2020 16:59:37 -0400 [thread overview]
Message-ID: <20200821205937.GC905782@redhat.com> (raw)
In-Reply-To: <CAJfpegu0HKSbY53GBMWSYRYc7NJab+9NAXmfp9ekzU_QCiDCQg@mail.gmail.com>
On Fri, Aug 21, 2020 at 05:05:16PM +0200, Miklos Szeredi wrote:
> On Fri, Jul 24, 2020 at 8:38 PM Vivek Goyal <vgoyal@redhat.com> wrote:
> >
> > open(O_TRUNC) will not kill suid/sgid on server and fuse_open_in does not
> > have information if caller has CAP_FSETID or not.
> >
> > So force sending setattr() which is called after open(O_TRUNC) so that
> > server clears setuid/setgid.
>
> I don't really like the fact that we lose atomicity if
> handle_killpriv_v2 is enabled.
>
> Let's just add a new flag to open as well. If a filesystem doesn't
> want to add the complexity of handling that it can still just disable
> atomic_o_trunc.
Ok, will look into adding flag to open.
Vivek
WARNING: multiple messages have this Message-ID (diff)
From: Vivek Goyal <vgoyal@redhat.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: linux-fsdevel@vger.kernel.org, virtio-fs-list <virtio-fs@redhat.com>
Subject: Re: [PATCH 4/5] fuse: For sending setattr in case of open(O_TRUNC)
Date: Fri, 21 Aug 2020 16:59:37 -0400 [thread overview]
Message-ID: <20200821205937.GC905782@redhat.com> (raw)
In-Reply-To: <CAJfpegu0HKSbY53GBMWSYRYc7NJab+9NAXmfp9ekzU_QCiDCQg@mail.gmail.com>
On Fri, Aug 21, 2020 at 05:05:16PM +0200, Miklos Szeredi wrote:
> On Fri, Jul 24, 2020 at 8:38 PM Vivek Goyal <vgoyal@redhat.com> wrote:
> >
> > open(O_TRUNC) will not kill suid/sgid on server and fuse_open_in does not
> > have information if caller has CAP_FSETID or not.
> >
> > So force sending setattr() which is called after open(O_TRUNC) so that
> > server clears setuid/setgid.
>
> I don't really like the fact that we lose atomicity if
> handle_killpriv_v2 is enabled.
>
> Let's just add a new flag to open as well. If a filesystem doesn't
> want to add the complexity of handling that it can still just disable
> atomic_o_trunc.
Ok, will look into adding flag to open.
Vivek
next prev parent reply other threads:[~2020-08-21 20:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 18:38 [Virtio-fs] [RFC PATCH 0/5] fuse: Implement FUSE_HANDLE_KILLPRIV_V2 and enable SB_NOSEC Vivek Goyal
2020-07-24 18:38 ` Vivek Goyal
2020-07-24 18:38 ` [Virtio-fs] [PATCH 1/5] fuse: Introduce the notion of FUSE_HANDLE_KILLPRIV_V2 Vivek Goyal
2020-07-24 18:38 ` Vivek Goyal
2020-07-24 18:38 ` [Virtio-fs] [PATCH 2/5] fuse: Set FUSE_WRITE_KILL_PRIV in cached write path Vivek Goyal
2020-07-24 18:38 ` Vivek Goyal
2020-07-24 18:38 ` [Virtio-fs] [PATCH 3/5] fuse: Add a flag FUSE_SETATTR_KILL_PRIV Vivek Goyal
2020-07-24 18:38 ` Vivek Goyal
2020-08-21 14:53 ` [Virtio-fs] " Miklos Szeredi
2020-08-21 14:53 ` Miklos Szeredi
2020-08-21 20:56 ` [Virtio-fs] " Vivek Goyal
2020-08-21 20:56 ` Vivek Goyal
2020-07-24 18:38 ` [Virtio-fs] [PATCH 4/5] fuse: For sending setattr in case of open(O_TRUNC) Vivek Goyal
2020-07-24 18:38 ` Vivek Goyal
2020-08-21 15:05 ` [Virtio-fs] " Miklos Szeredi
2020-08-21 15:05 ` Miklos Szeredi
2020-08-21 20:59 ` Vivek Goyal [this message]
2020-08-21 20:59 ` Vivek Goyal
2020-07-24 18:38 ` [Virtio-fs] [PATCH 5/5] virtiofs: Support SB_NOSEC flag to improve direct write performance Vivek Goyal
2020-07-24 18:38 ` Vivek Goyal
2020-08-21 14:46 ` [Virtio-fs] [RFC PATCH 0/5] fuse: Implement FUSE_HANDLE_KILLPRIV_V2 and enable SB_NOSEC Miklos Szeredi
2020-08-21 14:46 ` Miklos Szeredi
2020-08-21 20:02 ` [Virtio-fs] " Vivek Goyal
2020-08-21 20:02 ` Vivek Goyal
2020-08-24 8:43 ` [Virtio-fs] " Miklos Szeredi
2020-08-24 8:43 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200821205937.GC905782@redhat.com \
--to=vgoyal@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.