All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: Jernej Skrabec <jernej.skrabec@siol.net>,
	drinkcat@chromium.org, Neil Armstrong <narmstrong@baylibre.com>,
	David Airlie <airlied@linux.ie>, Jonas Karlman <jonas@kwiboo.se>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Andrzej Hajda <a.hajda@samsung.com>,
	Boris Brezillon <boris.brezillon@collabora.com>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	hsinyi@chromium.org, matthias.bgg@gmail.com,
	Collabora Kernel ML <kernel@collabora.com>
Subject: Re: [PATCH 3/3] drm/bridge: ps8640: Rework power state handling
Date: Sat, 22 Aug 2020 11:39:59 +0200	[thread overview]
Message-ID: <20200822093959.GD430436@ravnborg.org> (raw)
In-Reply-To: <20200821113809.GA283294@ravnborg.org>

Hi Enric.

On Fri, Aug 21, 2020 at 01:38:09PM +0200, Sam Ravnborg wrote:
> Hi Enric.
> 
> > 
> > Let me reformulate the question for if it was not clear.
> > 
> > What I did is be able to read the EDID every time userspace asks for it (so
> > kernel enables all the required) and Sam is proposing to just fail if all is not
> > setup. I can obviously do this but my question is, at which point I should leave
> > all the logic enabled to be able to read the EDID (after probe?, after
> > pre_enable, after enable?) It is not clear for me from the API.
> 
> I am not clear if my suggestion is a good suggestion.
> 
> I recall I saw something similar in another bridge driver.

I have noew checked - and there is several bridge drivers that
do a power_on to read get_edid - so I was mistaken. Sorry!

	Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: Jernej Skrabec <jernej.skrabec@siol.net>,
	drinkcat@chromium.org, Jonas Karlman <jonas@kwiboo.se>,
	David Airlie <airlied@linux.ie>,
	Neil Armstrong <narmstrong@baylibre.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Andrzej Hajda <a.hajda@samsung.com>,
	Boris Brezillon <boris.brezillon@collabora.com>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	hsinyi@chromium.org, matthias.bgg@gmail.com,
	Collabora Kernel ML <kernel@collabora.com>
Subject: Re: [PATCH 3/3] drm/bridge: ps8640: Rework power state handling
Date: Sat, 22 Aug 2020 11:39:59 +0200	[thread overview]
Message-ID: <20200822093959.GD430436@ravnborg.org> (raw)
In-Reply-To: <20200821113809.GA283294@ravnborg.org>

Hi Enric.

On Fri, Aug 21, 2020 at 01:38:09PM +0200, Sam Ravnborg wrote:
> Hi Enric.
> 
> > 
> > Let me reformulate the question for if it was not clear.
> > 
> > What I did is be able to read the EDID every time userspace asks for it (so
> > kernel enables all the required) and Sam is proposing to just fail if all is not
> > setup. I can obviously do this but my question is, at which point I should leave
> > all the logic enabled to be able to read the EDID (after probe?, after
> > pre_enable, after enable?) It is not clear for me from the API.
> 
> I am not clear if my suggestion is a good suggestion.
> 
> I recall I saw something similar in another bridge driver.

I have noew checked - and there is several bridge drivers that
do a power_on to read get_edid - so I was mistaken. Sorry!

	Sam

  reply	other threads:[~2020-08-22  9:40 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-15 20:53 [PATCH 0/3] drm/bridge: ps8640: Make sure all needed is powered to get the EDID Enric Balletbo i Serra
2020-06-15 20:53 ` Enric Balletbo i Serra
2020-06-15 20:53 ` [PATCH 1/3] drm/bridge: ps8640: Return an error for incorrect attach flags Enric Balletbo i Serra
2020-06-15 20:53   ` Enric Balletbo i Serra
2020-08-22  9:22   ` Sam Ravnborg
2020-08-22  9:22     ` Sam Ravnborg
2020-06-15 20:53 ` [PATCH 2/3] drm/bridge: ps8640: Print an error if VDO control fails Enric Balletbo i Serra
2020-06-15 20:53   ` Enric Balletbo i Serra
2020-08-22  9:23   ` Sam Ravnborg
2020-08-22  9:23     ` Sam Ravnborg
2020-06-15 20:53 ` [PATCH 3/3] drm/bridge: ps8640: Rework power state handling Enric Balletbo i Serra
2020-06-15 20:53   ` Enric Balletbo i Serra
2020-06-20 21:42   ` Sam Ravnborg
2020-06-20 21:42     ` Sam Ravnborg
2020-06-23 15:16     ` Enric Balletbo i Serra
2020-06-23 15:16       ` Enric Balletbo i Serra
2020-06-24  7:07       ` Sam Ravnborg
2020-06-24  7:07         ` Sam Ravnborg
2020-06-25  9:21         ` Enric Balletbo i Serra
2020-06-25  9:21           ` Enric Balletbo i Serra
2020-08-21 11:14           ` Enric Balletbo i Serra
2020-08-21 11:14             ` Enric Balletbo i Serra
2020-08-21 11:38             ` Sam Ravnborg
2020-08-21 11:38               ` Sam Ravnborg
2020-08-22  9:39               ` Sam Ravnborg [this message]
2020-08-22  9:39                 ` Sam Ravnborg
2020-08-22  9:38   ` Sam Ravnborg
2020-08-22  9:38     ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200822093959.GD430436@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=a.hajda@samsung.com \
    --cc=airlied@linux.ie \
    --cc=boris.brezillon@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=drinkcat@chromium.org \
    --cc=enric.balletbo@collabora.com \
    --cc=hsinyi@chromium.org \
    --cc=jernej.skrabec@siol.net \
    --cc=jonas@kwiboo.se \
    --cc=kernel@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=narmstrong@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.