From: Pavel Machek <pavel@ucw.cz>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joerg Roedel <jroedel@suse.de>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, linux-mm@kvack.org,
David Vrabel <david.vrabel@citrix.com>,
Dave Airlie <airlied@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Joerg Roedel <joro@8bytes.org>
Subject: Re: [Intel-gfx] [PATCH v2] mm: Track page table modifications in __apply_to_page_range()
Date: Sat, 22 Aug 2020 23:25:41 +0200 [thread overview]
Message-ID: <20200822212541.GB14071@amd> (raw)
In-Reply-To: <159804301810.32652.14249776487575415877@build.alporthouse.com>
[-- Attachment #1.1: Type: text/plain, Size: 1028 bytes --]
Hi!
> > > The __apply_to_page_range() function is also used to change and/or
> > > allocate page-table pages in the vmalloc area of the address space.
> > > Make sure these changes get synchronized to other page-tables in the
> > > system by calling arch_sync_kernel_mappings() when necessary.
> >
> > There's no description here of the user-visible effects of the bug.
> > Please always provide this, especially when proposing a -stable
> > backport. Take pity upon all the downstream kernel maintainers who are
> > staring at this wondering whether they should risk adding it to their
> > kernels.
>
> The impact appears limited to x86-32, where apply_to_page_range may miss
> updating the PMD. That leads to explosions in drivers like
Is this alone supposed to fix my problems with graphics on Thinkpad
X60? Let me try...
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Joerg Roedel <joro@8bytes.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
intel-gfx@lists.freedesktop.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Dave Airlie <airlied@redhat.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
David Vrabel <david.vrabel@citrix.com>,
Joerg Roedel <jroedel@suse.de>,
stable@vger.kernel.org
Subject: Re: [PATCH v2] mm: Track page table modifications in __apply_to_page_range()
Date: Sat, 22 Aug 2020 23:25:41 +0200 [thread overview]
Message-ID: <20200822212541.GB14071@amd> (raw)
In-Reply-To: <159804301810.32652.14249776487575415877@build.alporthouse.com>
[-- Attachment #1: Type: text/plain, Size: 1028 bytes --]
Hi!
> > > The __apply_to_page_range() function is also used to change and/or
> > > allocate page-table pages in the vmalloc area of the address space.
> > > Make sure these changes get synchronized to other page-tables in the
> > > system by calling arch_sync_kernel_mappings() when necessary.
> >
> > There's no description here of the user-visible effects of the bug.
> > Please always provide this, especially when proposing a -stable
> > backport. Take pity upon all the downstream kernel maintainers who are
> > staring at this wondering whether they should risk adding it to their
> > kernels.
>
> The impact appears limited to x86-32, where apply_to_page_range may miss
> updating the PMD. That leads to explosions in drivers like
Is this alone supposed to fix my problems with graphics on Thinkpad
X60? Let me try...
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2020-08-22 21:25 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 12:37 [Intel-gfx] [PATCH v2] mm: Track page table modifications in __apply_to_page_range() Joerg Roedel
2020-08-21 12:37 ` Joerg Roedel
2020-08-21 13:30 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-08-21 16:39 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-08-21 18:51 ` [Intel-gfx] [PATCH v2] " Chris Wilson
2020-08-21 18:51 ` Chris Wilson
2020-08-21 19:18 ` [Intel-gfx] " Linus Torvalds
2020-08-21 19:18 ` Linus Torvalds
2020-08-22 16:12 ` [Intel-gfx] " Joerg Roedel
2020-08-22 16:12 ` Joerg Roedel
2020-08-21 20:35 ` [Intel-gfx] " Andrew Morton
2020-08-21 20:35 ` Andrew Morton
2020-08-21 20:50 ` [Intel-gfx] " Chris Wilson
2020-08-21 20:50 ` Chris Wilson
2020-08-21 21:29 ` [Intel-gfx] " Pavel Machek
2020-08-21 21:29 ` Pavel Machek
2020-08-22 21:25 ` Pavel Machek [this message]
2020-08-22 21:25 ` Pavel Machek
2020-08-21 22:34 ` [Intel-gfx] " Andrew Morton
2020-08-21 22:34 ` Andrew Morton
2020-08-21 23:39 ` [Intel-gfx] " Chris Wilson
2020-08-21 23:39 ` Chris Wilson
2020-08-22 11:31 ` [Intel-gfx] " Chris Wilson
2020-08-22 11:31 ` Chris Wilson
2020-08-22 16:20 ` [Intel-gfx] " Joerg Roedel
2020-08-22 16:20 ` Joerg Roedel
2020-08-23 10:44 ` [Intel-gfx] " Pavel Machek
2020-08-23 10:44 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200822212541.GB14071@amd \
--to=pavel@ucw.cz \
--cc=airlied@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=chris@chris-wilson.co.uk \
--cc=david.vrabel@citrix.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joro@8bytes.org \
--cc=jroedel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.