From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org
Subject: Re: [Intel-gfx] [RFC v2 08/20] drm/nouveau/kms/nv50-: Refactor and cleanup DP HPD handling
Date: Mon, 24 Aug 2020 14:14:48 +0300 [thread overview]
Message-ID: <20200824111448.GF1793@kadam> (raw)
In-Reply-To: <20200820183012.288794-9-lyude@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 4848 bytes --]
Hi Lyude,
url: https://github.com/0day-ci/linux/commits/Lyude-Paul/drm-dp-i915-nouveau-Cleanup-nouveau-HPD-and-add-DP-features-from-i915/20200821-023327
base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: i386-randconfig-m021-20200820 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/gpu/drm/nouveau/dispnv50/disp.c:1479 nv50_mstm_detect() warn: variable dereferenced before check 'mstm' (see line 1476)
Old smatch warnings:
drivers/gpu/drm/nouveau/dispnv50/disp.c:608 nv50_audio_component_get_eld() error: uninitialized symbol 'nv_connector'.
# https://github.com/0day-ci/linux/commit/109d9a087027ecc3ebfe557f16a0efc8a7caa9eb
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Lyude-Paul/drm-dp-i915-nouveau-Cleanup-nouveau-HPD-and-add-DP-features-from-i915/20200821-023327
git checkout 109d9a087027ecc3ebfe557f16a0efc8a7caa9eb
vim +/mstm +1479 drivers/gpu/drm/nouveau/dispnv50/disp.c
52aa30f2524d065 drivers/gpu/drm/nouveau/nv50_display.c Ben Skeggs 2016-11-04 1472 int
109d9a087027ecc drivers/gpu/drm/nouveau/dispnv50/disp.c Lyude Paul 2020-08-20 1473 nv50_mstm_detect(struct nouveau_encoder *outp)
52aa30f2524d065 drivers/gpu/drm/nouveau/nv50_display.c Ben Skeggs 2016-11-04 1474 {
109d9a087027ecc drivers/gpu/drm/nouveau/dispnv50/disp.c Lyude Paul 2020-08-20 1475 struct nv50_mstm *mstm = outp->dp.mstm;
109d9a087027ecc drivers/gpu/drm/nouveau/dispnv50/disp.c Lyude Paul 2020-08-20 @1476 struct drm_dp_aux *aux = mstm->mgr.aux;
^^^^^^
Dereference
b26b4590dd53e01 drivers/gpu/drm/nouveau/dispnv50/disp.c Lyude Paul 2018-08-09 1477 int ret;
52aa30f2524d065 drivers/gpu/drm/nouveau/nv50_display.c Ben Skeggs 2016-11-04 1478
109d9a087027ecc drivers/gpu/drm/nouveau/dispnv50/disp.c Lyude Paul 2020-08-20 @1479 if (!mstm || !mstm->can_mst)
^^^^
Checked too late.
52aa30f2524d065 drivers/gpu/drm/nouveau/nv50_display.c Ben Skeggs 2016-11-04 1480 return 0;
52aa30f2524d065 drivers/gpu/drm/nouveau/nv50_display.c Ben Skeggs 2016-11-04 1481
109d9a087027ecc drivers/gpu/drm/nouveau/dispnv50/disp.c Lyude Paul 2020-08-20 1482 /* Clear any leftover MST state we didn't set ourselves by first
109d9a087027ecc drivers/gpu/drm/nouveau/dispnv50/disp.c Lyude Paul 2020-08-20 1483 * disabling MST if it was already enabled
109d9a087027ecc drivers/gpu/drm/nouveau/dispnv50/disp.c Lyude Paul 2020-08-20 1484 */
109d9a087027ecc drivers/gpu/drm/nouveau/dispnv50/disp.c Lyude Paul 2020-08-20 1485 ret = drm_dp_dpcd_writeb(aux, DP_MSTM_CTRL, 0);
52aa30f2524d065 drivers/gpu/drm/nouveau/nv50_display.c Ben Skeggs 2016-11-04 1486 if (ret < 0)
109d9a087027ecc drivers/gpu/drm/nouveau/dispnv50/disp.c Lyude Paul 2020-08-20 1487 return ret;
52aa30f2524d065 drivers/gpu/drm/nouveau/nv50_display.c Ben Skeggs 2016-11-04 1488
109d9a087027ecc drivers/gpu/drm/nouveau/dispnv50/disp.c Lyude Paul 2020-08-20 1489 /* And start enabling */
109d9a087027ecc drivers/gpu/drm/nouveau/dispnv50/disp.c Lyude Paul 2020-08-20 1490 ret = nv50_mstm_enable(mstm, true);
52aa30f2524d065 drivers/gpu/drm/nouveau/nv50_display.c Ben Skeggs 2016-11-04 1491 if (ret)
109d9a087027ecc drivers/gpu/drm/nouveau/dispnv50/disp.c Lyude Paul 2020-08-20 1492 return ret;
b26b4590dd53e01 drivers/gpu/drm/nouveau/dispnv50/disp.c Lyude Paul 2018-08-09 1493
109d9a087027ecc drivers/gpu/drm/nouveau/dispnv50/disp.c Lyude Paul 2020-08-20 1494 ret = drm_dp_mst_topology_mgr_set_mst(&mstm->mgr, true);
109d9a087027ecc drivers/gpu/drm/nouveau/dispnv50/disp.c Lyude Paul 2020-08-20 1495 if (ret) {
109d9a087027ecc drivers/gpu/drm/nouveau/dispnv50/disp.c Lyude Paul 2020-08-20 1496 nv50_mstm_enable(mstm, false);
b26b4590dd53e01 drivers/gpu/drm/nouveau/dispnv50/disp.c Lyude Paul 2018-08-09 1497 return ret;
52aa30f2524d065 drivers/gpu/drm/nouveau/nv50_display.c Ben Skeggs 2016-11-04 1498 }
52aa30f2524d065 drivers/gpu/drm/nouveau/nv50_display.c Ben Skeggs 2016-11-04 1499
109d9a087027ecc drivers/gpu/drm/nouveau/dispnv50/disp.c Lyude Paul 2020-08-20 1500 mstm->is_mst = true;
109d9a087027ecc drivers/gpu/drm/nouveau/dispnv50/disp.c Lyude Paul 2020-08-20 1501 return 1;
109d9a087027ecc drivers/gpu/drm/nouveau/dispnv50/disp.c Lyude Paul 2020-08-20 1502 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 39208 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild-all@lists.01.org
Subject: Re: [Intel-gfx] [RFC v2 08/20] drm/nouveau/kms/nv50-: Refactor and cleanup DP HPD handling
Date: Mon, 24 Aug 2020 14:14:48 +0300 [thread overview]
Message-ID: <20200824111448.GF1793@kadam> (raw)
In-Reply-To: <20200820183012.288794-9-lyude@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 4848 bytes --]
Hi Lyude,
url: https://github.com/0day-ci/linux/commits/Lyude-Paul/drm-dp-i915-nouveau-Cleanup-nouveau-HPD-and-add-DP-features-from-i915/20200821-023327
base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: i386-randconfig-m021-20200820 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/gpu/drm/nouveau/dispnv50/disp.c:1479 nv50_mstm_detect() warn: variable dereferenced before check 'mstm' (see line 1476)
Old smatch warnings:
drivers/gpu/drm/nouveau/dispnv50/disp.c:608 nv50_audio_component_get_eld() error: uninitialized symbol 'nv_connector'.
# https://github.com/0day-ci/linux/commit/109d9a087027ecc3ebfe557f16a0efc8a7caa9eb
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Lyude-Paul/drm-dp-i915-nouveau-Cleanup-nouveau-HPD-and-add-DP-features-from-i915/20200821-023327
git checkout 109d9a087027ecc3ebfe557f16a0efc8a7caa9eb
vim +/mstm +1479 drivers/gpu/drm/nouveau/dispnv50/disp.c
52aa30f2524d065 drivers/gpu/drm/nouveau/nv50_display.c Ben Skeggs 2016-11-04 1472 int
109d9a087027ecc drivers/gpu/drm/nouveau/dispnv50/disp.c Lyude Paul 2020-08-20 1473 nv50_mstm_detect(struct nouveau_encoder *outp)
52aa30f2524d065 drivers/gpu/drm/nouveau/nv50_display.c Ben Skeggs 2016-11-04 1474 {
109d9a087027ecc drivers/gpu/drm/nouveau/dispnv50/disp.c Lyude Paul 2020-08-20 1475 struct nv50_mstm *mstm = outp->dp.mstm;
109d9a087027ecc drivers/gpu/drm/nouveau/dispnv50/disp.c Lyude Paul 2020-08-20 @1476 struct drm_dp_aux *aux = mstm->mgr.aux;
^^^^^^
Dereference
b26b4590dd53e01 drivers/gpu/drm/nouveau/dispnv50/disp.c Lyude Paul 2018-08-09 1477 int ret;
52aa30f2524d065 drivers/gpu/drm/nouveau/nv50_display.c Ben Skeggs 2016-11-04 1478
109d9a087027ecc drivers/gpu/drm/nouveau/dispnv50/disp.c Lyude Paul 2020-08-20 @1479 if (!mstm || !mstm->can_mst)
^^^^
Checked too late.
52aa30f2524d065 drivers/gpu/drm/nouveau/nv50_display.c Ben Skeggs 2016-11-04 1480 return 0;
52aa30f2524d065 drivers/gpu/drm/nouveau/nv50_display.c Ben Skeggs 2016-11-04 1481
109d9a087027ecc drivers/gpu/drm/nouveau/dispnv50/disp.c Lyude Paul 2020-08-20 1482 /* Clear any leftover MST state we didn't set ourselves by first
109d9a087027ecc drivers/gpu/drm/nouveau/dispnv50/disp.c Lyude Paul 2020-08-20 1483 * disabling MST if it was already enabled
109d9a087027ecc drivers/gpu/drm/nouveau/dispnv50/disp.c Lyude Paul 2020-08-20 1484 */
109d9a087027ecc drivers/gpu/drm/nouveau/dispnv50/disp.c Lyude Paul 2020-08-20 1485 ret = drm_dp_dpcd_writeb(aux, DP_MSTM_CTRL, 0);
52aa30f2524d065 drivers/gpu/drm/nouveau/nv50_display.c Ben Skeggs 2016-11-04 1486 if (ret < 0)
109d9a087027ecc drivers/gpu/drm/nouveau/dispnv50/disp.c Lyude Paul 2020-08-20 1487 return ret;
52aa30f2524d065 drivers/gpu/drm/nouveau/nv50_display.c Ben Skeggs 2016-11-04 1488
109d9a087027ecc drivers/gpu/drm/nouveau/dispnv50/disp.c Lyude Paul 2020-08-20 1489 /* And start enabling */
109d9a087027ecc drivers/gpu/drm/nouveau/dispnv50/disp.c Lyude Paul 2020-08-20 1490 ret = nv50_mstm_enable(mstm, true);
52aa30f2524d065 drivers/gpu/drm/nouveau/nv50_display.c Ben Skeggs 2016-11-04 1491 if (ret)
109d9a087027ecc drivers/gpu/drm/nouveau/dispnv50/disp.c Lyude Paul 2020-08-20 1492 return ret;
b26b4590dd53e01 drivers/gpu/drm/nouveau/dispnv50/disp.c Lyude Paul 2018-08-09 1493
109d9a087027ecc drivers/gpu/drm/nouveau/dispnv50/disp.c Lyude Paul 2020-08-20 1494 ret = drm_dp_mst_topology_mgr_set_mst(&mstm->mgr, true);
109d9a087027ecc drivers/gpu/drm/nouveau/dispnv50/disp.c Lyude Paul 2020-08-20 1495 if (ret) {
109d9a087027ecc drivers/gpu/drm/nouveau/dispnv50/disp.c Lyude Paul 2020-08-20 1496 nv50_mstm_enable(mstm, false);
b26b4590dd53e01 drivers/gpu/drm/nouveau/dispnv50/disp.c Lyude Paul 2018-08-09 1497 return ret;
52aa30f2524d065 drivers/gpu/drm/nouveau/nv50_display.c Ben Skeggs 2016-11-04 1498 }
52aa30f2524d065 drivers/gpu/drm/nouveau/nv50_display.c Ben Skeggs 2016-11-04 1499
109d9a087027ecc drivers/gpu/drm/nouveau/dispnv50/disp.c Lyude Paul 2020-08-20 1500 mstm->is_mst = true;
109d9a087027ecc drivers/gpu/drm/nouveau/dispnv50/disp.c Lyude Paul 2020-08-20 1501 return 1;
109d9a087027ecc drivers/gpu/drm/nouveau/dispnv50/disp.c Lyude Paul 2020-08-20 1502 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 39208 bytes --]
next prev parent reply other threads:[~2020-08-24 11:14 UTC|newest]
Thread overview: 104+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 18:29 [Intel-gfx] [RFC v2 00/20] drm/dp, i915, nouveau: Cleanup nouveau HPD and add DP features from i915 Lyude Paul
2020-08-20 18:29 ` Lyude Paul
2020-08-20 18:29 ` Lyude Paul
2020-08-20 18:29 ` [Intel-gfx] [RFC v2 01/20] drm/nouveau/kms: Fix some indenting in nouveau_dp_detect() Lyude Paul
2020-08-20 18:29 ` Lyude Paul
2020-08-20 18:29 ` Lyude Paul
2020-08-20 18:29 ` Lyude Paul
2020-08-20 18:29 ` [Intel-gfx] [RFC v2 02/20] drm/nouveau/kms/nv50-: Remove open-coded drm_dp_read_desc() Lyude Paul
2020-08-20 18:29 ` Lyude Paul
2020-08-20 18:29 ` Lyude Paul
2020-08-20 18:29 ` Lyude Paul
2020-08-20 18:29 ` [Intel-gfx] [RFC v2 03/20] drm/nouveau/kms/nv50-: Just use drm_dp_dpcd_read() in nouveau_dp.c Lyude Paul
2020-08-20 18:29 ` Lyude Paul
2020-08-20 18:29 ` Lyude Paul
2020-08-20 18:29 ` Lyude Paul
2020-08-20 18:29 ` [Intel-gfx] [RFC v2 04/20] drm/nouveau/kms/nv50-: Use macros for DP registers " Lyude Paul
2020-08-20 18:29 ` Lyude Paul
2020-08-20 18:29 ` Lyude Paul
2020-08-20 18:29 ` Lyude Paul
2020-08-20 18:29 ` [Intel-gfx] [RFC v2 05/20] drm/nouveau/kms: Don't clear DP_MST_CTRL DPCD in nv50_mstm_new() Lyude Paul
2020-08-20 18:29 ` Lyude Paul
2020-08-20 18:29 ` Lyude Paul
2020-08-20 18:29 ` Lyude Paul
2020-08-20 18:29 ` [Intel-gfx] [RFC v2 06/20] drm/nouveau/kms: Search for encoders' connectors properly Lyude Paul
2020-08-20 18:29 ` Lyude Paul
2020-08-20 18:29 ` Lyude Paul
2020-08-20 18:29 ` Lyude Paul
2020-08-21 12:10 ` Dan Carpenter
2020-08-21 12:10 ` Dan Carpenter
2020-08-21 17:48 ` [Intel-gfx] [RFC v3] " Lyude Paul
2020-08-21 17:48 ` Lyude Paul
2020-08-21 17:48 ` Lyude Paul
2020-08-21 17:48 ` Lyude Paul
2020-08-20 18:29 ` [Intel-gfx] [RFC v2 07/20] drm/nouveau/kms/nv50-: Use drm_dp_dpcd_(readb|writeb)() in nv50_sor_disable() Lyude Paul
2020-08-20 18:29 ` Lyude Paul
2020-08-20 18:29 ` Lyude Paul
2020-08-20 18:29 ` Lyude Paul
2020-08-20 18:30 ` [Intel-gfx] [RFC v2 08/20] drm/nouveau/kms/nv50-: Refactor and cleanup DP HPD handling Lyude Paul
2020-08-20 18:30 ` Lyude Paul
2020-08-20 18:30 ` Lyude Paul
2020-08-20 18:30 ` Lyude Paul
2020-08-24 11:14 ` Dan Carpenter [this message]
2020-08-24 11:14 ` [Intel-gfx] " Dan Carpenter
2020-08-20 18:30 ` [Intel-gfx] [RFC v2 09/20] drm/i915/dp: Extract drm_dp_has_mst() Lyude Paul
2020-08-20 18:30 ` Lyude Paul
2020-08-20 18:30 ` Lyude Paul
2020-08-20 18:30 ` Lyude Paul
2020-08-20 18:30 ` [Intel-gfx] [RFC v2 10/20] drm/nouveau/kms: Use new drm_dp_has_mst() helper for checking MST caps Lyude Paul
2020-08-20 18:30 ` Lyude Paul
2020-08-20 18:30 ` Lyude Paul
2020-08-20 18:30 ` Lyude Paul
2020-08-20 18:30 ` [Intel-gfx] [RFC v2 11/20] drm/nouveau/kms: Move drm_dp_cec_unset_edid() into nouveau_connector_detect() Lyude Paul
2020-08-20 18:30 ` Lyude Paul
2020-08-20 18:30 ` Lyude Paul
2020-08-20 18:30 ` Lyude Paul
2020-08-20 18:30 ` [Intel-gfx] [RFC v2 12/20] drm/nouveau/kms: Only use hpd_work for reprobing in HPD paths Lyude Paul
2020-08-20 18:30 ` Lyude Paul
2020-08-20 18:30 ` Lyude Paul
2020-08-20 18:30 ` Lyude Paul
2020-08-20 18:30 ` [Intel-gfx] [RFC v2 13/20] drm/i915/dp: Extract drm_dp_downstream_read_info() Lyude Paul
2020-08-20 18:30 ` Lyude Paul
2020-08-20 18:30 ` Lyude Paul
2020-08-20 18:30 ` Lyude Paul
2020-08-21 19:27 ` [Intel-gfx] " Sean Paul
2020-08-21 19:27 ` Sean Paul
2020-08-21 19:27 ` Sean Paul
2020-08-21 19:27 ` Sean Paul
2020-08-20 18:30 ` [Intel-gfx] [RFC v2 14/20] drm/nouveau/kms/nv50-: Use downstream DP clock limits for mode validation Lyude Paul
2020-08-20 18:30 ` Lyude Paul
2020-08-20 18:30 ` Lyude Paul
2020-08-20 18:30 ` Lyude Paul
2020-08-20 18:30 ` [Intel-gfx] [RFC v2 15/20] drm/i915/dp: Extract drm_dp_has_sink_count() Lyude Paul
2020-08-20 18:30 ` Lyude Paul
2020-08-20 18:30 ` Lyude Paul
2020-08-20 18:30 ` Lyude Paul
2020-08-20 18:30 ` [Intel-gfx] [RFC v2 16/20] drm/i915/dp: Extract drm_dp_get_sink_count() Lyude Paul
2020-08-20 18:30 ` Lyude Paul
2020-08-20 18:30 ` Lyude Paul
2020-08-20 18:30 ` Lyude Paul
2020-08-20 18:30 ` [Intel-gfx] [RFC v2 17/20] drm/nouveau/kms/nv50-: Add support for DP_SINK_COUNT Lyude Paul
2020-08-20 18:30 ` Lyude Paul
2020-08-20 18:30 ` Lyude Paul
2020-08-20 18:30 ` Lyude Paul
2020-08-20 18:30 ` [Intel-gfx] [RFC v2 18/20] drm/nouveau/kms: Don't change EDID when it hasn't actually changed Lyude Paul
2020-08-20 18:30 ` Lyude Paul
2020-08-20 18:30 ` Lyude Paul
2020-08-20 18:30 ` Lyude Paul
2020-08-20 18:30 ` [Intel-gfx] [RFC v2 19/20] drm/i915/dp: Extract drm_dp_read_dpcd_caps() Lyude Paul
2020-08-20 18:30 ` Lyude Paul
2020-08-20 18:30 ` Lyude Paul
2020-08-20 18:30 ` Lyude Paul
2020-08-20 18:30 ` [Intel-gfx] [RFC v2 20/20] drm/nouveau/kms: Start using drm_dp_read_dpcd_caps() Lyude Paul
2020-08-20 18:30 ` Lyude Paul
2020-08-20 18:30 ` Lyude Paul
2020-08-20 18:30 ` Lyude Paul
2020-08-20 19:11 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/dp, i915, nouveau: Cleanup nouveau HPD and add DP features from i915 (rev4) Patchwork
2020-08-20 19:12 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-08-20 19:27 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-08-21 5:16 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-08-21 17:57 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/dp, i915, nouveau: Cleanup nouveau HPD and add DP features from i915 (rev5) Patchwork
2020-08-21 17:58 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-08-21 18:13 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-08-21 20:38 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2020-08-21 13:41 [Intel-gfx] [RFC v2 08/20] drm/nouveau/kms/nv50-: Refactor and cleanup DP HPD handling kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200824111448.GF1793@kadam \
--to=dan.carpenter@oracle.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.