From: Dan Carpenter <dan.carpenter@oracle.com>
To: Tomer Samara <tomersamara98@gmail.com>
Cc: devel@driverdev.osuosl.org, "Todd Kjos" <tkjos@android.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
"Joel Fernandes" <joel@joelfernandes.org>,
"Riley Andrews" <riandrews@android.com>,
"Martijn Coenen" <maco@android.com>,
"Arve Hjønnevåg" <arve@android.com>,
"Hridya Valsaraju" <hridya@google.com>,
"Laura Abbott" <labbott@redhat.com>,
"Suren Baghdasaryan" <surenb@google.com>,
"Christian Brauner" <christian@brauner.io>
Subject: Re: [PATCH v4 1/2] staging: android: Remove BUG_ON from ion_page_pool.c
Date: Mon, 24 Aug 2020 14:22:06 +0300 [thread overview]
Message-ID: <20200824112206.GH1793@kadam> (raw)
In-Reply-To: <32ea3b6d840cb56ea927400e1875d9d4db38e926.1598023524.git.tomersamara98@gmail.com>
On Fri, Aug 21, 2020 at 06:27:37PM +0300, Tomer Samara wrote:
> BUG_ON() is removed at ion_page_pool.c
>
> Fixes the following issue:
> Avoid crashing the kernel - try using WARN_ON & recovery code ratherthan BUG() or BUG_ON().
>
> Signed-off-by: Tomer Samara <tomersamara98@gmail.com>
> ---
You should put a note here about what changed between v3 vs v4. Like so:
---
v4: Just remove the BUG_ON()s instead of adding new returns.
v3: Hand the new return paths or whatever.
Anyway, looks good.
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Tomer Samara <tomersamara98@gmail.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, "Todd Kjos" <tkjos@android.com>,
"Suren Baghdasaryan" <surenb@google.com>,
"Riley Andrews" <riandrews@android.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
"Hridya Valsaraju" <hridya@google.com>,
"Arve Hjønnevåg" <arve@android.com>,
"Joel Fernandes" <joel@joelfernandes.org>,
"Laura Abbott" <labbott@redhat.com>,
"Martijn Coenen" <maco@android.com>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Christian Brauner" <christian@brauner.io>
Subject: Re: [PATCH v4 1/2] staging: android: Remove BUG_ON from ion_page_pool.c
Date: Mon, 24 Aug 2020 14:22:06 +0300 [thread overview]
Message-ID: <20200824112206.GH1793@kadam> (raw)
In-Reply-To: <32ea3b6d840cb56ea927400e1875d9d4db38e926.1598023524.git.tomersamara98@gmail.com>
On Fri, Aug 21, 2020 at 06:27:37PM +0300, Tomer Samara wrote:
> BUG_ON() is removed at ion_page_pool.c
>
> Fixes the following issue:
> Avoid crashing the kernel - try using WARN_ON & recovery code ratherthan BUG() or BUG_ON().
>
> Signed-off-by: Tomer Samara <tomersamara98@gmail.com>
> ---
You should put a note here about what changed between v3 vs v4. Like so:
---
v4: Just remove the BUG_ON()s instead of adding new returns.
v3: Hand the new return paths or whatever.
Anyway, looks good.
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
next prev parent reply other threads:[~2020-08-24 11:24 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 15:27 [PATCH v4 0/2] staging: android: Remove BUG/BUG_ON from ion Tomer Samara
2020-08-21 15:27 ` Tomer Samara
2020-08-21 15:27 ` [PATCH v4 1/2] staging: android: Remove BUG_ON from ion_page_pool.c Tomer Samara
2020-08-21 15:27 ` Tomer Samara
2020-08-21 17:45 ` kernel test robot
2020-08-22 0:45 ` kernel test robot
2020-08-24 11:22 ` Dan Carpenter [this message]
2020-08-24 11:22 ` Dan Carpenter
2020-08-21 15:28 ` [PATCH v4 2/2] staging: android: Remove BUG from ion_system_heap.c Tomer Samara
2020-08-21 15:28 ` Tomer Samara
2020-08-21 16:25 ` Randy Dunlap
2020-08-21 16:25 ` Randy Dunlap
2020-08-22 9:34 ` Tomer Samara
2020-08-22 9:34 ` Tomer Samara
2020-08-22 14:22 ` Randy Dunlap
2020-08-22 14:22 ` Randy Dunlap
2020-08-24 11:24 ` Dan Carpenter
2020-08-24 11:24 ` Dan Carpenter
2020-08-24 11:27 ` Dan Carpenter
2020-08-24 11:27 ` Dan Carpenter
2020-08-24 11:43 ` Dan Carpenter
2020-08-24 11:43 ` Dan Carpenter
2020-08-25 6:47 ` [PATCH v4 0/2] staging: android: Remove BUG/BUG_ON from ion Christoph Hellwig
2020-08-25 6:52 ` Greg Kroah-Hartman
2020-08-25 6:52 ` Greg Kroah-Hartman
2020-08-27 7:16 ` Christoph Hellwig
2020-08-27 12:15 ` Greg Kroah-Hartman
2020-08-27 12:15 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200824112206.GH1793@kadam \
--to=dan.carpenter@oracle.com \
--cc=arve@android.com \
--cc=christian@brauner.io \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=hridya@google.com \
--cc=joel@joelfernandes.org \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=riandrews@android.com \
--cc=surenb@google.com \
--cc=tkjos@android.com \
--cc=tomersamara98@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.