All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: thomas.tai@oracle.com, syzkaller-bugs@googlegroups.com,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	iommu@lists.linux-foundation.org, kraxel@redhat.com,
	airlied@redhat.com, robin.murphy@arm.com, hch@lst.de,
	syzbot <syzbot+3f86afd0b1e4bf1cb64c@syzkaller.appspotmail.com>
Subject: Re: Is: virtio_gpu_object_shmem_init  issues? Was:Re: upstream boot error: general protection fault in swiotlb_map
Date: Mon, 24 Aug 2020 17:13:00 +0200	[thread overview]
Message-ID: <20200824151300.GA28575@lst.de> (raw)
In-Reply-To: <20200824150650.GD21321@char.us.oracle.com>

On Mon, Aug 24, 2020 at 11:06:51AM -0400, Konrad Rzeszutek Wilk wrote:
> So it fails at
> 
> 683                 dev_WARN_ONCE(dev, 1,                                           
> 684                         "swiotlb addr %pad+%zu overflow (mask %llx, bus limit %llx).\n",
> 685                         &dma_addr, size, *dev->dma_mask, dev->bus_dma_limit);   
> 
> 
> which makes no sense to me as `dev` surely exists. I can see in the console log:
> 
> virtio-pci 0000:00:01.0: vgaarb: deactivate vga console
> 
> So what gives?

Well, look at the if around the WARN_ON - dma_capable failed on the
swiotlb buffer. This means the virtio drm thingy has a dma mask
(either the actual one set by the driver, or bus_dma_mask), which isn't
enough to address the swiotlb buffer.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: thomas.tai@oracle.com, syzkaller-bugs@googlegroups.com,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	iommu@lists.linux-foundation.org, airlied@redhat.com,
	robin.murphy@arm.com, hch@lst.de,
	syzbot <syzbot+3f86afd0b1e4bf1cb64c@syzkaller.appspotmail.com>,
	m.szyprowski@samsung.com
Subject: Re: Is: virtio_gpu_object_shmem_init  issues? Was:Re: upstream boot error: general protection fault in swiotlb_map
Date: Mon, 24 Aug 2020 17:13:00 +0200	[thread overview]
Message-ID: <20200824151300.GA28575@lst.de> (raw)
In-Reply-To: <20200824150650.GD21321@char.us.oracle.com>

On Mon, Aug 24, 2020 at 11:06:51AM -0400, Konrad Rzeszutek Wilk wrote:
> So it fails at
> 
> 683                 dev_WARN_ONCE(dev, 1,                                           
> 684                         "swiotlb addr %pad+%zu overflow (mask %llx, bus limit %llx).\n",
> 685                         &dma_addr, size, *dev->dma_mask, dev->bus_dma_limit);   
> 
> 
> which makes no sense to me as `dev` surely exists. I can see in the console log:
> 
> virtio-pci 0000:00:01.0: vgaarb: deactivate vga console
> 
> So what gives?

Well, look at the if around the WARN_ON - dma_capable failed on the
swiotlb buffer. This means the virtio drm thingy has a dma mask
(either the actual one set by the driver, or bus_dma_mask), which isn't
enough to address the swiotlb buffer.
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: syzbot <syzbot+3f86afd0b1e4bf1cb64c@syzkaller.appspotmail.com>,
	thomas.tai@oracle.com, airlied@redhat.com, kraxel@redhat.com,
	virtualization@lists.linux-foundation.org,
	dri-devel@lists.freedesktop.org, hch@lst.de,
	iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
	m.szyprowski@samsung.com, robin.murphy@arm.com,
	syzkaller-bugs@googlegroups.com
Subject: Re: Is: virtio_gpu_object_shmem_init  issues? Was:Re: upstream boot error: general protection fault in swiotlb_map
Date: Mon, 24 Aug 2020 17:13:00 +0200	[thread overview]
Message-ID: <20200824151300.GA28575@lst.de> (raw)
In-Reply-To: <20200824150650.GD21321@char.us.oracle.com>

On Mon, Aug 24, 2020 at 11:06:51AM -0400, Konrad Rzeszutek Wilk wrote:
> So it fails at
> 
> 683                 dev_WARN_ONCE(dev, 1,                                           
> 684                         "swiotlb addr %pad+%zu overflow (mask %llx, bus limit %llx).\n",
> 685                         &dma_addr, size, *dev->dma_mask, dev->bus_dma_limit);   
> 
> 
> which makes no sense to me as `dev` surely exists. I can see in the console log:
> 
> virtio-pci 0000:00:01.0: vgaarb: deactivate vga console
> 
> So what gives?

Well, look at the if around the WARN_ON - dma_capable failed on the
swiotlb buffer. This means the virtio drm thingy has a dma mask
(either the actual one set by the driver, or bus_dma_mask), which isn't
enough to address the swiotlb buffer.

  reply	other threads:[~2020-08-24 15:13 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-06 10:46 upstream boot error: general protection fault in swiotlb_map syzbot
2020-08-06 10:46 ` syzbot
2020-08-24 15:06 ` Is: virtio_gpu_object_shmem_init issues? Was:Re: " Konrad Rzeszutek Wilk
2020-08-24 15:06   ` Konrad Rzeszutek Wilk
2020-08-24 15:06   ` Konrad Rzeszutek Wilk
2020-08-24 15:06   ` Konrad Rzeszutek Wilk
2020-08-24 15:13   ` Christoph Hellwig [this message]
2020-08-24 15:13     ` Christoph Hellwig
2020-08-24 15:13     ` Christoph Hellwig
2020-08-24 15:17   ` Dmitry Vyukov via iommu
2020-08-24 15:17     ` Dmitry Vyukov
2020-08-24 15:17     ` Dmitry Vyukov
2020-08-24 15:17     ` Dmitry Vyukov via Virtualization
2020-08-27  1:37   ` Thomas Tai
2020-08-27  1:37     ` Thomas Tai
2020-08-27  1:37     ` Thomas Tai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200824151300.GA28575@lst.de \
    --to=hch@lst.de \
    --cc=airlied@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=konrad.wilk@oracle.com \
    --cc=kraxel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=syzbot+3f86afd0b1e4bf1cb64c@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=thomas.tai@oracle.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.