From: Jason Gunthorpe <jgg@nvidia.com>
To: Gal Pressman <galpress@amazon.com>
Cc: Doug Ledford <dledford@redhat.com>, <linux-rdma@vger.kernel.org>,
Alexander Matushevsky <matua@amazon.com>,
Firas JahJah <firasj@amazon.com>,
Yossi Leybovich <sleybo@amazon.com>
Subject: Re: [PATCH for-next] RDMA/efa: Remove redundant udata check from alloc ucontext response
Date: Mon, 24 Aug 2020 14:46:17 -0300 [thread overview]
Message-ID: <20200824174617.GA3257363@nvidia.com> (raw)
In-Reply-To: <20200818110835.54299-1-galpress@amazon.com>
On Tue, Aug 18, 2020 at 02:08:35PM +0300, Gal Pressman wrote:
> The alloc ucontext flow is always called with a valid udata, there's no
> need to test whether it's NULL.
>
> While at it, the 'udata->outlen' check is removed as well as we copy the
> minimum between the size of the response and outlen, so in case of zero
> outlen, zero bytes will be copied.
>
> Reviewed-by: Firas JahJah <firasj@amazon.com>
> Reviewed-by: Yossi Leybovich <sleybo@amazon.com>
> Signed-off-by: Gal Pressman <galpress@amazon.com>
> ---
> drivers/infiniband/hw/efa/efa_verbs.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
Applied to for-next, thanks
Jason
prev parent reply other threads:[~2020-08-24 17:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 11:08 [PATCH for-next] RDMA/efa: Remove redundant udata check from alloc ucontext response Gal Pressman
2020-08-24 17:46 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200824174617.GA3257363@nvidia.com \
--to=jgg@nvidia.com \
--cc=dledford@redhat.com \
--cc=firasj@amazon.com \
--cc=galpress@amazon.com \
--cc=linux-rdma@vger.kernel.org \
--cc=matua@amazon.com \
--cc=sleybo@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.