* [PATCH for-next] RDMA/efa: Remove redundant udata check from alloc ucontext response
@ 2020-08-18 11:08 Gal Pressman
2020-08-24 17:46 ` Jason Gunthorpe
0 siblings, 1 reply; 2+ messages in thread
From: Gal Pressman @ 2020-08-18 11:08 UTC (permalink / raw)
To: Jason Gunthorpe, Doug Ledford
Cc: linux-rdma, Alexander Matushevsky, Gal Pressman, Firas JahJah,
Yossi Leybovich
The alloc ucontext flow is always called with a valid udata, there's no
need to test whether it's NULL.
While at it, the 'udata->outlen' check is removed as well as we copy the
minimum between the size of the response and outlen, so in case of zero
outlen, zero bytes will be copied.
Reviewed-by: Firas JahJah <firasj@amazon.com>
Reviewed-by: Yossi Leybovich <sleybo@amazon.com>
Signed-off-by: Gal Pressman <galpress@amazon.com>
---
drivers/infiniband/hw/efa/efa_verbs.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/infiniband/hw/efa/efa_verbs.c b/drivers/infiniband/hw/efa/efa_verbs.c
index fda175836fb6..b53acd238d36 100644
--- a/drivers/infiniband/hw/efa/efa_verbs.c
+++ b/drivers/infiniband/hw/efa/efa_verbs.c
@@ -1568,12 +1568,10 @@ int efa_alloc_ucontext(struct ib_ucontext *ibucontext, struct ib_udata *udata)
resp.max_tx_batch = dev->dev_attr.max_tx_batch;
resp.min_sq_wr = dev->dev_attr.min_sq_depth;
- if (udata && udata->outlen) {
- err = ib_copy_to_udata(udata, &resp,
- min(sizeof(resp), udata->outlen));
- if (err)
- goto err_dealloc_uar;
- }
+ err = ib_copy_to_udata(udata, &resp,
+ min(sizeof(resp), udata->outlen));
+ if (err)
+ goto err_dealloc_uar;
return 0;
--
2.28.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH for-next] RDMA/efa: Remove redundant udata check from alloc ucontext response
2020-08-18 11:08 [PATCH for-next] RDMA/efa: Remove redundant udata check from alloc ucontext response Gal Pressman
@ 2020-08-24 17:46 ` Jason Gunthorpe
0 siblings, 0 replies; 2+ messages in thread
From: Jason Gunthorpe @ 2020-08-24 17:46 UTC (permalink / raw)
To: Gal Pressman
Cc: Doug Ledford, linux-rdma, Alexander Matushevsky, Firas JahJah,
Yossi Leybovich
On Tue, Aug 18, 2020 at 02:08:35PM +0300, Gal Pressman wrote:
> The alloc ucontext flow is always called with a valid udata, there's no
> need to test whether it's NULL.
>
> While at it, the 'udata->outlen' check is removed as well as we copy the
> minimum between the size of the response and outlen, so in case of zero
> outlen, zero bytes will be copied.
>
> Reviewed-by: Firas JahJah <firasj@amazon.com>
> Reviewed-by: Yossi Leybovich <sleybo@amazon.com>
> Signed-off-by: Gal Pressman <galpress@amazon.com>
> ---
> drivers/infiniband/hw/efa/efa_verbs.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
Applied to for-next, thanks
Jason
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-24 17:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-18 11:08 [PATCH for-next] RDMA/efa: Remove redundant udata check from alloc ucontext response Gal Pressman
2020-08-24 17:46 ` Jason Gunthorpe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.