All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: sagi@grimberg.me, chaitanya.kulkarni@wdc.com,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-nvme@lists.infradead.org, james.smart@broadcom.com,
	hch@lst.de
Subject: Re: [PATCH] nvmet-fc: Fix a missed _irqsave version of spin_lock in 'nvmet_fc_fod_op_done()'
Date: Tue, 25 Aug 2020 07:10:24 +0000	[thread overview]
Message-ID: <20200825071024.GE29268@lst.de> (raw)
In-Reply-To: <20200821075819.152474-1-christophe.jaillet@wanadoo.fr>

On Fri, Aug 21, 2020 at 09:58:19AM +0200, Christophe JAILLET wrote:
> The way 'spin_lock()' and 'spin_lock_irqsave()' are used is not consistent
> in this function.
> 
> Use 'spin_lock_irqsave()' also here, as there is no guarantee that
> interruptions are disabled at that point, according to surrounding code.
> 
> Fixes: a97ec51b37ef ("nvmet_fc: Rework target side abort handling")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> Not tested, only based on what looks logical to me according to
> surrounding code

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: sagi@grimberg.me, chaitanya.kulkarni@wdc.com,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-nvme@lists.infradead.org, james.smart@broadcom.com,
	hch@lst.de
Subject: Re: [PATCH] nvmet-fc: Fix a missed _irqsave version of spin_lock in 'nvmet_fc_fod_op_done()'
Date: Tue, 25 Aug 2020 09:10:24 +0200	[thread overview]
Message-ID: <20200825071024.GE29268@lst.de> (raw)
In-Reply-To: <20200821075819.152474-1-christophe.jaillet@wanadoo.fr>

On Fri, Aug 21, 2020 at 09:58:19AM +0200, Christophe JAILLET wrote:
> The way 'spin_lock()' and 'spin_lock_irqsave()' are used is not consistent
> in this function.
> 
> Use 'spin_lock_irqsave()' also here, as there is no guarantee that
> interruptions are disabled at that point, according to surrounding code.
> 
> Fixes: a97ec51b37ef ("nvmet_fc: Rework target side abort handling")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> Not tested, only based on what looks logical to me according to
> surrounding code

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: james.smart@broadcom.com, hch@lst.de, sagi@grimberg.me,
	chaitanya.kulkarni@wdc.com, linux-nvme@lists.infradead.org,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] nvmet-fc: Fix a missed _irqsave version of spin_lock in 'nvmet_fc_fod_op_done()'
Date: Tue, 25 Aug 2020 09:10:24 +0200	[thread overview]
Message-ID: <20200825071024.GE29268@lst.de> (raw)
In-Reply-To: <20200821075819.152474-1-christophe.jaillet@wanadoo.fr>

On Fri, Aug 21, 2020 at 09:58:19AM +0200, Christophe JAILLET wrote:
> The way 'spin_lock()' and 'spin_lock_irqsave()' are used is not consistent
> in this function.
> 
> Use 'spin_lock_irqsave()' also here, as there is no guarantee that
> interruptions are disabled at that point, according to surrounding code.
> 
> Fixes: a97ec51b37ef ("nvmet_fc: Rework target side abort handling")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> Not tested, only based on what looks logical to me according to
> surrounding code

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

  parent reply	other threads:[~2020-08-25  7:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-21  7:58 [PATCH] nvmet-fc: Fix a missed _irqsave version of spin_lock in 'nvmet_fc_fod_op_done()' Christophe JAILLET
2020-08-21  7:58 ` Christophe JAILLET
2020-08-21  7:58 ` Christophe JAILLET
2020-08-24 20:00 ` Sagi Grimberg
2020-08-24 20:00   ` Sagi Grimberg
2020-08-24 20:00   ` Sagi Grimberg
2020-08-24 21:16   ` Keith Busch
2020-08-24 21:16     ` Keith Busch
2020-08-24 21:16     ` Keith Busch
2020-08-25  7:09     ` Christoph Hellwig
2020-08-25  7:09       ` Christoph Hellwig
2020-08-25  7:09       ` Christoph Hellwig
2020-08-25  7:10 ` Christoph Hellwig [this message]
2020-08-25  7:10   ` Christoph Hellwig
2020-08-25  7:10   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200825071024.GE29268@lst.de \
    --to=hch@lst.de \
    --cc=chaitanya.kulkarni@wdc.com \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=james.smart@broadcom.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.