All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ionela Voinescu <ionela.voinescu@arm.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: rjw@rjwysocki.net, dietmar.eggemann@arm.com,
	catalin.marinas@arm.com, sudeep.holla@arm.com, will@kernel.org,
	valentin.schneider@arm.com, linux-pm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/5] cpufreq: report whether cpufreq supports Frequency Invariance (FI)
Date: Tue, 25 Aug 2020 12:07:56 +0100	[thread overview]
Message-ID: <20200825110747.GA12506@arm.com> (raw)
In-Reply-To: <20200825062709.dlzztu547idco7zw@vireshk-i7>

Hi Viresh,

On Tuesday 25 Aug 2020 at 11:57:09 (+0530), Viresh Kumar wrote:
[..]
> > +static inline
> > +void enable_cpufreq_freq_invariance(struct cpufreq_driver *driver)
> > +{
> > +	if (!driver->setpolicy) {
> > +		static_branch_enable_cpuslocked(&cpufreq_freq_invariance);
> > +		pr_debug("supports frequency invariance");
> > +	}
> > +}
> > +
> 
> I would rather open-code this int the cpufreq_register_driver() routine as
> that's what is done in cpufreq_unregister_driver() as well.
> 
> > +bool cpufreq_supports_freq_invariance(void)
> > +{
> > +	return static_branch_likely(&cpufreq_freq_invariance);
> > +}
> > +
> 
> And would keep the definition of the static key with this routine at a single
> place.

Makes sense and will do!

Thank you for the quick review,
Ionela.

WARNING: multiple messages have this Message-ID (diff)
From: Ionela Voinescu <ionela.voinescu@arm.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: linux-pm@vger.kernel.org, catalin.marinas@arm.com,
	rjw@rjwysocki.net, linux-kernel@vger.kernel.org,
	dietmar.eggemann@arm.com, sudeep.holla@arm.com, will@kernel.org,
	valentin.schneider@arm.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 3/5] cpufreq: report whether cpufreq supports Frequency Invariance (FI)
Date: Tue, 25 Aug 2020 12:07:56 +0100	[thread overview]
Message-ID: <20200825110747.GA12506@arm.com> (raw)
In-Reply-To: <20200825062709.dlzztu547idco7zw@vireshk-i7>

Hi Viresh,

On Tuesday 25 Aug 2020 at 11:57:09 (+0530), Viresh Kumar wrote:
[..]
> > +static inline
> > +void enable_cpufreq_freq_invariance(struct cpufreq_driver *driver)
> > +{
> > +	if (!driver->setpolicy) {
> > +		static_branch_enable_cpuslocked(&cpufreq_freq_invariance);
> > +		pr_debug("supports frequency invariance");
> > +	}
> > +}
> > +
> 
> I would rather open-code this int the cpufreq_register_driver() routine as
> that's what is done in cpufreq_unregister_driver() as well.
> 
> > +bool cpufreq_supports_freq_invariance(void)
> > +{
> > +	return static_branch_likely(&cpufreq_freq_invariance);
> > +}
> > +
> 
> And would keep the definition of the static key with this routine at a single
> place.

Makes sense and will do!

Thank you for the quick review,
Ionela.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-08-25 11:08 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-24 21:02 [PATCH v3 0/5] cpufreq: improve frequency invariance support Ionela Voinescu
2020-08-24 21:02 ` Ionela Voinescu
2020-08-24 21:02 ` [PATCH v3 1/5] arch_topology: validate input frequencies to arch_set_freq_scale() Ionela Voinescu
2020-08-24 21:02   ` Ionela Voinescu
2020-08-25  5:56   ` Viresh Kumar
2020-08-25  5:56     ` Viresh Kumar
2020-08-25 11:31     ` Ionela Voinescu
2020-08-25 11:31       ` Ionela Voinescu
2020-08-27  6:10       ` Viresh Kumar
2020-08-27  6:10         ` Viresh Kumar
2020-08-24 21:02 ` [PATCH v3 2/5] cpufreq: move invariance setter calls in cpufreq core Ionela Voinescu
2020-08-24 21:02   ` Ionela Voinescu
2020-08-25  6:03   ` Viresh Kumar
2020-08-25  6:03     ` Viresh Kumar
2020-08-24 21:02 ` [PATCH v3 3/5] cpufreq: report whether cpufreq supports Frequency Invariance (FI) Ionela Voinescu
2020-08-24 21:02   ` Ionela Voinescu
2020-08-25  6:27   ` Viresh Kumar
2020-08-25  6:27     ` Viresh Kumar
2020-08-25 11:07     ` Ionela Voinescu [this message]
2020-08-25 11:07       ` Ionela Voinescu
2020-08-24 21:02 ` [PATCH v3 4/5] arch_topology, cpufreq: constify arch_* cpumasks Ionela Voinescu
2020-08-24 21:02   ` Ionela Voinescu
2020-08-25  6:27   ` Viresh Kumar
2020-08-25  6:27     ` Viresh Kumar
2020-08-24 21:02 ` [PATCH v3 5/5] arch_topology, arm, arm64: define arch_scale_freq_invariant() Ionela Voinescu
2020-08-24 21:02   ` Ionela Voinescu
2020-08-25  7:50   ` Viresh Kumar
2020-08-25  7:50     ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200825110747.GA12506@arm.com \
    --to=ionela.voinescu@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=sudeep.holla@arm.com \
    --cc=valentin.schneider@arm.com \
    --cc=viresh.kumar@linaro.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.