From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org,
"Rafael J. Wysocki" <rafael@kernel.org>,
Qu Wenruo <quwenruo.btrfs@gmx.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>
Subject: Re: [PATCH v2] kobject: Restore old behaviour of kobject_del(NULL)
Date: Tue, 25 Aug 2020 17:45:48 +0200 [thread overview]
Message-ID: <20200825154548.GA1514525@kroah.com> (raw)
In-Reply-To: <20200825144109.GN1891694@smile.fi.intel.com>
On Tue, Aug 25, 2020 at 05:41:09PM +0300, Andy Shevchenko wrote:
> On Mon, Aug 03, 2020 at 11:46:59AM +0200, Greg Kroah-Hartman wrote:
> > On Mon, Aug 03, 2020 at 11:27:06AM +0300, Andy Shevchenko wrote:
> > > The commit 079ad2fb4bf9 ("kobject: Avoid premature parent object freeing in
> > > kobject_cleanup()") inadvertently dropped a possibility to call kobject_del()
> > > with NULL pointer. Restore the old behaviour.
> > >
> > > Fixes: 079ad2fb4bf9 ("kobject: Avoid premature parent object freeing in kobject_cleanup()")
> > > Reported-by: Qu Wenruo <quwenruo.btrfs@gmx.com>
> > > Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > ---
> > > v2: replaced ?: with plain conditional (Greg)
> > > lib/kobject.c | 6 +++++-
> > > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > Thanks, much better, will queue up after -rc1 is out.
>
> Shouldn't be this taken care of?
Yes, will get to it soon, after -rc1 is tough, combined with Plumbers...
greg k-h
prev parent reply other threads:[~2020-08-25 15:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 8:27 [PATCH v2] kobject: Restore old behaviour of kobject_del(NULL) Andy Shevchenko
2020-08-03 8:45 ` Qu Wenruo
2020-08-03 9:46 ` Greg Kroah-Hartman
2020-08-25 14:41 ` Andy Shevchenko
2020-08-25 15:45 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200825154548.GA1514525@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.