All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: Zhu Lingshan <lingshan.zhu@intel.com>,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 1/2] vdpa: ifcvf: return err when fail to request config irq
Date: Wed, 26 Aug 2020 07:12:06 -0400	[thread overview]
Message-ID: <20200826071200-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <87ec5f62-4d99-e7b4-00dc-28664f8eb111@redhat.com>

On Fri, Aug 07, 2020 at 11:52:09AM +0800, Jason Wang wrote:
> 
> On 2020/7/23 下午5:12, Jason Wang wrote:
> > We ignore the err of requesting config interrupt, fix this.
> > 
> > Fixes: e7991f376a4d ("ifcvf: implement config interrupt in IFCVF")
> > Cc: Zhu Lingshan <lingshan.zhu@intel.com>
> > Signed-off-by: Jason Wang <jasowang@redhat.com>
> > ---
> >   drivers/vdpa/ifcvf/ifcvf_main.c | 4 ++++
> >   1 file changed, 4 insertions(+)
> > 
> > diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c b/drivers/vdpa/ifcvf/ifcvf_main.c
> > index f5a60c14b979..ae7110955a44 100644
> > --- a/drivers/vdpa/ifcvf/ifcvf_main.c
> > +++ b/drivers/vdpa/ifcvf/ifcvf_main.c
> > @@ -76,6 +76,10 @@ static int ifcvf_request_irq(struct ifcvf_adapter *adapter)
> >   	ret = devm_request_irq(&pdev->dev, irq,
> >   			       ifcvf_config_changed, 0,
> >   			       vf->config_msix_name, vf);
> > +	if (ret) {
> > +		IFCVF_ERR(pdev, "Failed to request config irq\n");
> > +		return ret;
> > +	}
> >   	for (i = 0; i < IFCVF_MAX_QUEUE_PAIRS * 2; i++) {
> >   		snprintf(vf->vring[i].msix_name, 256, "ifcvf[%s]-%d\n",
> 
> 
> Hi Michael:
> 
> Any comments on this series?
> 
> Thanks
> 

Applied, thanks!

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org,
	Zhu Lingshan <lingshan.zhu@intel.com>
Subject: Re: [PATCH 1/2] vdpa: ifcvf: return err when fail to request config irq
Date: Wed, 26 Aug 2020 07:12:06 -0400	[thread overview]
Message-ID: <20200826071200-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <87ec5f62-4d99-e7b4-00dc-28664f8eb111@redhat.com>

On Fri, Aug 07, 2020 at 11:52:09AM +0800, Jason Wang wrote:
> 
> On 2020/7/23 下午5:12, Jason Wang wrote:
> > We ignore the err of requesting config interrupt, fix this.
> > 
> > Fixes: e7991f376a4d ("ifcvf: implement config interrupt in IFCVF")
> > Cc: Zhu Lingshan <lingshan.zhu@intel.com>
> > Signed-off-by: Jason Wang <jasowang@redhat.com>
> > ---
> >   drivers/vdpa/ifcvf/ifcvf_main.c | 4 ++++
> >   1 file changed, 4 insertions(+)
> > 
> > diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c b/drivers/vdpa/ifcvf/ifcvf_main.c
> > index f5a60c14b979..ae7110955a44 100644
> > --- a/drivers/vdpa/ifcvf/ifcvf_main.c
> > +++ b/drivers/vdpa/ifcvf/ifcvf_main.c
> > @@ -76,6 +76,10 @@ static int ifcvf_request_irq(struct ifcvf_adapter *adapter)
> >   	ret = devm_request_irq(&pdev->dev, irq,
> >   			       ifcvf_config_changed, 0,
> >   			       vf->config_msix_name, vf);
> > +	if (ret) {
> > +		IFCVF_ERR(pdev, "Failed to request config irq\n");
> > +		return ret;
> > +	}
> >   	for (i = 0; i < IFCVF_MAX_QUEUE_PAIRS * 2; i++) {
> >   		snprintf(vf->vring[i].msix_name, 256, "ifcvf[%s]-%d\n",
> 
> 
> Hi Michael:
> 
> Any comments on this series?
> 
> Thanks
> 

Applied, thanks!


  reply	other threads:[~2020-08-26 11:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-23  9:12 [PATCH 1/2] vdpa: ifcvf: return err when fail to request config irq Jason Wang
2020-07-23  9:12 ` [PATCH 2/2] vdpa: ifcvf: free config irq in ifcvf_free_irq() Jason Wang
2020-08-07  3:52 ` [PATCH 1/2] vdpa: ifcvf: return err when fail to request config irq Jason Wang
2020-08-07  3:52   ` Jason Wang
2020-08-26 11:12   ` Michael S. Tsirkin [this message]
2020-08-26 11:12     ` Michael S. Tsirkin
2020-08-12  7:39 ` Maxime Coquelin
2020-08-12  7:39   ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200826071200-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=lingshan.zhu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.