* [PATCH] rnbd: Fix an error code in process_rdma()
@ 2020-08-26 11:32 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2020-08-26 11:32 UTC (permalink / raw)
To: Danil Kipnis
Cc: Jack Wang, Jens Axboe, Guoqing Jiang, linux-block,
kernel-janitors
The error code is uninitialized on this error path.
Fixes: 735d77d4fd28 ("rnbd: remove rnbd_dev_submit_io")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/block/rnbd/rnbd-srv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/block/rnbd/rnbd-srv.c b/drivers/block/rnbd/rnbd-srv.c
index 0fb94843a495..5b69bc56b225 100644
--- a/drivers/block/rnbd/rnbd-srv.c
+++ b/drivers/block/rnbd/rnbd-srv.c
@@ -149,6 +149,7 @@ static int process_rdma(struct rtrs_srv *sess,
bio = rnbd_bio_map_kern(data, sess_dev->rnbd_dev->ibd_bio_set, datalen, GFP_KERNEL);
if (IS_ERR(bio)) {
rnbd_srv_err(sess_dev, "Failed to generate bio, err: %ld\n", PTR_ERR(bio));
+ err = PTR_ERR(bio);
goto sess_dev_put;
}
--
2.28.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] rnbd: Fix an error code in process_rdma()
@ 2020-08-26 11:32 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2020-08-26 11:32 UTC (permalink / raw)
To: Danil Kipnis
Cc: Jack Wang, Jens Axboe, Guoqing Jiang, linux-block,
kernel-janitors
The error code is uninitialized on this error path.
Fixes: 735d77d4fd28 ("rnbd: remove rnbd_dev_submit_io")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/block/rnbd/rnbd-srv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/block/rnbd/rnbd-srv.c b/drivers/block/rnbd/rnbd-srv.c
index 0fb94843a495..5b69bc56b225 100644
--- a/drivers/block/rnbd/rnbd-srv.c
+++ b/drivers/block/rnbd/rnbd-srv.c
@@ -149,6 +149,7 @@ static int process_rdma(struct rtrs_srv *sess,
bio = rnbd_bio_map_kern(data, sess_dev->rnbd_dev->ibd_bio_set, datalen, GFP_KERNEL);
if (IS_ERR(bio)) {
rnbd_srv_err(sess_dev, "Failed to generate bio, err: %ld\n", PTR_ERR(bio));
+ err = PTR_ERR(bio);
goto sess_dev_put;
}
--
2.28.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] rnbd: Fix an error code in process_rdma()
2020-08-26 11:32 ` Dan Carpenter
@ 2020-08-26 13:13 ` Guoqing Jiang
-1 siblings, 0 replies; 6+ messages in thread
From: Guoqing Jiang @ 2020-08-26 13:13 UTC (permalink / raw)
To: Dan Carpenter, Danil Kipnis
Cc: Jack Wang, Jens Axboe, linux-block, kernel-janitors
On 8/26/20 13:32, Dan Carpenter wrote:
> The error code is uninitialized on this error path.
>
> Fixes: 735d77d4fd28 ("rnbd: remove rnbd_dev_submit_io")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/block/rnbd/rnbd-srv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/block/rnbd/rnbd-srv.c b/drivers/block/rnbd/rnbd-srv.c
> index 0fb94843a495..5b69bc56b225 100644
> --- a/drivers/block/rnbd/rnbd-srv.c
> +++ b/drivers/block/rnbd/rnbd-srv.c
> @@ -149,6 +149,7 @@ static int process_rdma(struct rtrs_srv *sess,
> bio = rnbd_bio_map_kern(data, sess_dev->rnbd_dev->ibd_bio_set, datalen, GFP_KERNEL);
> if (IS_ERR(bio)) {
> rnbd_srv_err(sess_dev, "Failed to generate bio, err: %ld\n", PTR_ERR(bio));
> + err = PTR_ERR(bio);
> goto sess_dev_put;
> }
>
Thanks for the fix, Acked-by: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
Guoqing
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] rnbd: Fix an error code in process_rdma()
@ 2020-08-26 13:13 ` Guoqing Jiang
0 siblings, 0 replies; 6+ messages in thread
From: Guoqing Jiang @ 2020-08-26 13:13 UTC (permalink / raw)
To: Dan Carpenter, Danil Kipnis
Cc: Jack Wang, Jens Axboe, linux-block, kernel-janitors
On 8/26/20 13:32, Dan Carpenter wrote:
> The error code is uninitialized on this error path.
>
> Fixes: 735d77d4fd28 ("rnbd: remove rnbd_dev_submit_io")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/block/rnbd/rnbd-srv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/block/rnbd/rnbd-srv.c b/drivers/block/rnbd/rnbd-srv.c
> index 0fb94843a495..5b69bc56b225 100644
> --- a/drivers/block/rnbd/rnbd-srv.c
> +++ b/drivers/block/rnbd/rnbd-srv.c
> @@ -149,6 +149,7 @@ static int process_rdma(struct rtrs_srv *sess,
> bio = rnbd_bio_map_kern(data, sess_dev->rnbd_dev->ibd_bio_set, datalen, GFP_KERNEL);
> if (IS_ERR(bio)) {
> rnbd_srv_err(sess_dev, "Failed to generate bio, err: %ld\n", PTR_ERR(bio));
> + err = PTR_ERR(bio);
> goto sess_dev_put;
> }
>
Thanks for the fix, Acked-by: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
Guoqing
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] rnbd: Fix an error code in process_rdma()
2020-08-26 11:32 ` Dan Carpenter
@ 2020-08-26 13:29 ` Jens Axboe
-1 siblings, 0 replies; 6+ messages in thread
From: Jens Axboe @ 2020-08-26 13:29 UTC (permalink / raw)
To: Dan Carpenter, Danil Kipnis
Cc: Jack Wang, Guoqing Jiang, linux-block, kernel-janitors
On 8/26/20 5:32 AM, Dan Carpenter wrote:
> The error code is uninitialized on this error path.
The fix is in Linus's tree:
commit 17bc10300c69bd51b82983cdadafa0a7791f074e
Author: Nathan Chancellor <natechancellor@gmail.com>
Date: Mon Aug 17 23:49:25 2020 -0700
block/rnbd: Ensure err is always initialized in process_rdma
--
Jens Axboe
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] rnbd: Fix an error code in process_rdma()
@ 2020-08-26 13:29 ` Jens Axboe
0 siblings, 0 replies; 6+ messages in thread
From: Jens Axboe @ 2020-08-26 13:29 UTC (permalink / raw)
To: Dan Carpenter, Danil Kipnis
Cc: Jack Wang, Guoqing Jiang, linux-block, kernel-janitors
On 8/26/20 5:32 AM, Dan Carpenter wrote:
> The error code is uninitialized on this error path.
The fix is in Linus's tree:
commit 17bc10300c69bd51b82983cdadafa0a7791f074e
Author: Nathan Chancellor <natechancellor@gmail.com>
Date: Mon Aug 17 23:49:25 2020 -0700
block/rnbd: Ensure err is always initialized in process_rdma
--
Jens Axboe
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-08-26 13:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-26 11:32 [PATCH] rnbd: Fix an error code in process_rdma() Dan Carpenter
2020-08-26 11:32 ` Dan Carpenter
2020-08-26 13:13 ` Guoqing Jiang
2020-08-26 13:13 ` Guoqing Jiang
2020-08-26 13:29 ` Jens Axboe
2020-08-26 13:29 ` Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.