From: Michael Auchter <michael.auchter@ni.com>
To: Ben Levinsky <ben.levinsky@xilinx.com>
Cc: stefano.stabellini@xilinx.com, michals@xilinx.com,
devicetree@vger.kernel.org, mathieu.poirier@linaro.org,
emooring@xilinx.com, linux-remoteproc@vger.kernel.org,
linux-kernel@vger.kernel.org, jliang@xilinx.com,
robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v9 0/5] Provide basic driver to control Arm R5 co-processor found on Xilinx ZynqMP
Date: Thu, 27 Aug 2020 08:47:42 -0500 [thread overview]
Message-ID: <20200827134742.GB404249@xaphan> (raw)
In-Reply-To: <20200827015810.11157-1-ben.levinsky@xilinx.com>
Hey Ben,
On Wed, Aug 26, 2020 at 06:58:05PM -0700, Ben Levinsky wrote:
> v10:
> - add include types.h to xlnx-zynqmp.h for compilation
I appreciate the quick turnaround on v10, but it looks like much of my
feedback on v9 went unacknowledged.
Most concerning is the fact that loading firmware on to R5 1 is _still_
broken in v10 due to the incorrect TCM banks being used.
Thanks,
Michael
>
> Ben Levinsky (5):
> firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU
> configuration.
> firmware: xilinx: Add shutdown/wakeup APIs
> firmware: xilinx: Add RPU configuration APIs
> dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc
> bindings
> remoteproc: Add initial zynqmp R5 remoteproc driver
>
> .../xilinx,zynqmp-r5-remoteproc.yaml | 113 +++
> drivers/firmware/xilinx/zynqmp.c | 86 ++
> drivers/remoteproc/Kconfig | 10 +
> drivers/remoteproc/Makefile | 1 +
> drivers/remoteproc/zynqmp_r5_remoteproc.c | 898 ++++++++++++++++++
> include/linux/firmware/xlnx-zynqmp.h | 63 ++
> 6 files changed, 1171 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/remoteproc/xilinx,zynqmp-r5-remoteproc.yaml
> create mode 100644 drivers/remoteproc/zynqmp_r5_remoteproc.c
>
> --
> 2.17.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Michael Auchter <michael.auchter@ni.com>
To: Ben Levinsky <ben.levinsky@xilinx.com>
Cc: devicetree@vger.kernel.org, emooring@xilinx.com,
mathieu.poirier@linaro.org, linux-remoteproc@vger.kernel.org,
linux-kernel@vger.kernel.org, jliang@xilinx.com,
robh+dt@kernel.org, michals@xilinx.com,
stefano.stabellini@xilinx.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v9 0/5] Provide basic driver to control Arm R5 co-processor found on Xilinx ZynqMP
Date: Thu, 27 Aug 2020 08:47:42 -0500 [thread overview]
Message-ID: <20200827134742.GB404249@xaphan> (raw)
In-Reply-To: <20200827015810.11157-1-ben.levinsky@xilinx.com>
Hey Ben,
On Wed, Aug 26, 2020 at 06:58:05PM -0700, Ben Levinsky wrote:
> v10:
> - add include types.h to xlnx-zynqmp.h for compilation
I appreciate the quick turnaround on v10, but it looks like much of my
feedback on v9 went unacknowledged.
Most concerning is the fact that loading firmware on to R5 1 is _still_
broken in v10 due to the incorrect TCM banks being used.
Thanks,
Michael
>
> Ben Levinsky (5):
> firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU
> configuration.
> firmware: xilinx: Add shutdown/wakeup APIs
> firmware: xilinx: Add RPU configuration APIs
> dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc
> bindings
> remoteproc: Add initial zynqmp R5 remoteproc driver
>
> .../xilinx,zynqmp-r5-remoteproc.yaml | 113 +++
> drivers/firmware/xilinx/zynqmp.c | 86 ++
> drivers/remoteproc/Kconfig | 10 +
> drivers/remoteproc/Makefile | 1 +
> drivers/remoteproc/zynqmp_r5_remoteproc.c | 898 ++++++++++++++++++
> include/linux/firmware/xlnx-zynqmp.h | 63 ++
> 6 files changed, 1171 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/remoteproc/xilinx,zynqmp-r5-remoteproc.yaml
> create mode 100644 drivers/remoteproc/zynqmp_r5_remoteproc.c
>
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-27 14:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 1:58 [PATCH v9 0/5] Provide basic driver to control Arm R5 co-processor found on Xilinx ZynqMP Ben Levinsky
2020-08-27 1:58 ` Ben Levinsky
2020-08-27 1:58 ` [PATCH v10 1/5] firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration Ben Levinsky
2020-08-27 1:58 ` Ben Levinsky
2020-08-27 1:58 ` [PATCH v10 2/5] firmware: xilinx: Add shutdown/wakeup APIs Ben Levinsky
2020-08-27 1:58 ` Ben Levinsky
2020-08-27 1:58 ` [PATCH v10 3/5] firmware: xilinx: Add RPU configuration APIs Ben Levinsky
2020-08-27 1:58 ` Ben Levinsky
2020-08-27 1:58 ` [PATCH v10 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings Ben Levinsky
2020-08-27 1:58 ` Ben Levinsky
2020-08-28 21:39 ` Rob Herring
2020-08-28 21:39 ` Rob Herring
2020-08-27 1:58 ` [PATCH v10 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver Ben Levinsky
2020-08-27 1:58 ` Ben Levinsky
2020-08-27 13:47 ` Michael Auchter [this message]
2020-08-27 13:47 ` [PATCH v9 0/5] Provide basic driver to control Arm R5 co-processor found on Xilinx ZynqMP Michael Auchter
2020-08-27 15:34 ` Ben Levinsky
2020-08-27 15:34 ` Ben Levinsky
2020-08-27 18:43 ` Michael Auchter
2020-08-27 18:43 ` Michael Auchter
-- strict thread matches above, loose matches on Subject: below --
2020-08-26 16:13 Ben Levinsky
2020-08-26 16:13 ` Ben Levinsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200827134742.GB404249@xaphan \
--to=michael.auchter@ni.com \
--cc=ben.levinsky@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=emooring@xilinx.com \
--cc=jliang@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=michals@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=stefano.stabellini@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.