All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: devicetree@vger.kernel.org, rjones@gateworks.com,
	Anson.Huang@nxp.com, marcel.ziswiler@toradex.com,
	shawnguo@kernel.org, s.hauer@pengutronix.de,
	linux-kernel@vger.kernel.org, leoyang.li@nxp.com,
	michael@walle.cc, robh+dt@kernel.org, linux-imx@nxp.com,
	kernel@pengutronix.de, j.neuschaefer@gmx.net,
	sebastien.szymanski@armadeus.com, letux-kernel@openphoenux.org,
	festevam@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/2] ARM: dts: imx: add devicetree for Tolino Shine 2 HD
Date: Thu, 27 Aug 2020 20:33:23 +0200	[thread overview]
Message-ID: <20200827183323.GE103070@latitude> (raw)
In-Reply-To: <20200826204251.5082-3-andreas@kemnade.info>


[-- Attachment #1.1: Type: text/plain, Size: 1051 bytes --]

On Wed, Aug 26, 2020 at 10:42:51PM +0200, Andreas Kemnade wrote:
> This adds a devicetree for the Tolino Shine 2 HD Ebook reader. It is based
> on boards marked with "37NB-E60QF0+4A2". It is equipped with an i.MX6SL
> SoC.
> 
> Expected to work:
> - Buttons
> - Wifi
> - Touchscreen
> - LED
> - uSD
> - USB
> - RTC
> 
> Not working due to missing drivers:
> - Backlight (requires NTXEC driver)
> - EPD
> 
> Not working due to unknown reasons:
> - deep sleep (echo standby >/sys/power/state works),
>   wakeup fails when imx_gpc_pre_suspend(true) was called.
> 
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
[...]
> +		fl {
> +			label = "Frontlight";
> +			gpios = <&gpio3 26 GPIO_ACTIVE_LOW>;
> +			linux,code = <KEY_BRIGHTNESS_CYCLE>;
> +		};

Another option might be KEY_BRIGHTNESS_TOGGLE/KEY_DISPLAYTOGGLE, but
it's not a perfect match, either. (And perhaps a worse match due to the
connotation of turning the display off.)


Reviewed-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>

Thanks

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
	Anson.Huang@nxp.com, marcel.ziswiler@toradex.com,
	sebastien.szymanski@armadeus.com, michael@walle.cc,
	rjones@gateworks.com, leoyang.li@nxp.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, j.neuschaefer@gmx.net,
	letux-kernel@openphoenux.org
Subject: Re: [PATCH v2 2/2] ARM: dts: imx: add devicetree for Tolino Shine 2 HD
Date: Thu, 27 Aug 2020 20:33:23 +0200	[thread overview]
Message-ID: <20200827183323.GE103070@latitude> (raw)
In-Reply-To: <20200826204251.5082-3-andreas@kemnade.info>

[-- Attachment #1: Type: text/plain, Size: 1051 bytes --]

On Wed, Aug 26, 2020 at 10:42:51PM +0200, Andreas Kemnade wrote:
> This adds a devicetree for the Tolino Shine 2 HD Ebook reader. It is based
> on boards marked with "37NB-E60QF0+4A2". It is equipped with an i.MX6SL
> SoC.
> 
> Expected to work:
> - Buttons
> - Wifi
> - Touchscreen
> - LED
> - uSD
> - USB
> - RTC
> 
> Not working due to missing drivers:
> - Backlight (requires NTXEC driver)
> - EPD
> 
> Not working due to unknown reasons:
> - deep sleep (echo standby >/sys/power/state works),
>   wakeup fails when imx_gpc_pre_suspend(true) was called.
> 
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
[...]
> +		fl {
> +			label = "Frontlight";
> +			gpios = <&gpio3 26 GPIO_ACTIVE_LOW>;
> +			linux,code = <KEY_BRIGHTNESS_CYCLE>;
> +		};

Another option might be KEY_BRIGHTNESS_TOGGLE/KEY_DISPLAYTOGGLE, but
it's not a perfect match, either. (And perhaps a worse match due to the
connotation of turning the display off.)


Reviewed-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>

Thanks

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-08-27 18:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-26 20:42 [PATCH v2 0/2] ARM: dts: add Tolino Shine 2 HD Andreas Kemnade
2020-08-26 20:42 ` Andreas Kemnade
2020-08-26 20:42 ` [PATCH v2 1/2] dt-bindings: arm: fsl: add compatible string for " Andreas Kemnade
2020-08-26 20:42   ` Andreas Kemnade
2020-08-26 20:42 ` [PATCH v2 2/2] ARM: dts: imx: add devicetree " Andreas Kemnade
2020-08-26 20:42   ` Andreas Kemnade
2020-08-27 18:33   ` Jonathan Neuschäfer [this message]
2020-08-27 18:33     ` Jonathan Neuschäfer
2020-08-31 17:26     ` Andreas Kemnade
2020-08-31 17:26       ` Andreas Kemnade
2020-09-05  1:39 ` [PATCH v2 0/2] ARM: dts: add " Shawn Guo
2020-09-05  1:39   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200827183323.GE103070@latitude \
    --to=j.neuschaefer@gmx.net \
    --cc=Anson.Huang@nxp.com \
    --cc=andreas@kemnade.info \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=leoyang.li@nxp.com \
    --cc=letux-kernel@openphoenux.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel.ziswiler@toradex.com \
    --cc=michael@walle.cc \
    --cc=rjones@gateworks.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=sebastien.szymanski@armadeus.com \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.