From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 08/23] jfs: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code
Date: Fri, 28 Aug 2020 06:25:33 +0800 [thread overview]
Message-ID: <202008280657.jf45bVXT%lkp@intel.com> (raw)
In-Reply-To: <9797d150e126542889c4a8c0601f997a8199e900.1598518912.git.brookxu@tencent.com>
[-- Attachment #1: Type: text/plain, Size: 7574 bytes --]
Hi Chunguang,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on mkp-scsi/for-next]
[also build test ERROR on scsi/for-next block/for-next linus/master asm-generic/master v5.9-rc2 next-20200827]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Chunguang-Xu/clean-up-the-code-related-to-ASSERT/20200827-182148
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from fs/jfs/jfs_xtree.h:12,
from fs/jfs/jfs_incore.h:16,
from fs/jfs/jfs_xtree.c:13:
fs/jfs/jfs_xtree.c: In function 'xtSearch':
>> fs/jfs/jfs_btree.h:119:2: error: implicit declaration of function 'assert' [-Werror=implicit-function-declaration]
119 | assert(!BT_STACK_FULL(BTSTACK));\
| ^~~~~~
fs/jfs/jfs_xtree.c:494:3: note: in expansion of macro 'BT_PUSH'
494 | BT_PUSH(btstack, bn, index);
| ^~~~~~~
fs/jfs/jfs_xtree.c:20:1: note: 'assert' is defined in header '<assert.h>'; did you forget to '#include <assert.h>'?
19 | #include "jfs_debug.h"
+++ |+#include <assert.h>
20 |
cc1: some warnings being treated as errors
--
In file included from fs/jfs/jfs_xtree.h:12,
from fs/jfs/jfs_incore.h:16,
from fs/jfs/jfs_dtree.c:93:
fs/jfs/jfs_dtree.c: In function 'dtSearch':
>> fs/jfs/jfs_btree.h:119:2: error: implicit declaration of function 'assert' [-Werror=implicit-function-declaration]
119 | assert(!BT_STACK_FULL(BTSTACK));\
| ^~~~~~
fs/jfs/jfs_dtree.c:775:3: note: in expansion of macro 'BT_PUSH'
775 | BT_PUSH(btstack, bn, index);
| ^~~~~~~
fs/jfs/jfs_dtree.c:100:1: note: 'assert' is defined in header '<assert.h>'; did you forget to '#include <assert.h>'?
99 | #include "jfs_debug.h"
+++ |+#include <assert.h>
100 |
cc1: some warnings being treated as errors
--
fs/jfs/namei.c: In function 'jfs_unlink':
>> fs/jfs/namei.c:524:3: error: implicit declaration of function 'assert' [-Werror=implicit-function-declaration]
524 | assert(!test_cflag(COMMIT_Nolink, ip));
| ^~~~~~
fs/jfs/namei.c:22:1: note: 'assert' is defined in header '<assert.h>'; did you forget to '#include <assert.h>'?
21 | #include "jfs_debug.h"
+++ |+#include <assert.h>
22 |
cc1: some warnings being treated as errors
--
fs/jfs/jfs_imap.c: In function 'diWrite':
>> fs/jfs/jfs_imap.c:679:3: error: implicit declaration of function 'assert' [-Werror=implicit-function-declaration]
679 | assert(tlck->type & tlckXTREE);
| ^~~~~~
fs/jfs/jfs_imap.c:46:1: note: 'assert' is defined in header '<assert.h>'; did you forget to '#include <assert.h>'?
45 | #include "jfs_debug.h"
+++ |+#include <assert.h>
46 |
cc1: some warnings being treated as errors
--
fs/jfs/jfs_dmap.c: In function 'dbAlloc':
>> fs/jfs/jfs_dmap.c:700:2: error: implicit declaration of function 'assert' [-Werror=implicit-function-declaration]
700 | assert(nblocks > 0);
| ^~~~~~
fs/jfs/jfs_dmap.c:17:1: note: 'assert' is defined in header '<assert.h>'; did you forget to '#include <assert.h>'?
16 | #include "jfs_discard.h"
+++ |+#include <assert.h>
17 |
cc1: some warnings being treated as errors
--
fs/jfs/jfs_metapage.c: In function 'release_metapage':
>> fs/jfs/jfs_metapage.c:739:2: error: implicit declaration of function 'assert' [-Werror=implicit-function-declaration]
739 | assert(mp->count);
| ^~~~~~
fs/jfs/jfs_metapage.c:22:1: note: 'assert' is defined in header '<assert.h>'; did you forget to '#include <assert.h>'?
21 | #include "jfs_debug.h"
+++ |+#include <assert.h>
22 |
cc1: some warnings being treated as errors
--
fs/jfs/jfs_logmgr.c: In function 'jfs_flush_journal':
>> fs/jfs/jfs_logmgr.c:1595:2: error: implicit declaration of function 'assert' [-Werror=implicit-function-declaration]
1595 | assert(list_empty(&log->cqueue));
| ^~~~~~
fs/jfs/jfs_logmgr.c:68:1: note: 'assert' is defined in header '<assert.h>'; did you forget to '#include <assert.h>'?
67 | #include "jfs_debug.h"
+++ |+#include <assert.h>
68 |
cc1: some warnings being treated as errors
--
fs/jfs/jfs_txnmgr.c: In function 'txEnd':
>> fs/jfs/jfs_txnmgr.c:523:2: error: implicit declaration of function 'assert' [-Werror=implicit-function-declaration]
523 | assert(tblk->next == 0);
| ^~~~~~
fs/jfs/jfs_txnmgr.c:49:1: note: 'assert' is defined in header '<assert.h>'; did you forget to '#include <assert.h>'?
48 | #include "jfs_debug.h"
+++ |+#include <assert.h>
49 |
cc1: some warnings being treated as errors
--
fs/jfs/xattr.c: In function 'ea_write_inline':
>> fs/jfs/xattr.c:153:3: error: implicit declaration of function 'assert' [-Werror=implicit-function-declaration]
153 | assert(size <= sizeof (ji->i_inline_ea));
| ^~~~~~
fs/jfs/xattr.c:23:1: note: 'assert' is defined in header '<assert.h>'; did you forget to '#include <assert.h>'?
22 | #include "jfs_acl.h"
+++ |+#include <assert.h>
23 |
cc1: some warnings being treated as errors
# https://github.com/0day-ci/linux/commit/073244e1adc3932156c9523a347b3edec3d87a9d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Chunguang-Xu/clean-up-the-code-related-to-ASSERT/20200827-182148
git checkout 073244e1adc3932156c9523a347b3edec3d87a9d
vim +/assert +119 fs/jfs/jfs_btree.h
^1da177e4c3f41 Linus Torvalds 2005-04-16 110
^1da177e4c3f41 Linus Torvalds 2005-04-16 111 #define BT_CLR(btstack)\
^1da177e4c3f41 Linus Torvalds 2005-04-16 112 (btstack)->top = (btstack)->stack
^1da177e4c3f41 Linus Torvalds 2005-04-16 113
^1da177e4c3f41 Linus Torvalds 2005-04-16 114 #define BT_STACK_FULL(btstack)\
^1da177e4c3f41 Linus Torvalds 2005-04-16 115 ( (btstack)->top == &((btstack)->stack[MAXTREEHEIGHT-1]))
^1da177e4c3f41 Linus Torvalds 2005-04-16 116
^1da177e4c3f41 Linus Torvalds 2005-04-16 117 #define BT_PUSH(BTSTACK, BN, INDEX)\
^1da177e4c3f41 Linus Torvalds 2005-04-16 118 {\
^1da177e4c3f41 Linus Torvalds 2005-04-16 @119 assert(!BT_STACK_FULL(BTSTACK));\
^1da177e4c3f41 Linus Torvalds 2005-04-16 120 (BTSTACK)->top->bn = BN;\
^1da177e4c3f41 Linus Torvalds 2005-04-16 121 (BTSTACK)->top->index = INDEX;\
^1da177e4c3f41 Linus Torvalds 2005-04-16 122 ++(BTSTACK)->top;\
^1da177e4c3f41 Linus Torvalds 2005-04-16 123 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 124
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 52700 bytes --]
next prev parent reply other threads:[~2020-08-27 22:25 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 10:14 [PATCH 00/23] clean up the code related to ASSERT() Chunguang Xu
2020-08-27 10:14 ` [PATCH 01/23] include/asm-generic/bug.h: add ASSERT_FAIL() and ASSERT_WARN() wrapper Chunguang Xu
2020-08-27 10:14 ` [PATCH 02/23] ia64: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code Chunguang Xu
2020-08-27 10:14 ` [PATCH 03/23] KVM: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 04/23] fore200e: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 05/23] scsi: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 06/23] rxrpc: " Chunguang Xu
2020-08-27 17:10 ` kernel test robot
2020-08-27 17:10 ` kernel test robot
2020-08-27 18:03 ` kernel test robot
2020-08-27 18:03 ` kernel test robot
2020-08-28 6:05 ` kernel test robot
2020-08-28 6:05 ` kernel test robot
2020-08-27 10:14 ` [PATCH 07/23] lib/mpi: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 08/23] jfs: " Chunguang Xu
2020-08-27 16:13 ` kernel test robot
2020-08-27 16:13 ` kernel test robot
2020-08-27 22:25 ` kernel test robot [this message]
2020-08-27 10:14 ` [PATCH 09/23] cachefiles: " Chunguang Xu
2020-08-28 4:30 ` kernel test robot
2020-08-28 4:30 ` kernel test robot
2020-08-27 10:14 ` [PATCH 10/23] btrfs: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 11/23] afs: " Chunguang Xu
2020-08-27 16:29 ` kernel test robot
2020-08-27 16:29 ` kernel test robot
2020-08-28 9:49 ` kernel test robot
2020-08-28 9:49 ` kernel test robot
2020-08-27 10:14 ` [PATCH 12/23] rivafb: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 13/23] nvidia: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 14/23] fbdev/cirrusfb:: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 15/23] media/staging: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 16/23] sym53c8xx: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 17/23] 8139too: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 18/23] net:hns: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 19/23] block/sx8: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 20/23] skb: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 21/23] ext4: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 22/23] rbd: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 23/23] ALSA: asihpi: " Chunguang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202008280657.jf45bVXT%lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.