From: kernel test robot <lkp@intel.com>
To: Chunguang Xu <brookxu.cn@gmail.com>, arnd@arndb.de
Cc: kbuild-all@lists.01.org, rppt@kernel.org,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/23] rxrpc: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code
Date: Fri, 28 Aug 2020 01:10:12 +0800 [thread overview]
Message-ID: <202008280114.UnoZLbYA%lkp@intel.com> (raw)
In-Reply-To: <5e7c145a8b5a57c78b9228806738ccb0cfc2ac98.1598518912.git.brookxu@tencent.com>
[-- Attachment #1: Type: text/plain, Size: 5629 bytes --]
Hi Chunguang,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on mkp-scsi/for-next]
[also build test ERROR on scsi/for-next block/for-next linus/master asm-generic/master v5.9-rc2 next-20200827]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Chunguang-Xu/clean-up-the-code-related-to-ASSERT/20200827-182148
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from include/linux/kernel.h:11,
from include/linux/list.h:9,
from include/linux/module.h:12,
from net/rxrpc/af_rxrpc.c:10:
net/rxrpc/af_rxrpc.c: In function 'rxrpc_listen':
>> net/rxrpc/ar-internal.h:1184:31: error: 'x' undeclared (first use in this function); did you mean 'rx'?
1184 | #define ASSERT(X) ASSERT_FAIL(x)
| ^
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
net/rxrpc/ar-internal.h:1184:19: note: in expansion of macro 'ASSERT_FAIL'
1184 | #define ASSERT(X) ASSERT_FAIL(x)
| ^~~~~~~~~~~
net/rxrpc/af_rxrpc.c:226:3: note: in expansion of macro 'ASSERT'
226 | ASSERT(rx->local != NULL);
| ^~~~~~
net/rxrpc/ar-internal.h:1184:31: note: each undeclared identifier is reported only once for each function it appears in
1184 | #define ASSERT(X) ASSERT_FAIL(x)
| ^
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
net/rxrpc/ar-internal.h:1184:19: note: in expansion of macro 'ASSERT_FAIL'
1184 | #define ASSERT(X) ASSERT_FAIL(x)
| ^~~~~~~~~~~
net/rxrpc/af_rxrpc.c:226:3: note: in expansion of macro 'ASSERT'
226 | ASSERT(rx->local != NULL);
| ^~~~~~
--
In file included from include/linux/kernel.h:11,
from include/linux/list.h:9,
from include/linux/module.h:12,
from net/rxrpc/call_accept.c:10:
net/rxrpc/call_accept.c: In function 'rxrpc_accept_call':
>> net/rxrpc/ar-internal.h:1184:31: error: 'x' undeclared (first use in this function); did you mean 'rx'?
1184 | #define ASSERT(X) ASSERT_FAIL(x)
| ^
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
net/rxrpc/ar-internal.h:1184:19: note: in expansion of macro 'ASSERT_FAIL'
1184 | #define ASSERT(X) ASSERT_FAIL(x)
| ^~~~~~~~~~~
net/rxrpc/call_accept.c:479:2: note: in expansion of macro 'ASSERT'
479 | ASSERT(!irqs_disabled());
| ^~~~~~
net/rxrpc/ar-internal.h:1184:31: note: each undeclared identifier is reported only once for each function it appears in
1184 | #define ASSERT(X) ASSERT_FAIL(x)
| ^
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
net/rxrpc/ar-internal.h:1184:19: note: in expansion of macro 'ASSERT_FAIL'
1184 | #define ASSERT(X) ASSERT_FAIL(x)
| ^~~~~~~~~~~
net/rxrpc/call_accept.c:479:2: note: in expansion of macro 'ASSERT'
479 | ASSERT(!irqs_disabled());
| ^~~~~~
net/rxrpc/call_accept.c: In function 'rxrpc_reject_call':
>> net/rxrpc/ar-internal.h:1184:31: error: 'x' undeclared (first use in this function); did you mean 'rx'?
1184 | #define ASSERT(X) ASSERT_FAIL(x)
| ^
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
net/rxrpc/ar-internal.h:1184:19: note: in expansion of macro 'ASSERT_FAIL'
1184 | #define ASSERT(X) ASSERT_FAIL(x)
| ^~~~~~~~~~~
net/rxrpc/call_accept.c:602:2: note: in expansion of macro 'ASSERT'
602 | ASSERT(!irqs_disabled());
| ^~~~~~
# https://github.com/0day-ci/linux/commit/1d215ffa42c9e100fa23c485351acf9293936807
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Chunguang-Xu/clean-up-the-code-related-to-ASSERT/20200827-182148
git checkout 1d215ffa42c9e100fa23c485351acf9293936807
vim +1184 net/rxrpc/ar-internal.h
1183
> 1184 #define ASSERT(X) ASSERT_FAIL(x)
1185
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 52700 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 06/23] rxrpc: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code
Date: Fri, 28 Aug 2020 01:10:12 +0800 [thread overview]
Message-ID: <202008280114.UnoZLbYA%lkp@intel.com> (raw)
In-Reply-To: <5e7c145a8b5a57c78b9228806738ccb0cfc2ac98.1598518912.git.brookxu@tencent.com>
[-- Attachment #1: Type: text/plain, Size: 5742 bytes --]
Hi Chunguang,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on mkp-scsi/for-next]
[also build test ERROR on scsi/for-next block/for-next linus/master asm-generic/master v5.9-rc2 next-20200827]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Chunguang-Xu/clean-up-the-code-related-to-ASSERT/20200827-182148
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from include/linux/kernel.h:11,
from include/linux/list.h:9,
from include/linux/module.h:12,
from net/rxrpc/af_rxrpc.c:10:
net/rxrpc/af_rxrpc.c: In function 'rxrpc_listen':
>> net/rxrpc/ar-internal.h:1184:31: error: 'x' undeclared (first use in this function); did you mean 'rx'?
1184 | #define ASSERT(X) ASSERT_FAIL(x)
| ^
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
net/rxrpc/ar-internal.h:1184:19: note: in expansion of macro 'ASSERT_FAIL'
1184 | #define ASSERT(X) ASSERT_FAIL(x)
| ^~~~~~~~~~~
net/rxrpc/af_rxrpc.c:226:3: note: in expansion of macro 'ASSERT'
226 | ASSERT(rx->local != NULL);
| ^~~~~~
net/rxrpc/ar-internal.h:1184:31: note: each undeclared identifier is reported only once for each function it appears in
1184 | #define ASSERT(X) ASSERT_FAIL(x)
| ^
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
net/rxrpc/ar-internal.h:1184:19: note: in expansion of macro 'ASSERT_FAIL'
1184 | #define ASSERT(X) ASSERT_FAIL(x)
| ^~~~~~~~~~~
net/rxrpc/af_rxrpc.c:226:3: note: in expansion of macro 'ASSERT'
226 | ASSERT(rx->local != NULL);
| ^~~~~~
--
In file included from include/linux/kernel.h:11,
from include/linux/list.h:9,
from include/linux/module.h:12,
from net/rxrpc/call_accept.c:10:
net/rxrpc/call_accept.c: In function 'rxrpc_accept_call':
>> net/rxrpc/ar-internal.h:1184:31: error: 'x' undeclared (first use in this function); did you mean 'rx'?
1184 | #define ASSERT(X) ASSERT_FAIL(x)
| ^
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
net/rxrpc/ar-internal.h:1184:19: note: in expansion of macro 'ASSERT_FAIL'
1184 | #define ASSERT(X) ASSERT_FAIL(x)
| ^~~~~~~~~~~
net/rxrpc/call_accept.c:479:2: note: in expansion of macro 'ASSERT'
479 | ASSERT(!irqs_disabled());
| ^~~~~~
net/rxrpc/ar-internal.h:1184:31: note: each undeclared identifier is reported only once for each function it appears in
1184 | #define ASSERT(X) ASSERT_FAIL(x)
| ^
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
net/rxrpc/ar-internal.h:1184:19: note: in expansion of macro 'ASSERT_FAIL'
1184 | #define ASSERT(X) ASSERT_FAIL(x)
| ^~~~~~~~~~~
net/rxrpc/call_accept.c:479:2: note: in expansion of macro 'ASSERT'
479 | ASSERT(!irqs_disabled());
| ^~~~~~
net/rxrpc/call_accept.c: In function 'rxrpc_reject_call':
>> net/rxrpc/ar-internal.h:1184:31: error: 'x' undeclared (first use in this function); did you mean 'rx'?
1184 | #define ASSERT(X) ASSERT_FAIL(x)
| ^
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
net/rxrpc/ar-internal.h:1184:19: note: in expansion of macro 'ASSERT_FAIL'
1184 | #define ASSERT(X) ASSERT_FAIL(x)
| ^~~~~~~~~~~
net/rxrpc/call_accept.c:602:2: note: in expansion of macro 'ASSERT'
602 | ASSERT(!irqs_disabled());
| ^~~~~~
# https://github.com/0day-ci/linux/commit/1d215ffa42c9e100fa23c485351acf9293936807
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Chunguang-Xu/clean-up-the-code-related-to-ASSERT/20200827-182148
git checkout 1d215ffa42c9e100fa23c485351acf9293936807
vim +1184 net/rxrpc/ar-internal.h
1183
> 1184 #define ASSERT(X) ASSERT_FAIL(x)
1185
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 52700 bytes --]
next prev parent reply other threads:[~2020-08-27 17:11 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 10:14 [PATCH 00/23] clean up the code related to ASSERT() Chunguang Xu
2020-08-27 10:14 ` [PATCH 01/23] include/asm-generic/bug.h: add ASSERT_FAIL() and ASSERT_WARN() wrapper Chunguang Xu
2020-08-27 10:14 ` [PATCH 02/23] ia64: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code Chunguang Xu
2020-08-27 10:14 ` [PATCH 03/23] KVM: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 04/23] fore200e: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 05/23] scsi: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 06/23] rxrpc: " Chunguang Xu
2020-08-27 17:10 ` kernel test robot [this message]
2020-08-27 17:10 ` kernel test robot
2020-08-27 18:03 ` kernel test robot
2020-08-27 18:03 ` kernel test robot
2020-08-28 6:05 ` kernel test robot
2020-08-28 6:05 ` kernel test robot
2020-08-27 10:14 ` [PATCH 07/23] lib/mpi: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 08/23] jfs: " Chunguang Xu
2020-08-27 16:13 ` kernel test robot
2020-08-27 16:13 ` kernel test robot
2020-08-27 22:25 ` kernel test robot
2020-08-27 10:14 ` [PATCH 09/23] cachefiles: " Chunguang Xu
2020-08-28 4:30 ` kernel test robot
2020-08-28 4:30 ` kernel test robot
2020-08-27 10:14 ` [PATCH 10/23] btrfs: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 11/23] afs: " Chunguang Xu
2020-08-27 16:29 ` kernel test robot
2020-08-27 16:29 ` kernel test robot
2020-08-28 9:49 ` kernel test robot
2020-08-28 9:49 ` kernel test robot
2020-08-27 10:14 ` [PATCH 12/23] rivafb: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 13/23] nvidia: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 14/23] fbdev/cirrusfb:: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 15/23] media/staging: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 16/23] sym53c8xx: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 17/23] 8139too: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 18/23] net:hns: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 19/23] block/sx8: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 20/23] skb: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 21/23] ext4: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 22/23] rbd: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 23/23] ALSA: asihpi: " Chunguang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202008280114.UnoZLbYA%lkp@intel.com \
--to=lkp@intel.com \
--cc=arnd@arndb.de \
--cc=brookxu.cn@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.