From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Landen Chao <landen.chao@mediatek.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
frank-w@public-files.de, netdev@vger.kernel.org,
Sean Wang <sean.wang@mediatek.com>,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
"David S . Miller" <davem@davemloft.net>,
dqfext@gmail.com, opensource@vdorst.com,
Matthias Brugger <matthias.bgg@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
Vivien Didelot <vivien.didelot@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net v2] net: dsa: mt7530: fix advertising unsupported 1000baseT_Half
Date: Fri, 28 Aug 2020 11:54:46 +0100 [thread overview]
Message-ID: <20200828105446.GK1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <20200828105244.9839-1-landen.chao@mediatek.com>
On Fri, Aug 28, 2020 at 06:52:44PM +0800, Landen Chao wrote:
> Remove 1000baseT_Half to advertise correct hardware capability in
> phylink_validate() callback function.
>
> Fixes: 38f790a80560 ("net: dsa: mt7530: Add support for port 5")
> Signed-off-by: Landen Chao <landen.chao@mediatek.com>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Russell King <rmk+kernel@armlinux.org.uk>
Thanks.
> ---
> v1->v2
> - fix the commit subject spilled into the commit message
> ---
> drivers/net/dsa/mt7530.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c
> index 8dcb8a49ab67..238417db26f9 100644
> --- a/drivers/net/dsa/mt7530.c
> +++ b/drivers/net/dsa/mt7530.c
> @@ -1501,7 +1501,7 @@ static void mt7530_phylink_validate(struct dsa_switch *ds, int port,
> phylink_set(mask, 100baseT_Full);
>
> if (state->interface != PHY_INTERFACE_MODE_MII) {
> - phylink_set(mask, 1000baseT_Half);
> + /* This switch only supports 1G full-duplex. */
> phylink_set(mask, 1000baseT_Full);
> if (port == 5)
> phylink_set(mask, 1000baseX_Full);
> --
> 2.17.1
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Landen Chao <landen.chao@mediatek.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
frank-w@public-files.de, netdev@vger.kernel.org,
Sean Wang <sean.wang@mediatek.com>,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
"David S . Miller" <davem@davemloft.net>,
dqfext@gmail.com, opensource@vdorst.com,
Matthias Brugger <matthias.bgg@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
Vivien Didelot <vivien.didelot@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net v2] net: dsa: mt7530: fix advertising unsupported 1000baseT_Half
Date: Fri, 28 Aug 2020 11:54:46 +0100 [thread overview]
Message-ID: <20200828105446.GK1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <20200828105244.9839-1-landen.chao@mediatek.com>
On Fri, Aug 28, 2020 at 06:52:44PM +0800, Landen Chao wrote:
> Remove 1000baseT_Half to advertise correct hardware capability in
> phylink_validate() callback function.
>
> Fixes: 38f790a80560 ("net: dsa: mt7530: Add support for port 5")
> Signed-off-by: Landen Chao <landen.chao@mediatek.com>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Russell King <rmk+kernel@armlinux.org.uk>
Thanks.
> ---
> v1->v2
> - fix the commit subject spilled into the commit message
> ---
> drivers/net/dsa/mt7530.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c
> index 8dcb8a49ab67..238417db26f9 100644
> --- a/drivers/net/dsa/mt7530.c
> +++ b/drivers/net/dsa/mt7530.c
> @@ -1501,7 +1501,7 @@ static void mt7530_phylink_validate(struct dsa_switch *ds, int port,
> phylink_set(mask, 100baseT_Full);
>
> if (state->interface != PHY_INTERFACE_MODE_MII) {
> - phylink_set(mask, 1000baseT_Half);
> + /* This switch only supports 1G full-duplex. */
> phylink_set(mask, 1000baseT_Full);
> if (port == 5)
> phylink_set(mask, 1000baseX_Full);
> --
> 2.17.1
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Landen Chao <landen.chao@mediatek.com>
Cc: Sean Wang <sean.wang@mediatek.com>, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
dqfext@gmail.com, frank-w@public-files.de,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
opensource@vdorst.com, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net v2] net: dsa: mt7530: fix advertising unsupported 1000baseT_Half
Date: Fri, 28 Aug 2020 11:54:46 +0100 [thread overview]
Message-ID: <20200828105446.GK1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <20200828105244.9839-1-landen.chao@mediatek.com>
On Fri, Aug 28, 2020 at 06:52:44PM +0800, Landen Chao wrote:
> Remove 1000baseT_Half to advertise correct hardware capability in
> phylink_validate() callback function.
>
> Fixes: 38f790a80560 ("net: dsa: mt7530: Add support for port 5")
> Signed-off-by: Landen Chao <landen.chao@mediatek.com>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Russell King <rmk+kernel@armlinux.org.uk>
Thanks.
> ---
> v1->v2
> - fix the commit subject spilled into the commit message
> ---
> drivers/net/dsa/mt7530.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c
> index 8dcb8a49ab67..238417db26f9 100644
> --- a/drivers/net/dsa/mt7530.c
> +++ b/drivers/net/dsa/mt7530.c
> @@ -1501,7 +1501,7 @@ static void mt7530_phylink_validate(struct dsa_switch *ds, int port,
> phylink_set(mask, 100baseT_Full);
>
> if (state->interface != PHY_INTERFACE_MODE_MII) {
> - phylink_set(mask, 1000baseT_Half);
> + /* This switch only supports 1G full-duplex. */
> phylink_set(mask, 1000baseT_Full);
> if (port == 5)
> phylink_set(mask, 1000baseX_Full);
> --
> 2.17.1
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2020-08-28 10:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 10:52 [PATCH net v2] net: dsa: mt7530: fix advertising unsupported 1000baseT_Half Landen Chao
2020-08-28 10:52 ` Landen Chao
2020-08-28 10:52 ` Landen Chao
2020-08-28 10:54 ` Russell King - ARM Linux admin [this message]
2020-08-28 10:54 ` Russell King - ARM Linux admin
2020-08-28 10:54 ` Russell King - ARM Linux admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200828105446.GK1551@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=frank-w@public-files.de \
--cc=kuba@kernel.org \
--cc=landen.chao@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=opensource@vdorst.com \
--cc=sean.wang@mediatek.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.