From: Helge Deller <deller@gmx.de>
To: linux-parisc@vger.kernel.org,
James Bottomley <James.Bottomley@hansenpartnership.com>,
John David Anglin <dave.anglin@bell.net>
Subject: [RFC PATCH] parisc: Define O_NONBLOCK to become 000200000
Date: Sat, 29 Aug 2020 14:20:17 +0200 [thread overview]
Message-ID: <20200829122017.GA3988@ls3530.fritz.box> (raw)
HPUX has separate NDELAY & NONBLOCK values. In the past we wanted to
be able to run HP-UX binaries natively on parisc Linux which is why
we defined O_NONBLOCK to 000200004 to distinguish NDELAY & NONBLOCK
bits.
But with 2 bits set in this bitmask we often ran into compatibility
issues with other Linux applications which often only test one bit (or
even compare the values).
To avoid such issues in the future, this patch changes O_NONBLOCK to
become 000200000. That way old programs will still be functional, and
for new programs we now have only one bit set.
Update the comment about SOCK_NONBLOCK too.
Signed-off-by: Helge Deller <deller@gmx.de>
diff --git a/arch/parisc/include/asm/socket.h b/arch/parisc/include/asm/socket.h
index 79feff1b0721..33500c9f6e5e 100644
--- a/arch/parisc/include/asm/socket.h
+++ b/arch/parisc/include/asm/socket.h
@@ -4,8 +4,8 @@
#include <uapi/asm/socket.h>
-/* O_NONBLOCK clashes with the bits used for socket types. Therefore we
- * have to define SOCK_NONBLOCK to a different value here.
+/* O_NONBLOCK clashed with the bits used for socket types. Therefore we
+ * had to define SOCK_NONBLOCK to a different value here.
*/
#define SOCK_NONBLOCK 0x40000000
diff --git a/arch/parisc/include/uapi/asm/fcntl.h b/arch/parisc/include/uapi/asm/fcntl.h
index e19adc65b1d0..03dee816cb13 100644
--- a/arch/parisc/include/uapi/asm/fcntl.h
+++ b/arch/parisc/include/uapi/asm/fcntl.h
@@ -8,7 +8,7 @@
#define O_LARGEFILE 000004000
#define __O_SYNC 000100000
#define O_SYNC (__O_SYNC|O_DSYNC)
-#define O_NONBLOCK 000200004 /* HPUX has separate NDELAY & NONBLOCK */
+#define O_NONBLOCK 000200000
#define O_NOCTTY 000400000 /* not fcntl */
#define O_DSYNC 001000000
#define O_NOATIME 004000000
next reply other threads:[~2020-08-29 12:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-29 12:20 Helge Deller [this message]
2020-10-20 17:21 ` [RFC PATCH] parisc: Define O_NONBLOCK to become 000200000 Jeroen Roovers
2020-10-21 6:07 ` Helge Deller
2020-10-22 15:38 ` Jeroen Roovers
2020-10-22 16:14 ` Helge Deller
2020-10-22 16:40 ` [RFC PATCH] parisc: Add wrapper syscalls to fix O_NONBLOCK flag usage Helge Deller
2020-10-22 19:11 ` Meelis Roos
2020-10-22 20:29 ` Helge Deller
2020-10-23 7:02 ` Jeroen Roovers
2020-10-23 8:35 ` Helge Deller
2020-10-23 8:53 ` Jeroen Roovers
2020-10-23 18:15 ` Helge Deller
2020-10-22 20:00 ` Jeroen Roovers
2020-10-23 7:25 ` Rolf Eike Beer
2020-10-23 8:18 ` Helge Deller
2020-10-23 8:31 ` Helge Deller
2020-10-23 8:58 ` Rolf Eike Beer
2020-10-23 18:18 ` [RFC PATCH v3] " Helge Deller
2020-10-24 8:22 ` Jeroen Roovers
2020-10-24 8:24 ` Jeroen Roovers
2020-10-24 8:34 ` Helge Deller
2020-10-24 14:11 ` John David Anglin
2020-10-24 9:59 ` Jeroen Roovers
2020-10-25 11:48 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200829122017.GA3988@ls3530.fritz.box \
--to=deller@gmx.de \
--cc=James.Bottomley@hansenpartnership.com \
--cc=dave.anglin@bell.net \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.