From: Jeroen Roovers <jer@xs4all.nl>
To: Helge Deller <deller@gmx.de>
Cc: linux-parisc@vger.kernel.org, Meelis Roos <mroos@linux.ee>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
John David Anglin <dave.anglin@bell.net>
Subject: Re: [RFC PATCH] parisc: Add wrapper syscalls to fix O_NONBLOCK flag usage
Date: Thu, 22 Oct 2020 22:00:46 +0200 [thread overview]
Message-ID: <20201022220046.2db7dfc5@wim.jer> (raw)
In-Reply-To: <20201022164007.GA10653@ls3530.fritz.box>
On Thu, 22 Oct 2020 18:40:07 +0200
Helge Deller <deller@gmx.de> wrote:
> The commit 75ae04206a4d ("parisc: Define O_NONBLOCK to become
> 000200000") changed the O_NONBLOCK constant to have only one bit set
> (like all other architectures). This change broke some existing
> userspace code (e.g. udevadm, systemd-udevd, elogind) which called
> specific syscalls which do strict value checking on their flag
> parameter.
>
> This patch adds wrapper functions for the relevant syscalls. The
> wrappers masks out any old invalid O_NONBLOCK flags, reports in the
> syslog if the old O_NONBLOCK value was used and then calls the target
> syscall with the new O_NONBLOCK value.
>
> Fixes: 75ae04206a4d ("parisc: Define O_NONBLOCK to become 000200000")
> Signed-off-by: Helge Deller <deller@gmx.de>
That fixes all the previous problems.
Regards,
jer
next prev parent reply other threads:[~2020-10-22 20:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-29 12:20 [RFC PATCH] parisc: Define O_NONBLOCK to become 000200000 Helge Deller
2020-10-20 17:21 ` Jeroen Roovers
2020-10-21 6:07 ` Helge Deller
2020-10-22 15:38 ` Jeroen Roovers
2020-10-22 16:14 ` Helge Deller
2020-10-22 16:40 ` [RFC PATCH] parisc: Add wrapper syscalls to fix O_NONBLOCK flag usage Helge Deller
2020-10-22 19:11 ` Meelis Roos
2020-10-22 20:29 ` Helge Deller
2020-10-23 7:02 ` Jeroen Roovers
2020-10-23 8:35 ` Helge Deller
2020-10-23 8:53 ` Jeroen Roovers
2020-10-23 18:15 ` Helge Deller
2020-10-22 20:00 ` Jeroen Roovers [this message]
2020-10-23 7:25 ` Rolf Eike Beer
2020-10-23 8:18 ` Helge Deller
2020-10-23 8:31 ` Helge Deller
2020-10-23 8:58 ` Rolf Eike Beer
2020-10-23 18:18 ` [RFC PATCH v3] " Helge Deller
2020-10-24 8:22 ` Jeroen Roovers
2020-10-24 8:24 ` Jeroen Roovers
2020-10-24 8:34 ` Helge Deller
2020-10-24 14:11 ` John David Anglin
2020-10-24 9:59 ` Jeroen Roovers
2020-10-25 11:48 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201022220046.2db7dfc5@wim.jer \
--to=jer@xs4all.nl \
--cc=James.Bottomley@hansenpartnership.com \
--cc=dave.anglin@bell.net \
--cc=deller@gmx.de \
--cc=linux-parisc@vger.kernel.org \
--cc=mroos@linux.ee \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.