From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: Martin Cerveny <m.cerveny@computer.org>
Cc: Chen-Yu Tsai <wens@csie.org>,
"David S. Miller" <davem@davemloft.net>,
devicetree@vger.kernel.org,
Herbert Xu <herbert@gondor.apana.org.au>,
linux-arm-kernel@lists.infradead.org,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
Maxime Ripard <mripard@kernel.org>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v2 3/3] crypto: sun4i-ss - add the V3s variant of SS
Date: Mon, 31 Aug 2020 13:50:24 +0200 [thread overview]
Message-ID: <20200831115024.GA14248@Red> (raw)
In-Reply-To: <20200831073101.3608-4-m.cerveny@computer.org>
On Mon, Aug 31, 2020 at 09:31:01AM +0200, Martin Cerveny wrote:
> Like A33 "sun4i-ss" has a difference, it give SHA1 digest
> directly in BE. So add new compatible.
>
> Tested-by: Martin Cerveny <m.cerveny@computer.org>
> Signed-off-by: Martin Cerveny <m.cerveny@computer.org>
> ---
> drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
Your commit message is wrong, "sun4i-ss" has no difference, but V3S yes.
Your other patch has the same problem.
Otherwise you could add:
Acked-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Regards
WARNING: multiple messages have this Message-ID (diff)
From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: Martin Cerveny <m.cerveny@computer.org>
Cc: devicetree@vger.kernel.org,
Herbert Xu <herbert@gondor.apana.org.au>,
linux-kernel@vger.kernel.org, Maxime Ripard <mripard@kernel.org>,
Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
linux-crypto@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/3] crypto: sun4i-ss - add the V3s variant of SS
Date: Mon, 31 Aug 2020 13:50:24 +0200 [thread overview]
Message-ID: <20200831115024.GA14248@Red> (raw)
In-Reply-To: <20200831073101.3608-4-m.cerveny@computer.org>
On Mon, Aug 31, 2020 at 09:31:01AM +0200, Martin Cerveny wrote:
> Like A33 "sun4i-ss" has a difference, it give SHA1 digest
> directly in BE. So add new compatible.
>
> Tested-by: Martin Cerveny <m.cerveny@computer.org>
> Signed-off-by: Martin Cerveny <m.cerveny@computer.org>
> ---
> drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
Your commit message is wrong, "sun4i-ss" has no difference, but V3S yes.
Your other patch has the same problem.
Otherwise you could add:
Acked-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Regards
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-31 11:50 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 7:30 [PATCH v2 0/3] crypto: sun4i-ss: add support for V3s Martin Cerveny
2020-08-31 7:30 ` Martin Cerveny
2020-08-31 7:30 ` [PATCH v2 1/3] dt-bindings: crypto: add new compatible " Martin Cerveny
2020-08-31 7:30 ` Martin Cerveny
2020-09-01 9:32 ` Maxime Ripard
2020-09-01 9:32 ` Maxime Ripard
2020-09-01 10:57 ` Corentin Labbe
2020-09-01 10:57 ` Corentin Labbe
2020-09-01 11:40 ` Maxime Ripard
2020-09-01 11:40 ` Maxime Ripard
2020-09-02 6:28 ` Corentin Labbe
2020-09-02 6:28 ` Corentin Labbe
2020-09-05 15:51 ` Martin Cerveny
2020-09-05 15:51 ` Martin Cerveny
2020-09-14 18:24 ` Rob Herring
2020-09-14 18:24 ` Rob Herring
2020-08-31 7:31 ` [PATCH v2 2/3] ARM: dts: sun8i: v3s: Enable crypto engine Martin Cerveny
2020-08-31 7:31 ` Martin Cerveny
2020-09-01 9:33 ` Maxime Ripard
2020-09-01 9:33 ` Maxime Ripard
2020-08-31 7:31 ` [PATCH v2 3/3] crypto: sun4i-ss - add the V3s variant of SS Martin Cerveny
2020-08-31 7:31 ` Martin Cerveny
2020-08-31 11:50 ` Corentin Labbe [this message]
2020-08-31 11:50 ` Corentin Labbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200831115024.GA14248@Red \
--to=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.cerveny@computer.org \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.