All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org, Zong Li <zong.li@sifive.com>,
	palmer@dabbelt.com, paul.walmsley@sifive.com,
	david.abdurachmanov@sifive.com, linux-riscv@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: Palmer Dabbelt <palmerdabbelt@google.com>,
	kbuild-all@lists.01.org, lkp@intel.com,
	Zong Li <zong.li@sifive.com>
Subject: Re: [PATCH v2 3/3] riscv: Add cache information in AUX vector
Date: Mon, 31 Aug 2020 14:59:38 +0300	[thread overview]
Message-ID: <20200831115938.GG8299@kadam> (raw)
In-Reply-To: <f9199795d6e9bae73f49583c494505e0a4983c61.1598515355.git.zong.li@sifive.com>

[-- Attachment #1: Type: text/plain, Size: 1837 bytes --]

Hi Zong,

url:    https://github.com/0day-ci/linux/commits/Zong-Li/Get-cache-information-from-userland/20200827-162439
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 15bc20c6af4ceee97a1f90b43c0e386643c071b4
config: riscv-randconfig-m031-20200828 (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
arch/riscv/kernel/cacheinfo.c:55 get_cache_geometry() warn: variable dereferenced before check 'this_leaf' (see line 52)

# https://github.com/0day-ci/linux/commit/a51c248ba0626069792c3f84c8879f685f4a1ff6
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Zong-Li/Get-cache-information-from-userland/20200827-162439
git checkout a51c248ba0626069792c3f84c8879f685f4a1ff6
vim +/this_leaf +55 arch/riscv/kernel/cacheinfo.c

a51c248ba06260 Zong Li 2020-08-27  49  uintptr_t get_cache_geometry(u32 level, enum cache_type type)
a51c248ba06260 Zong Li 2020-08-27  50  {
a51c248ba06260 Zong Li 2020-08-27  51  	struct cacheinfo *this_leaf = get_cacheinfo(level, type);
a51c248ba06260 Zong Li 2020-08-27 @52  	uintptr_t ret = (this_leaf->ways_of_associativity << 16 |
a51c248ba06260 Zong Li 2020-08-27  53  			 this_leaf->coherency_line_size);
                                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Dereferenced

a51c248ba06260 Zong Li 2020-08-27  54  
a51c248ba06260 Zong Li 2020-08-27 @55  	return this_leaf ? ret : 0;
                                               ^^^^^^^^^
Checked too late.

a51c248ba06260 Zong Li 2020-08-27  56  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 26481 bytes --]

[-- Attachment #3: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org
Subject: Re: [PATCH v2 3/3] riscv: Add cache information in AUX vector
Date: Mon, 31 Aug 2020 14:59:38 +0300	[thread overview]
Message-ID: <20200831115938.GG8299@kadam> (raw)
In-Reply-To: <f9199795d6e9bae73f49583c494505e0a4983c61.1598515355.git.zong.li@sifive.com>

[-- Attachment #1: Type: text/plain, Size: 1877 bytes --]

Hi Zong,

url:    https://github.com/0day-ci/linux/commits/Zong-Li/Get-cache-information-from-userland/20200827-162439
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 15bc20c6af4ceee97a1f90b43c0e386643c071b4
config: riscv-randconfig-m031-20200828 (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
arch/riscv/kernel/cacheinfo.c:55 get_cache_geometry() warn: variable dereferenced before check 'this_leaf' (see line 52)

# https://github.com/0day-ci/linux/commit/a51c248ba0626069792c3f84c8879f685f4a1ff6
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Zong-Li/Get-cache-information-from-userland/20200827-162439
git checkout a51c248ba0626069792c3f84c8879f685f4a1ff6
vim +/this_leaf +55 arch/riscv/kernel/cacheinfo.c

a51c248ba06260 Zong Li 2020-08-27  49  uintptr_t get_cache_geometry(u32 level, enum cache_type type)
a51c248ba06260 Zong Li 2020-08-27  50  {
a51c248ba06260 Zong Li 2020-08-27  51  	struct cacheinfo *this_leaf = get_cacheinfo(level, type);
a51c248ba06260 Zong Li 2020-08-27 @52  	uintptr_t ret = (this_leaf->ways_of_associativity << 16 |
a51c248ba06260 Zong Li 2020-08-27  53  			 this_leaf->coherency_line_size);
                                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Dereferenced

a51c248ba06260 Zong Li 2020-08-27  54  
a51c248ba06260 Zong Li 2020-08-27 @55  	return this_leaf ? ret : 0;
                                               ^^^^^^^^^
Checked too late.

a51c248ba06260 Zong Li 2020-08-27  56  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 26481 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v2 3/3] riscv: Add cache information in AUX vector
Date: Mon, 31 Aug 2020 14:59:38 +0300	[thread overview]
Message-ID: <20200831115938.GG8299@kadam> (raw)
In-Reply-To: <f9199795d6e9bae73f49583c494505e0a4983c61.1598515355.git.zong.li@sifive.com>

[-- Attachment #1: Type: text/plain, Size: 1877 bytes --]

Hi Zong,

url:    https://github.com/0day-ci/linux/commits/Zong-Li/Get-cache-information-from-userland/20200827-162439
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 15bc20c6af4ceee97a1f90b43c0e386643c071b4
config: riscv-randconfig-m031-20200828 (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
arch/riscv/kernel/cacheinfo.c:55 get_cache_geometry() warn: variable dereferenced before check 'this_leaf' (see line 52)

# https://github.com/0day-ci/linux/commit/a51c248ba0626069792c3f84c8879f685f4a1ff6
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Zong-Li/Get-cache-information-from-userland/20200827-162439
git checkout a51c248ba0626069792c3f84c8879f685f4a1ff6
vim +/this_leaf +55 arch/riscv/kernel/cacheinfo.c

a51c248ba06260 Zong Li 2020-08-27  49  uintptr_t get_cache_geometry(u32 level, enum cache_type type)
a51c248ba06260 Zong Li 2020-08-27  50  {
a51c248ba06260 Zong Li 2020-08-27  51  	struct cacheinfo *this_leaf = get_cacheinfo(level, type);
a51c248ba06260 Zong Li 2020-08-27 @52  	uintptr_t ret = (this_leaf->ways_of_associativity << 16 |
a51c248ba06260 Zong Li 2020-08-27  53  			 this_leaf->coherency_line_size);
                                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Dereferenced

a51c248ba06260 Zong Li 2020-08-27  54  
a51c248ba06260 Zong Li 2020-08-27 @55  	return this_leaf ? ret : 0;
                                               ^^^^^^^^^
Checked too late.

a51c248ba06260 Zong Li 2020-08-27  56  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 26481 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org, Zong Li <zong.li@sifive.com>,
	palmer@dabbelt.com, paul.walmsley@sifive.com,
	david.abdurachmanov@sifive.com, linux-riscv@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: lkp@intel.com, kbuild-all@lists.01.org,
	Zong Li <zong.li@sifive.com>,
	Palmer Dabbelt <palmerdabbelt@google.com>
Subject: Re: [PATCH v2 3/3] riscv: Add cache information in AUX vector
Date: Mon, 31 Aug 2020 14:59:38 +0300	[thread overview]
Message-ID: <20200831115938.GG8299@kadam> (raw)
In-Reply-To: <f9199795d6e9bae73f49583c494505e0a4983c61.1598515355.git.zong.li@sifive.com>

[-- Attachment #1: Type: text/plain, Size: 1837 bytes --]

Hi Zong,

url:    https://github.com/0day-ci/linux/commits/Zong-Li/Get-cache-information-from-userland/20200827-162439
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 15bc20c6af4ceee97a1f90b43c0e386643c071b4
config: riscv-randconfig-m031-20200828 (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
arch/riscv/kernel/cacheinfo.c:55 get_cache_geometry() warn: variable dereferenced before check 'this_leaf' (see line 52)

# https://github.com/0day-ci/linux/commit/a51c248ba0626069792c3f84c8879f685f4a1ff6
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Zong-Li/Get-cache-information-from-userland/20200827-162439
git checkout a51c248ba0626069792c3f84c8879f685f4a1ff6
vim +/this_leaf +55 arch/riscv/kernel/cacheinfo.c

a51c248ba06260 Zong Li 2020-08-27  49  uintptr_t get_cache_geometry(u32 level, enum cache_type type)
a51c248ba06260 Zong Li 2020-08-27  50  {
a51c248ba06260 Zong Li 2020-08-27  51  	struct cacheinfo *this_leaf = get_cacheinfo(level, type);
a51c248ba06260 Zong Li 2020-08-27 @52  	uintptr_t ret = (this_leaf->ways_of_associativity << 16 |
a51c248ba06260 Zong Li 2020-08-27  53  			 this_leaf->coherency_line_size);
                                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Dereferenced

a51c248ba06260 Zong Li 2020-08-27  54  
a51c248ba06260 Zong Li 2020-08-27 @55  	return this_leaf ? ret : 0;
                                               ^^^^^^^^^
Checked too late.

a51c248ba06260 Zong Li 2020-08-27  56  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 26481 bytes --]

  parent reply	other threads:[~2020-08-31 13:16 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-27  8:22 [PATCH v2 0/3] Get cache information from userland Zong Li
2020-08-27  8:22 ` Zong Li
2020-08-27  8:22 ` [PATCH v2 1/3] riscv: Set more data to cacheinfo Zong Li
2020-08-27  8:22   ` Zong Li
2020-08-27  8:22 ` [PATCH v2 2/3] riscv: Define AT_VECTOR_SIZE_ARCH for ARCH_DLINFO Zong Li
2020-08-27  8:22   ` Zong Li
2020-08-27  8:22 ` [PATCH v2 3/3] riscv: Add cache information in AUX vector Zong Li
2020-08-27  8:22   ` Zong Li
2020-08-28  4:45   ` kernel test robot
2020-08-28  4:45     ` kernel test robot
2020-08-28  4:45     ` kernel test robot
2020-08-31 11:59   ` Dan Carpenter [this message]
2020-08-31 11:59     ` Dan Carpenter
2020-08-31 11:59     ` Dan Carpenter
2020-08-31 11:59     ` Dan Carpenter
2020-09-04 19:17 ` [PATCH v2 0/3] Get cache information from userland Palmer Dabbelt
2020-09-04 19:17   ` Palmer Dabbelt
  -- strict thread matches above, loose matches on Subject: below --
2020-08-27 23:27 [PATCH v2 3/3] riscv: Add cache information in AUX vector kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200831115938.GG8299@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=david.abdurachmanov@sifive.com \
    --cc=kbuild-all@lists.01.org \
    --cc=kbuild@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=lkp@intel.com \
    --cc=palmer@dabbelt.com \
    --cc=palmerdabbelt@google.com \
    --cc=paul.walmsley@sifive.com \
    --cc=zong.li@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.