All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org
Subject: [hverkuil-media:tegrav4 22/25] drivers/media/i2c/imx274.c:1864 imx274_probe() error: uninitialized symbol 'ret'.
Date: Mon, 31 Aug 2020 15:03:41 +0300	[thread overview]
Message-ID: <20200831120341.GI8299@kadam> (raw)

[-- Attachment #1: Type: text/plain, Size: 2832 bytes --]

tree:   git://linuxtv.org/hverkuil/media_tree.git tegrav4
head:   ce1e7ce798ee872c0cd58f0a98a1f4db0606f8a2
commit: 8e6137f211b496f99153e409c92f7a5ce3c9dbf3 [22/25] media: i2c: Add support for IMX274 supplies and external clock
config: i386-randconfig-m021-20200825 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/media/i2c/imx274.c:1864 imx274_probe() error: uninitialized symbol 'ret'.

git remote add hverkuil-media git://linuxtv.org/hverkuil/media_tree.git
git fetch --no-tags hverkuil-media tegrav4
git checkout 8e6137f211b496f99153e409c92f7a5ce3c9dbf3
vim +/ret +1864 drivers/media/i2c/imx274.c

e671499303e4c0 Kieran Bingham      2019-07-10  1848  static int imx274_probe(struct i2c_client *client)
0985dd306f727d Leon Luo            2017-10-05  1849  {
0985dd306f727d Leon Luo            2017-10-05  1850  	struct v4l2_subdev *sd;
0985dd306f727d Leon Luo            2017-10-05  1851  	struct stimx274 *imx274;
0985dd306f727d Leon Luo            2017-10-05  1852  	int ret;
0985dd306f727d Leon Luo            2017-10-05  1853  
0985dd306f727d Leon Luo            2017-10-05  1854  	/* initialize imx274 */
0985dd306f727d Leon Luo            2017-10-05  1855  	imx274 = devm_kzalloc(&client->dev, sizeof(*imx274), GFP_KERNEL);
0985dd306f727d Leon Luo            2017-10-05  1856  	if (!imx274)
0985dd306f727d Leon Luo            2017-10-05  1857  		return -ENOMEM;
0985dd306f727d Leon Luo            2017-10-05  1858  
0985dd306f727d Leon Luo            2017-10-05  1859  	mutex_init(&imx274->lock);
0985dd306f727d Leon Luo            2017-10-05  1860  
8e6137f211b496 Sowjanya Komatineni 2020-06-03  1861  	imx274->xclk = devm_clk_get(&client->dev, "xclk");
8e6137f211b496 Sowjanya Komatineni 2020-06-03  1862  	if (IS_ERR(imx274->xclk)) {
8e6137f211b496 Sowjanya Komatineni 2020-06-03  1863  		dev_err(&client->dev, "Failed to get xclk\n");
8e6137f211b496 Sowjanya Komatineni 2020-06-03 @1864  		return ret;

"ret" is uninitialized.

8e6137f211b496 Sowjanya Komatineni 2020-06-03  1865  	}
8e6137f211b496 Sowjanya Komatineni 2020-06-03  1866  
8e6137f211b496 Sowjanya Komatineni 2020-06-03  1867  	ret = clk_set_rate(imx274->xclk, IMX274_DEFAULT_CLK_FREQ);
8e6137f211b496 Sowjanya Komatineni 2020-06-03  1868  	if (ret < 0) {
8e6137f211b496 Sowjanya Komatineni 2020-06-03  1869  		dev_err(&client->dev, "Failed to set xclk rate\n");
8e6137f211b496 Sowjanya Komatineni 2020-06-03  1870  		return ret;
8e6137f211b496 Sowjanya Komatineni 2020-06-03  1871  	}

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 38824 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild-all@lists.01.org
Subject: [hverkuil-media:tegrav4 22/25] drivers/media/i2c/imx274.c:1864 imx274_probe() error: uninitialized symbol 'ret'.
Date: Mon, 31 Aug 2020 15:03:41 +0300	[thread overview]
Message-ID: <20200831120341.GI8299@kadam> (raw)

[-- Attachment #1: Type: text/plain, Size: 2832 bytes --]

tree:   git://linuxtv.org/hverkuil/media_tree.git tegrav4
head:   ce1e7ce798ee872c0cd58f0a98a1f4db0606f8a2
commit: 8e6137f211b496f99153e409c92f7a5ce3c9dbf3 [22/25] media: i2c: Add support for IMX274 supplies and external clock
config: i386-randconfig-m021-20200825 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/media/i2c/imx274.c:1864 imx274_probe() error: uninitialized symbol 'ret'.

git remote add hverkuil-media git://linuxtv.org/hverkuil/media_tree.git
git fetch --no-tags hverkuil-media tegrav4
git checkout 8e6137f211b496f99153e409c92f7a5ce3c9dbf3
vim +/ret +1864 drivers/media/i2c/imx274.c

e671499303e4c0 Kieran Bingham      2019-07-10  1848  static int imx274_probe(struct i2c_client *client)
0985dd306f727d Leon Luo            2017-10-05  1849  {
0985dd306f727d Leon Luo            2017-10-05  1850  	struct v4l2_subdev *sd;
0985dd306f727d Leon Luo            2017-10-05  1851  	struct stimx274 *imx274;
0985dd306f727d Leon Luo            2017-10-05  1852  	int ret;
0985dd306f727d Leon Luo            2017-10-05  1853  
0985dd306f727d Leon Luo            2017-10-05  1854  	/* initialize imx274 */
0985dd306f727d Leon Luo            2017-10-05  1855  	imx274 = devm_kzalloc(&client->dev, sizeof(*imx274), GFP_KERNEL);
0985dd306f727d Leon Luo            2017-10-05  1856  	if (!imx274)
0985dd306f727d Leon Luo            2017-10-05  1857  		return -ENOMEM;
0985dd306f727d Leon Luo            2017-10-05  1858  
0985dd306f727d Leon Luo            2017-10-05  1859  	mutex_init(&imx274->lock);
0985dd306f727d Leon Luo            2017-10-05  1860  
8e6137f211b496 Sowjanya Komatineni 2020-06-03  1861  	imx274->xclk = devm_clk_get(&client->dev, "xclk");
8e6137f211b496 Sowjanya Komatineni 2020-06-03  1862  	if (IS_ERR(imx274->xclk)) {
8e6137f211b496 Sowjanya Komatineni 2020-06-03  1863  		dev_err(&client->dev, "Failed to get xclk\n");
8e6137f211b496 Sowjanya Komatineni 2020-06-03 @1864  		return ret;

"ret" is uninitialized.

8e6137f211b496 Sowjanya Komatineni 2020-06-03  1865  	}
8e6137f211b496 Sowjanya Komatineni 2020-06-03  1866  
8e6137f211b496 Sowjanya Komatineni 2020-06-03  1867  	ret = clk_set_rate(imx274->xclk, IMX274_DEFAULT_CLK_FREQ);
8e6137f211b496 Sowjanya Komatineni 2020-06-03  1868  	if (ret < 0) {
8e6137f211b496 Sowjanya Komatineni 2020-06-03  1869  		dev_err(&client->dev, "Failed to set xclk rate\n");
8e6137f211b496 Sowjanya Komatineni 2020-06-03  1870  		return ret;
8e6137f211b496 Sowjanya Komatineni 2020-06-03  1871  	}

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 38824 bytes --]

             reply	other threads:[~2020-08-31 12:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-31 12:03 Dan Carpenter [this message]
2020-08-31 12:03 ` [hverkuil-media:tegrav4 22/25] drivers/media/i2c/imx274.c:1864 imx274_probe() error: uninitialized symbol 'ret' Dan Carpenter
  -- strict thread matches above, loose matches on Subject: below --
2020-08-28  3:00 kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200831120341.GI8299@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=kbuild@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.