* [PATCH] RDMA/umem: Fix signature of stub ib_umem_find_best_pgsz()
@ 2020-08-25 18:17 Jason Gunthorpe
2020-08-26 6:15 ` Gal Pressman
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jason Gunthorpe @ 2020-08-25 18:17 UTC (permalink / raw)
To: linux-rdma; +Cc: Shiraz Saleem
The original function returns unsigned long and 0 on failure.
Fixes: 4a35339958f1 ("RDMA/umem: Add API to find best driver supported page size in an MR")
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
---
include/rdma/ib_umem.h | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/include/rdma/ib_umem.h b/include/rdma/ib_umem.h
index 71f573a418bf06..07a764eb692eed 100644
--- a/include/rdma/ib_umem.h
+++ b/include/rdma/ib_umem.h
@@ -68,10 +68,11 @@ static inline int ib_umem_copy_from(void *dst, struct ib_umem *umem, size_t offs
size_t length) {
return -EINVAL;
}
-static inline int ib_umem_find_best_pgsz(struct ib_umem *umem,
- unsigned long pgsz_bitmap,
- unsigned long virt) {
- return -EINVAL;
+static inline unsigned long ib_umem_find_best_pgsz(struct ib_umem *umem,
+ unsigned long pgsz_bitmap,
+ unsigned long virt)
+{
+ return 0;
}
#endif /* CONFIG_INFINIBAND_USER_MEM */
--
2.28.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] RDMA/umem: Fix signature of stub ib_umem_find_best_pgsz()
2020-08-25 18:17 [PATCH] RDMA/umem: Fix signature of stub ib_umem_find_best_pgsz() Jason Gunthorpe
@ 2020-08-26 6:15 ` Gal Pressman
2020-08-30 23:32 ` Saleem, Shiraz
2020-08-31 15:26 ` Jason Gunthorpe
2 siblings, 0 replies; 4+ messages in thread
From: Gal Pressman @ 2020-08-26 6:15 UTC (permalink / raw)
To: Jason Gunthorpe, linux-rdma; +Cc: Shiraz Saleem
On 25/08/2020 21:17, Jason Gunthorpe wrote:
> The original function returns unsigned long and 0 on failure.
>
> Fixes: 4a35339958f1 ("RDMA/umem: Add API to find best driver supported page size in an MR")
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> ---
> include/rdma/ib_umem.h | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/include/rdma/ib_umem.h b/include/rdma/ib_umem.h
> index 71f573a418bf06..07a764eb692eed 100644
> --- a/include/rdma/ib_umem.h
> +++ b/include/rdma/ib_umem.h
> @@ -68,10 +68,11 @@ static inline int ib_umem_copy_from(void *dst, struct ib_umem *umem, size_t offs
> size_t length) {
> return -EINVAL;
> }
> -static inline int ib_umem_find_best_pgsz(struct ib_umem *umem,
> - unsigned long pgsz_bitmap,
> - unsigned long virt) {
> - return -EINVAL;
> +static inline unsigned long ib_umem_find_best_pgsz(struct ib_umem *umem,
> + unsigned long pgsz_bitmap,
> + unsigned long virt)
> +{
> + return 0;
> }
>
> #endif /* CONFIG_INFINIBAND_USER_MEM */
>
Reviewed-by: Gal Pressman <galpress@amazon.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH] RDMA/umem: Fix signature of stub ib_umem_find_best_pgsz()
2020-08-25 18:17 [PATCH] RDMA/umem: Fix signature of stub ib_umem_find_best_pgsz() Jason Gunthorpe
2020-08-26 6:15 ` Gal Pressman
@ 2020-08-30 23:32 ` Saleem, Shiraz
2020-08-31 15:26 ` Jason Gunthorpe
2 siblings, 0 replies; 4+ messages in thread
From: Saleem, Shiraz @ 2020-08-30 23:32 UTC (permalink / raw)
To: Jason Gunthorpe, linux-rdma@vger.kernel.org
> Subject: [PATCH] RDMA/umem: Fix signature of stub ib_umem_find_best_pgsz()
>
> The original function returns unsigned long and 0 on failure.
>
> Fixes: 4a35339958f1 ("RDMA/umem: Add API to find best driver supported page
> size in an MR")
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> ---
> include/rdma/ib_umem.h | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/include/rdma/ib_umem.h b/include/rdma/ib_umem.h index
> 71f573a418bf06..07a764eb692eed 100644
> --- a/include/rdma/ib_umem.h
> +++ b/include/rdma/ib_umem.h
> @@ -68,10 +68,11 @@ static inline int ib_umem_copy_from(void *dst, struct
> ib_umem *umem, size_t offs
> size_t length) {
> return -EINVAL;
> }
> -static inline int ib_umem_find_best_pgsz(struct ib_umem *umem,
> - unsigned long pgsz_bitmap,
> - unsigned long virt) {
> - return -EINVAL;
> +static inline unsigned long ib_umem_find_best_pgsz(struct ib_umem *umem,
> + unsigned long pgsz_bitmap,
> + unsigned long virt)
> +{
> + return 0;
> }
>
> #endif /* CONFIG_INFINIBAND_USER_MEM */
Acked-by: Shiraz Saleem <shiraz.saleem@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] RDMA/umem: Fix signature of stub ib_umem_find_best_pgsz()
2020-08-25 18:17 [PATCH] RDMA/umem: Fix signature of stub ib_umem_find_best_pgsz() Jason Gunthorpe
2020-08-26 6:15 ` Gal Pressman
2020-08-30 23:32 ` Saleem, Shiraz
@ 2020-08-31 15:26 ` Jason Gunthorpe
2 siblings, 0 replies; 4+ messages in thread
From: Jason Gunthorpe @ 2020-08-31 15:26 UTC (permalink / raw)
To: linux-rdma; +Cc: Shiraz Saleem
On Tue, Aug 25, 2020 at 03:17:08PM -0300, Jason Gunthorpe wrote:
> The original function returns unsigned long and 0 on failure.
>
> Fixes: 4a35339958f1 ("RDMA/umem: Add API to find best driver supported page size in an MR")
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> Reviewed-by: Gal Pressman <galpress@amazon.com>
> Acked-by: Shiraz Saleem <shiraz.saleem@intel.com>
> ---
> include/rdma/ib_umem.h | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
Applied to for-next
Jason
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-08-31 15:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-25 18:17 [PATCH] RDMA/umem: Fix signature of stub ib_umem_find_best_pgsz() Jason Gunthorpe
2020-08-26 6:15 ` Gal Pressman
2020-08-30 23:32 ` Saleem, Shiraz
2020-08-31 15:26 ` Jason Gunthorpe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.