From: Wolfram Sang <wsa@kernel.org>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH 4/5] ARM: dts: Aspeed: Tacoma: Add IBM Operation Panel I2C device
Date: Tue, 1 Sep 2020 08:11:39 +0200 [thread overview]
Message-ID: <20200901061139.GC1148@ninjato> (raw)
In-Reply-To: <CACPK8XfeKiee-LAQZXs6jygr1Bj7pqGTGLUnTV1mzO5FBZ-XZQ@mail.gmail.com>
> > + ibm-panel at 62 {
> > + compatible = "ibm,op-panel";
> > + reg = <0x40000062>; /* I2C_OWN_SLAVE_ADDRESS */
>
> Other users of SLAVE_ADDRESS have included <dt-bindings/i2c/i2c.h> and
> written the reg as follows:
>
> reg = <(I2C_OWN_SLAVE_ADDRESS | 0x62)>
>
> Which obviously has the same result. I'll leave it up to you.
The latter, please.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linux-aspeed/attachments/20200901/c7ad5023/attachment-0001.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@kernel.org>
To: Joel Stanley <joel@jms.id.au>
Cc: Eddie James <eajames@linux.ibm.com>,
linux-input@vger.kernel.org,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-aspeed <linux-aspeed@lists.ozlabs.org>,
linux-i2c@vger.kernel.org, Andrew Jeffery <andrew@aj.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Brendan Higgins <brendanhiggins@google.com>,
dmitry.torokhov@gmail.com, Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH 4/5] ARM: dts: Aspeed: Tacoma: Add IBM Operation Panel I2C device
Date: Tue, 1 Sep 2020 08:11:39 +0200 [thread overview]
Message-ID: <20200901061139.GC1148@ninjato> (raw)
In-Reply-To: <CACPK8XfeKiee-LAQZXs6jygr1Bj7pqGTGLUnTV1mzO5FBZ-XZQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 398 bytes --]
> > + ibm-panel@62 {
> > + compatible = "ibm,op-panel";
> > + reg = <0x40000062>; /* I2C_OWN_SLAVE_ADDRESS */
>
> Other users of SLAVE_ADDRESS have included <dt-bindings/i2c/i2c.h> and
> written the reg as follows:
>
> reg = <(I2C_OWN_SLAVE_ADDRESS | 0x62)>
>
> Which obviously has the same result. I'll leave it up to you.
The latter, please.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-09-01 6:11 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 16:11 [PATCH 0/5] input: misc: Add IBM Operation Panel driver Eddie James
2020-08-20 16:11 ` Eddie James
2020-08-20 16:11 ` [PATCH 1/5] dt-bindings: input: Add documentation for IBM Operation Panel Eddie James
2020-08-20 16:11 ` Eddie James
2020-09-01 6:01 ` Joel Stanley
2020-09-01 6:01 ` Joel Stanley
2020-09-08 20:37 ` Rob Herring
2020-09-08 20:37 ` Rob Herring
2020-08-20 16:11 ` [PATCH 2/5] input: misc: Add IBM Operation Panel driver Eddie James
2020-08-20 16:11 ` Eddie James
2020-09-01 5:58 ` Joel Stanley
2020-09-01 5:58 ` Joel Stanley
2020-09-01 6:11 ` Wolfram Sang
2020-09-01 6:11 ` Wolfram Sang
2020-09-02 15:47 ` Eddie James
2020-09-02 15:47 ` Eddie James
2020-08-20 16:11 ` [PATCH 3/5] i2c: aspeed: Mask IRQ status to relevant bits Eddie James
2020-08-20 16:11 ` Eddie James
2020-08-21 5:54 ` Wolfram Sang
2020-08-21 5:54 ` Wolfram Sang
2020-08-25 6:38 ` Joel Stanley
2020-08-25 6:38 ` Joel Stanley
2020-08-25 19:47 ` Eddie James
2020-08-25 19:47 ` Eddie James
2020-08-25 20:05 ` Tao Ren
2020-08-25 20:05 ` Tao Ren
2020-08-26 1:59 ` Ryan Chen
2020-08-26 1:59 ` Ryan Chen
2020-08-20 16:11 ` [PATCH 4/5] ARM: dts: Aspeed: Tacoma: Add IBM Operation Panel I2C device Eddie James
2020-08-20 16:11 ` Eddie James
2020-09-01 6:00 ` Joel Stanley
2020-09-01 6:00 ` Joel Stanley
2020-09-01 6:11 ` Wolfram Sang [this message]
2020-09-01 6:11 ` Wolfram Sang
2020-08-20 16:11 ` [PATCH 5/5] ARM: dts: Aspeed: Rainier: " Eddie James
2020-08-20 16:11 ` Eddie James
2020-09-01 6:01 ` Joel Stanley
2020-09-01 6:01 ` Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200901061139.GC1148@ninjato \
--to=wsa@kernel.org \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.