From: Christoph Hellwig <hch@lst.de>
To: Nicolin Chen <nicoleotsuka@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>,
mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org,
rth@twiddle.net, ink@jurassic.park.msu.ru, mattst88@gmail.com,
tony.luck@intel.com, fenghua.yu@intel.com,
schnelle@linux.ibm.com, gerald.schaefer@linux.ibm.com,
hca@linux.ibm.com, gor@linux.ibm.com, borntraeger@de.ibm.com,
davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, x86@kernel.org, hpa@zytor.com,
James.Bottomley@HansenPartnership.com, deller@gmx.de,
sfr@canb.auug.org.au, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org,
linux-ia64@vger.kernel.org, linux-s390@vger.kernel.org,
sparclinux@vger.kernel.org, linux-parisc@vger.kernel.org
Subject: Re: [RESEND][PATCH 0/7] Avoid overflow at boundary_size
Date: Tue, 1 Sep 2020 11:11:05 +0200 [thread overview]
Message-ID: <20200901091105.GA4959@lst.de> (raw)
In-Reply-To: <20200901075401.GA5667@Asurada-Nvidia>
On Tue, Sep 01, 2020 at 12:54:01AM -0700, Nicolin Chen wrote:
> Hi Christoph,
>
> On Tue, Sep 01, 2020 at 09:36:23AM +0200, Christoph Hellwig wrote:
> > I really don't like all the open coded smarts in the various drivers.
> > What do you think about a helper like the one in the untested patch
>
> A helper function will be actually better. I was thinking of
> one yet not very sure about the naming and where to put it.
>
> > below (on top of your series). Also please include the original
> > segment boundary patch with the next resend so that the series has
> > the full context.
>
> I will use your change instead and resend with the ULONG_MAX
> change. But in that case, should I make separate changes for
> different files like this series, or just one single change
> like yours?
>
> Asking this as I was expecting that those changes would get
> applied by different maintainers. But now it feels like you
> will merge it to your tree at once?
I guess one patch is fine. I can queue it up in the dma-mapping
tree as a prep patch for the default boundary change.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Nicolin Chen <nicoleotsuka@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>,
mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org,
rth@twiddle.net, ink@jurassic.park.msu.ru, mattst88@gmail.com,
tony.luck@intel.com, fenghua.yu@intel.com,
schnelle@linux.ibm.com, gerald.schaefer@linux.ibm.com,
hca@linux.ibm.com, gor@linux.ibm.com, borntraeger@de.ibm.com,
davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, x86@kernel.org, hpa@zytor.com,
James.Bottomley@HansenPartnership.com, deller@gmx.de,
sfr@canb.auug.org.au, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org,
linux-ia64@vger.kernel.org, linux-s390@vger.kernel.org,
sparclinux@vger.kernel.org, linux-parisc@vger.kernel.org
Subject: Re: [RESEND][PATCH 0/7] Avoid overflow at boundary_size
Date: Tue, 01 Sep 2020 09:11:05 +0000 [thread overview]
Message-ID: <20200901091105.GA4959@lst.de> (raw)
In-Reply-To: <20200901075401.GA5667@Asurada-Nvidia>
On Tue, Sep 01, 2020 at 12:54:01AM -0700, Nicolin Chen wrote:
> Hi Christoph,
>
> On Tue, Sep 01, 2020 at 09:36:23AM +0200, Christoph Hellwig wrote:
> > I really don't like all the open coded smarts in the various drivers.
> > What do you think about a helper like the one in the untested patch
>
> A helper function will be actually better. I was thinking of
> one yet not very sure about the naming and where to put it.
>
> > below (on top of your series). Also please include the original
> > segment boundary patch with the next resend so that the series has
> > the full context.
>
> I will use your change instead and resend with the ULONG_MAX
> change. But in that case, should I make separate changes for
> different files like this series, or just one single change
> like yours?
>
> Asking this as I was expecting that those changes would get
> applied by different maintainers. But now it feels like you
> will merge it to your tree at once?
I guess one patch is fine. I can queue it up in the dma-mapping
tree as a prep patch for the default boundary change.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Nicolin Chen <nicoleotsuka@gmail.com>
Cc: linux-ia64@vger.kernel.org,
James.Bottomley@HansenPartnership.com, paulus@samba.org,
hpa@zytor.com, sparclinux@vger.kernel.org,
Christoph Hellwig <hch@lst.de>,
sfr@canb.auug.org.au, deller@gmx.de, x86@kernel.org,
borntraeger@de.ibm.com, mingo@redhat.com, mattst88@gmail.com,
fenghua.yu@intel.com, gor@linux.ibm.com, schnelle@linux.ibm.com,
hca@linux.ibm.com, ink@jurassic.park.msu.ru, tglx@linutronix.de,
gerald.schaefer@linux.ibm.com, rth@twiddle.net,
tony.luck@intel.com, linux-parisc@vger.kernel.org,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-alpha@vger.kernel.org, bp@alien8.de,
linuxppc-dev@lists.ozlabs.org, davem@davemloft.net
Subject: Re: [RESEND][PATCH 0/7] Avoid overflow at boundary_size
Date: Tue, 1 Sep 2020 11:11:05 +0200 [thread overview]
Message-ID: <20200901091105.GA4959@lst.de> (raw)
In-Reply-To: <20200901075401.GA5667@Asurada-Nvidia>
On Tue, Sep 01, 2020 at 12:54:01AM -0700, Nicolin Chen wrote:
> Hi Christoph,
>
> On Tue, Sep 01, 2020 at 09:36:23AM +0200, Christoph Hellwig wrote:
> > I really don't like all the open coded smarts in the various drivers.
> > What do you think about a helper like the one in the untested patch
>
> A helper function will be actually better. I was thinking of
> one yet not very sure about the naming and where to put it.
>
> > below (on top of your series). Also please include the original
> > segment boundary patch with the next resend so that the series has
> > the full context.
>
> I will use your change instead and resend with the ULONG_MAX
> change. But in that case, should I make separate changes for
> different files like this series, or just one single change
> like yours?
>
> Asking this as I was expecting that those changes would get
> applied by different maintainers. But now it feels like you
> will merge it to your tree at once?
I guess one patch is fine. I can queue it up in the dma-mapping
tree as a prep patch for the default boundary change.
next prev parent reply other threads:[~2020-09-01 9:11 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 20:38 [RESEND][PATCH 0/7] Avoid overflow at boundary_size Nicolin Chen
2020-08-31 20:38 ` Nicolin Chen
2020-08-31 20:38 ` Nicolin Chen
2020-08-31 20:38 ` [RESEND][PATCH 1/7] powerpc/iommu: " Nicolin Chen
2020-08-31 20:38 ` Nicolin Chen
2020-08-31 20:38 ` Nicolin Chen
2020-09-01 13:27 ` Michael Ellerman
2020-09-01 13:27 ` Michael Ellerman
2020-09-01 13:27 ` Michael Ellerman
2020-09-01 20:53 ` Nicolin Chen
2020-09-01 20:53 ` Nicolin Chen
2020-09-01 20:53 ` Nicolin Chen
2020-08-31 20:38 ` [RESEND][PATCH 2/7] alpha: " Nicolin Chen
2020-08-31 20:38 ` Nicolin Chen
2020-08-31 20:38 ` Nicolin Chen
2020-08-31 20:38 ` [RESEND][PATCH 3/7] ia64/sba_iommu: " Nicolin Chen
2020-08-31 20:38 ` Nicolin Chen
2020-08-31 20:38 ` Nicolin Chen
2020-08-31 20:38 ` [RESEND][PATCH 4/7] s390/pci_dma: " Nicolin Chen
2020-08-31 20:38 ` Nicolin Chen
2020-08-31 20:38 ` Nicolin Chen
2020-08-31 20:38 ` [RESEND][PATCH 5/7] sparc: " Nicolin Chen
2020-08-31 20:38 ` Nicolin Chen
2020-08-31 20:38 ` Nicolin Chen
2020-08-31 20:38 ` [RESEND][PATCH 6/7] x86/amd_gart: " Nicolin Chen
2020-08-31 20:38 ` Nicolin Chen
2020-08-31 20:38 ` Nicolin Chen
2020-08-31 20:38 ` [RESEND][PATCH 7/7] parisc: " Nicolin Chen
2020-08-31 20:38 ` Nicolin Chen
2020-08-31 20:38 ` Nicolin Chen
2020-09-01 7:36 ` [RESEND][PATCH 0/7] " Christoph Hellwig
2020-09-01 7:36 ` Christoph Hellwig
2020-09-01 7:36 ` Christoph Hellwig
2020-09-01 7:54 ` Nicolin Chen
2020-09-01 7:54 ` Nicolin Chen
2020-09-01 7:54 ` Nicolin Chen
2020-09-01 9:11 ` Christoph Hellwig [this message]
2020-09-01 9:11 ` Christoph Hellwig
2020-09-01 9:11 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200901091105.GA4959@lst.de \
--to=hch@lst.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=benh@kernel.crashing.org \
--cc=borntraeger@de.ibm.com \
--cc=bp@alien8.de \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=fenghua.yu@intel.com \
--cc=gerald.schaefer@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mattst88@gmail.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=nicoleotsuka@gmail.com \
--cc=paulus@samba.org \
--cc=rth@twiddle.net \
--cc=schnelle@linux.ibm.com \
--cc=sfr@canb.auug.org.au \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.