From: Kalle Valo <kvalo@codeaurora.org>
To: Jia-Ju Bai <baijiaju@tsinghua.edu.cn>
Cc: chunkeey@googlemail.com, davem@davemloft.net, kuba@kernel.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Jia-Ju Bai <baijiaju@tsinghua.edu.cn>
Subject: Re: p54: avoid accessing the data mapped to streaming DMA
Date: Tue, 1 Sep 2020 09:34:04 +0000 (UTC) [thread overview]
Message-ID: <20200901093404.47364C433CB@smtp.codeaurora.org> (raw)
In-Reply-To: <20200802132949.26788-1-baijiaju@tsinghua.edu.cn>
Jia-Ju Bai <baijiaju@tsinghua.edu.cn> wrote:
> In p54p_tx(), skb->data is mapped to streaming DMA on line 337:
> mapping = pci_map_single(..., skb->data, ...);
>
> Then skb->data is accessed on line 349:
> desc->device_addr = ((struct p54_hdr *)skb->data)->req_id;
>
> This access may cause data inconsistency between CPU cache and hardware.
>
> To fix this problem, ((struct p54_hdr *)skb->data)->req_id is stored in
> a local variable before DMA mapping, and then the driver accesses this
> local variable instead of skb->data.
>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Jia-Ju Bai <baijiaju@tsinghua.edu.cn>
> Acked-by: Christian Lamparter <chunkeey@gmail.com>
Patch applied to wireless-drivers-next.git, thanks.
478762855b5a p54: avoid accessing the data mapped to streaming DMA
--
https://patchwork.kernel.org/patch/11696391/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2020-09-01 9:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-02 13:29 [PATCH] p54: avoid accessing the data mapped to streaming DMA Jia-Ju Bai
2020-08-18 12:41 ` Kalle Valo
2020-08-18 17:27 ` Christian Lamparter
2020-08-26 16:02 ` Kalle Valo
2020-08-28 21:19 ` Christian Lamparter
2020-08-31 14:00 ` Kalle Valo
2020-09-01 9:34 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200901093404.47364C433CB@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=baijiaju@tsinghua.edu.cn \
--cc=chunkeey@googlemail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.