All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Martin <Dave.Martin@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: Will Deacon <will@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Shuah Khan <shuah@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v2 6/6] selftests: arm64: Add build and documentation for FP tests
Date: Tue, 1 Sep 2020 16:38:42 +0100	[thread overview]
Message-ID: <20200901153840.GA6642@arm.com> (raw)
In-Reply-To: <20200819114837.51466-7-broonie@kernel.org>

On Wed, Aug 19, 2020 at 12:48:37PM +0100, Mark Brown wrote:
> Integrate the FP tests with the build system and add some documentation
> for the ones run outside the kselftest infrastructure.  The content in
> the README was largely written by Dave Martin with edits by me.

Apologies, I never got around to looking at all this, though it seems
reasonable.


I don't know whether this is worth following up with a TODO?

Some things I was aware of:

 * The sve-test/fpsimd-test programs contain a lot of common
   boilerplate and could probably be merged together.

 * A fair amount of the asm in sve-test/fpsimd-test could be converted
   to C, with -fgeneral-regs-only.  This would be helpful since the
   code is highly unmaintainable in its current form (I know, I've
   tried).  Calling library functions would still be a problem, but we
   might be able to lift a printf implementation and some basic syscall
   wrappers from elsewhere rather than reimplementing everything from
   scratch.

 * The sve-stress/fpsimd-stress scripts could likewise be merged.
   Also, doing the required process management from the shell seems a
   doomed enterprise and it never really worked 100% right.  Eventually
   it might be worth rewriting a common test driver for these in a real
   language.

 * While the tests confirm that basic aspects of the SVE support don't
   explode, there is not a lot of checking that the kernel does the
   _correct_ thing -- so there's scope for improvement here if somebody
   gets around to it.

Cheers
---Dave

WARNING: multiple messages have this Message-ID (diff)
From: Dave Martin <Dave.Martin@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Shuah Khan <shuah@kernel.org>, Will Deacon <will@kernel.org>,
	linux-kselftest@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 6/6] selftests: arm64: Add build and documentation for FP tests
Date: Tue, 1 Sep 2020 16:38:42 +0100	[thread overview]
Message-ID: <20200901153840.GA6642@arm.com> (raw)
In-Reply-To: <20200819114837.51466-7-broonie@kernel.org>

On Wed, Aug 19, 2020 at 12:48:37PM +0100, Mark Brown wrote:
> Integrate the FP tests with the build system and add some documentation
> for the ones run outside the kselftest infrastructure.  The content in
> the README was largely written by Dave Martin with edits by me.

Apologies, I never got around to looking at all this, though it seems
reasonable.


I don't know whether this is worth following up with a TODO?

Some things I was aware of:

 * The sve-test/fpsimd-test programs contain a lot of common
   boilerplate and could probably be merged together.

 * A fair amount of the asm in sve-test/fpsimd-test could be converted
   to C, with -fgeneral-regs-only.  This would be helpful since the
   code is highly unmaintainable in its current form (I know, I've
   tried).  Calling library functions would still be a problem, but we
   might be able to lift a printf implementation and some basic syscall
   wrappers from elsewhere rather than reimplementing everything from
   scratch.

 * The sve-stress/fpsimd-stress scripts could likewise be merged.
   Also, doing the required process management from the shell seems a
   doomed enterprise and it never really worked 100% right.  Eventually
   it might be worth rewriting a common test driver for these in a real
   language.

 * While the tests confirm that basic aspects of the SVE support don't
   explode, there is not a lot of checking that the kernel does the
   _correct_ thing -- so there's scope for improvement here if somebody
   gets around to it.

Cheers
---Dave

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-09-01 16:09 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-19 11:48 [PATCH v2 0/6] selftests: arm64: Add floating point selftests Mark Brown
2020-08-19 11:48 ` Mark Brown
2020-08-19 11:48 ` [PATCH v2 1/6] selftests: arm64: Test case for enumeration of SVE vector lengths Mark Brown
2020-08-19 11:48   ` Mark Brown
2020-08-19 11:48 ` [PATCH v2 2/6] selftests: arm64: Add test for the SVE ptrace interface Mark Brown
2020-08-19 11:48   ` Mark Brown
2020-08-19 11:48 ` [PATCH v2 3/6] selftests: arm64: Add stress tests for FPSMID and SVE context switching Mark Brown
2020-08-19 11:48   ` Mark Brown
2020-08-19 11:48 ` [PATCH v2 4/6] selftests: arm64: Add utility to set SVE vector lengths Mark Brown
2020-08-19 11:48   ` Mark Brown
2020-08-19 11:48 ` [PATCH v2 5/6] selftests: arm64: Add wrapper scripts for stress tests Mark Brown
2020-08-19 11:48   ` Mark Brown
2020-08-19 11:48 ` [PATCH v2 6/6] selftests: arm64: Add build and documentation for FP tests Mark Brown
2020-08-19 11:48   ` Mark Brown
2020-09-01 15:38   ` Dave Martin [this message]
2020-09-01 15:38     ` Dave Martin
2020-09-01 15:47     ` Mark Brown
2020-09-01 15:47       ` Mark Brown
2020-09-01 16:06       ` Dave Martin
2020-09-01 16:06         ` Dave Martin
2020-08-31 21:45 ` [PATCH v2 0/6] selftests: arm64: Add floating point selftests Shuah Khan
2020-08-31 21:45   ` Shuah Khan
2020-09-01 13:21   ` Will Deacon
2020-09-01 13:21     ` Will Deacon
2020-09-01 15:27     ` Dave Martin
2020-09-01 15:27       ` Dave Martin
2020-09-18 16:17 ` Will Deacon
2020-09-18 16:17   ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200901153840.GA6642@arm.com \
    --to=dave.martin@arm.com \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.