From: Patrick Williams <patrick@stwcx.xyz>
To: "Wang, Kuiying" <kuiying.wang@intel.com>
Cc: "openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
Brad Bishop <bradleyb@fuzziesquirrel.com>
Subject: Re: Need update CI build config for new repo smbios-mdr.
Date: Tue, 1 Sep 2020 11:41:39 -0500 [thread overview]
Message-ID: <20200901164139.GV3532@heinlein> (raw)
In-Reply-To: <20200901162333.GT3532@heinlein>
[-- Attachment #1: Type: text/plain, Size: 1345 bytes --]
Also, a few minor comments on your proposed dependencies.
On Tue, Sep 01, 2020 at 11:23:33AM -0500, Patrick Williams wrote:
> On Mon, Aug 31, 2020 at 01:45:17AM +0000, Wang, Kuiying wrote:
> > DEPENDS += " \
> > autoconf-archive-native \
Your repository appears to be cmake-based, so I don't think there is any
reason for you to have autoconf-archive as a dependency.
> > sdbusplus-native \
This alias is only provided for convenience but should not be used any
longer. Please use '${PYTHONPN}-sdbus++-native' instead if you really
have a dependency on using the sdbus++ tool within your repository.
There should be fairly few cases where you actually have this dependency
though, so if you're not calling `sdbus++` in your own build process,
don't add it.
`git grep sdbusplus-native` shows only a recipe added on Aug 3rd, which
is incorrect.
> > phosphor-dbus-interfaces-native \
This no longer exists. I suspect you don't need this either. There is
a fairly rare case when you might now need
'phosphor-dbus-interfaces-yaml' but I suspect this repository isn't one.
Probably your existing dependency on 'phosphor-dbus-interfaces' is all
you need.
`git grep interfaces-native` shows no hits.
`git grep interfaces-yaml` shows only a hit on an sdk package group.
--
Patrick Williams
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-09-01 16:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <SN6PR11MB35203BE16B23BAD1193FCB9F90550@SN6PR11MB3520.namprd11.prod.outlook.com>
[not found] ` <5a9a43046be525f9ed5d23bc40eac14d4ed8d53c.camel@fuzziesquirrel.com>
2020-08-31 1:45 ` Need update CI build config for new repo smbios-mdr Wang, Kuiying
2020-09-01 16:23 ` Patrick Williams
2020-09-01 16:41 ` Patrick Williams [this message]
2020-09-02 2:02 ` Wang, Kuiying
2020-09-02 5:46 ` 郁雷
2020-09-02 5:53 ` Wang, Kuiying
2020-09-02 15:49 ` Patrick Williams
2020-09-02 18:24 ` Bills, Jason M
2020-09-02 21:46 ` Ren, Zhikui
2020-09-03 4:17 ` Wang, Kuiying
2020-09-02 2:22 ` Wang, Kuiying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200901164139.GV3532@heinlein \
--to=patrick@stwcx.xyz \
--cc=bradleyb@fuzziesquirrel.com \
--cc=kuiying.wang@intel.com \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.