Need update CI build config for new repo smbios-mdr.

Need update CI build config for new repo smbios-mdr.

[Wang, Kuiying]

 Hi Brad,
 I am starting to enable the new repo smbios-mdr, but there is build 
 failure.
 CI build config need add below depends:
 DEPENDS += " \
     autoconf-archive-native \
     boost \
     systemd \
     sdbusplus \
     sdbusplus-native \
     phosphor-dbus-interfaces \
     phosphor-dbus-interfaces-native \
     phosphor-logging \
     libpeci \
     i2c-tools \
     "
 
 https://gerrit.openbmc-project.xyz/#/c/openbmc/smbios-mdr/+/36011/
 
 
 Thanks,
 Kwin.

Re: Need update CI build config for new repo smbios-mdr.

[Patrick Williams]

[-- Attachment #1: Type: text/plain, Size: 1124 bytes --]

On Mon, Aug 31, 2020 at 01:45:17AM +0000, Wang, Kuiying wrote:
>  Hi Brad,
>  I am starting to enable the new repo smbios-mdr, but there is build 
>  failure.
>  CI build config need add below depends:
>  DEPENDS += " \
>      autoconf-archive-native \
>      boost \
>      systemd \
>      sdbusplus \
>      sdbusplus-native \
>      phosphor-dbus-interfaces \
>      phosphor-dbus-interfaces-native \
>      phosphor-logging \
>      libpeci \
>      i2c-tools \
>      "
>  
>  https://gerrit.openbmc-project.xyz/#/c/openbmc/smbios-mdr/+/36011/
>  
>  
>  Thanks,
>  Kwin.
> 

Hello Kwin.

Individual repository CI builds to not happen within the context of
Yocto.  If you think there are some dependencies missing, you'll want to
enhance the 'openbmc/openbmc-build-scripts' repository to include your
additional dependencies.  In the repo-level CI path, we build Docker
images that contain all the dependencies and build the repo-under-test
within that.

Your Jenkins console log seems to have expired, so I can't tell exactly
what is missing in your case.

-- 
Patrick Williams

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: Need update CI build config for new repo smbios-mdr.

[Patrick Williams]

[-- Attachment #1: Type: text/plain, Size: 1345 bytes --]

Also, a few minor comments on your proposed dependencies.

On Tue, Sep 01, 2020 at 11:23:33AM -0500, Patrick Williams wrote:
> On Mon, Aug 31, 2020 at 01:45:17AM +0000, Wang, Kuiying wrote:
> >  DEPENDS += " \
> >      autoconf-archive-native \

Your repository appears to be cmake-based, so I don't think there is any
reason for you to have autoconf-archive as a dependency.

> >      sdbusplus-native \

This alias is only provided for convenience but should not be used any
longer.  Please use '${PYTHONPN}-sdbus++-native' instead if you really
have a dependency on using the sdbus++ tool within your repository.
There should be fairly few cases where you actually have this dependency
though, so if you're not calling `sdbus++` in your own build process,
don't add it.

`git grep sdbusplus-native` shows only a recipe added on Aug 3rd, which
is incorrect.

> >      phosphor-dbus-interfaces-native \

This no longer exists.  I suspect you don't need this either.  There is
a fairly rare case when you might now need
'phosphor-dbus-interfaces-yaml' but I suspect this repository isn't one.
Probably your existing dependency on 'phosphor-dbus-interfaces' is all
you need.

`git grep interfaces-native` shows no hits.
`git grep interfaces-yaml` shows only a hit on an sdk package group.

-- 
Patrick Williams

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

RE: Need update CI build config for new repo smbios-mdr.

[Wang, Kuiying]

Hi Williams,
The key thing is sdbusplus interface is not match.
You could config CI based on this patch https://gerrit.openbmc-project.xyz/#/c/openbmc/smbios-mdr/+/36011/
That's ok, if it can pass the build.

Thanks,
Kwin.

-----Original Message-----
From: Patrick Williams <patrick@stwcx.xyz> 
Sent: Wednesday, September 2, 2020 12:42 AM
To: Wang, Kuiying <kuiying.wang@intel.com>
Cc: openbmc@lists.ozlabs.org; Brad Bishop <bradleyb@fuzziesquirrel.com>
Subject: Re: Need update CI build config for new repo smbios-mdr.

Also, a few minor comments on your proposed dependencies.

On Tue, Sep 01, 2020 at 11:23:33AM -0500, Patrick Williams wrote:
> On Mon, Aug 31, 2020 at 01:45:17AM +0000, Wang, Kuiying wrote:
> >  DEPENDS += " \
> >      autoconf-archive-native \

Your repository appears to be cmake-based, so I don't think there is any reason for you to have autoconf-archive as a dependency.

> >      sdbusplus-native \

This alias is only provided for convenience but should not be used any longer.  Please use '${PYTHONPN}-sdbus++-native' instead if you really have a dependency on using the sdbus++ tool within your repository.
There should be fairly few cases where you actually have this dependency though, so if you're not calling `sdbus++` in your own build process, don't add it.

`git grep sdbusplus-native` shows only a recipe added on Aug 3rd, which is incorrect.

> >      phosphor-dbus-interfaces-native \

This no longer exists.  I suspect you don't need this either.  There is a fairly rare case when you might now need 'phosphor-dbus-interfaces-yaml' but I suspect this repository isn't one.
Probably your existing dependency on 'phosphor-dbus-interfaces' is all you need.

`git grep interfaces-native` shows no hits.
`git grep interfaces-yaml` shows only a hit on an sdk package group.

--
Patrick Williams

RE: Need update CI build config for new repo smbios-mdr.

[Wang, Kuiying]

Hi Williams,
I triggered a new build.
https://gerrit.openbmc-project.xyz/#/c/openbmc/smbios-mdr/+/36011/ 

Thanks,
Kwin.

-----Original Message-----
From: Patrick Williams <patrick@stwcx.xyz> 
Sent: Wednesday, September 2, 2020 12:24 AM
To: Wang, Kuiying <kuiying.wang@intel.com>
Cc: Brad Bishop <bradleyb@fuzziesquirrel.com>; openbmc@lists.ozlabs.org
Subject: Re: Need update CI build config for new repo smbios-mdr.

On Mon, Aug 31, 2020 at 01:45:17AM +0000, Wang, Kuiying wrote:
>  Hi Brad,
>  I am starting to enable the new repo smbios-mdr, but there is build  
> failure.
>  CI build config need add below depends:
>  DEPENDS += " \
>      autoconf-archive-native \
>      boost \
>      systemd \
>      sdbusplus \
>      sdbusplus-native \
>      phosphor-dbus-interfaces \
>      phosphor-dbus-interfaces-native \
>      phosphor-logging \
>      libpeci \
>      i2c-tools \
>      "
>  
>  https://gerrit.openbmc-project.xyz/#/c/openbmc/smbios-mdr/+/36011/
>  
>  
>  Thanks,
>  Kwin.
> 

Hello Kwin.

Individual repository CI builds to not happen within the context of Yocto.  If you think there are some dependencies missing, you'll want to enhance the 'openbmc/openbmc-build-scripts' repository to include your additional dependencies.  In the repo-level CI path, we build Docker images that contain all the dependencies and build the repo-under-test within that.

Your Jenkins console log seems to have expired, so I can't tell exactly what is missing in your case.

--
Patrick Williams

RE: Need update CI build config for new repo smbios-mdr.

[郁雷]

On Wed, Sep 2, 2020 at 10:04 AM Wang, Kuiying <kuiying.wang@intel.com> wrote:
>
> Hi Williams,
> The key thing is sdbusplus interface is not match.

The sdbusplus in openbmc-build-scripts always pick the latest one [1],
so I would guess that smbios-mdr is not using the latest sdbusplus.
Could you check that?


[1]: https://github.com/openbmc/openbmc-build-scripts/blob/master/build-unit-test-docker.sh#L54

RE: Need update CI build config for new repo smbios-mdr.

[Wang, Kuiying]

Ok, let me check.
Thanks a lot Yulei.

Thanks,
Kwin.

-----Original Message-----
From: 郁雷 <yulei.sh@bytedance.com> 
Sent: Wednesday, September 2, 2020 1:46 PM
To: Wang, Kuiying <kuiying.wang@intel.com>
Cc: Patrick Williams <patrick@stwcx.xyz>; openbmc@lists.ozlabs.org; Brad Bishop <bradleyb@fuzziesquirrel.com>
Subject: RE: Need update CI build config for new repo smbios-mdr.

On Wed, Sep 2, 2020 at 10:04 AM Wang, Kuiying <kuiying.wang@intel.com> wrote:
>
> Hi Williams,
> The key thing is sdbusplus interface is not match.

The sdbusplus in openbmc-build-scripts always pick the latest one [1], so I would guess that smbios-mdr is not using the latest sdbusplus.
Could you check that?


[1]: https://github.com/openbmc/openbmc-build-scripts/blob/master/build-unit-test-docker.sh#L54

Re: Need update CI build config for new repo smbios-mdr.

[Patrick Williams]

[-- Attachment #1: Type: text/plain, Size: 2035 bytes --]

On Wed, Sep 02, 2020 at 02:02:00AM +0000, Wang, Kuiying wrote:
> Hi Williams,
> The key thing is sdbusplus interface is not match.
> You could config CI based on this patch https://gerrit.openbmc-project.xyz/#/c/openbmc/smbios-mdr/+/36011/
> That's ok, if it can pass the build.
> 
> Thanks,
> Kwin.
> 

Here is a snippet of the compile log:

/home/jenkins-slave/workspace/ci-repository/openbmc/smbios-mdr/src/cpuinfo_main.cpp:34:10: fatal error: peci.h: No such file or directory
   34 | #include <peci.h>
      |          ^~~~~~~~
compilation terminated.


This one might be a missing dependency?  Where is 'peci.h' from?  Is it
from a kernel header for the ioctls or some other repository?  Do you
need to stub this out when building on x86?


make[2]: *** [CMakeFiles/cpuinfoapp.dir/build.make:63: CMakeFiles/cpuinfoapp.dir/src/cpuinfo_main.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:78: CMakeFiles/cpuinfoapp.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
In file included from /home/jenkins-slave/workspace/ci-repository/openbmc/smbios-mdr/src/cpu.cpp:17:
/home/jenkins-slave/workspace/ci-repository/openbmc/smbios-mdr/include/cpu.hpp:113:17: error: âstd::string phosphor::smbios::Cpu::processorSocket(std::string)â marked âoverrideâ, but does not override
  113 |     std::string processorSocket(std::string value) override;

This appears to be a case where the current phosphor-dbus-interfaces
doesn't match whatever your commit is trying to do.  You've got
additional methods for handling dbus properties, but those properties do
not exist in phosphor-dbus-interface's Cpu interface.

I suspect you're trying to implement
xyz/openbmc_project/Inventory/Item/Cpu, which has a 'Socket' property
but not a 'ProcessorSocket'.  If I recall, this happened in the code
review where the "Processor" part was requested to be removed since it
was redundant.

There are a number of other properties in your compile fail that need
similar updating.

-- 
Patrick Williams

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: Need update CI build config for new repo smbios-mdr.

[Bills, Jason M]

On 9/2/2020 8:49 AM, Patrick Williams wrote:
> On Wed, Sep 02, 2020 at 02:02:00AM +0000, Wang, Kuiying wrote:
>> Hi Williams,
>> The key thing is sdbusplus interface is not match.
>> You could config CI based on this patch https://gerrit.openbmc-project.xyz/#/c/openbmc/smbios-mdr/+/36011/
>> That's ok, if it can pass the build.
>>
>> Thanks,
>> Kwin.
>>
> 
> Here is a snippet of the compile log:
> 
> /home/jenkins-slave/workspace/ci-repository/openbmc/smbios-mdr/src/cpuinfo_main.cpp:34:10: fatal error: peci.h: No such file or directory
>     34 | #include <peci.h>
>        |          ^~~~~~~~
> compilation terminated.
> 
> 
> This one might be a missing dependency?  Where is 'peci.h' from?  Is it
> from a kernel header for the ioctls or some other repository?  Do you
> need to stub this out when building on x86?
peci.h comes from libpeci which needs to be pulled in as an 
ExternalProject in CMake when not building with Yocto.

Here is an example of how I got libpeci working for the 
host-error-monitor to pass CI: 
https://gerrit.openbmc-project.xyz/c/openbmc/host-error-monitor/+/32545/1/CMakeLists.txt.

> 
> 
> make[2]: *** [CMakeFiles/cpuinfoapp.dir/build.make:63: CMakeFiles/cpuinfoapp.dir/src/cpuinfo_main.cpp.o] Error 1
> make[1]: *** [CMakeFiles/Makefile2:78: CMakeFiles/cpuinfoapp.dir/all] Error 2
> make[1]: *** Waiting for unfinished jobs....
> In file included from /home/jenkins-slave/workspace/ci-repository/openbmc/smbios-mdr/src/cpu.cpp:17:
> /home/jenkins-slave/workspace/ci-repository/openbmc/smbios-mdr/include/cpu.hpp:113:17: error: âstd::string phosphor::smbios::Cpu::processorSocket(std::string)â marked âoverrideâ, but does not override
>    113 |     std::string processorSocket(std::string value) override;
> 
> This appears to be a case where the current phosphor-dbus-interfaces
> doesn't match whatever your commit is trying to do.  You've got
> additional methods for handling dbus properties, but those properties do
> not exist in phosphor-dbus-interface's Cpu interface.
> 
> I suspect you're trying to implement
> xyz/openbmc_project/Inventory/Item/Cpu, which has a 'Socket' property
> but not a 'ProcessorSocket'.  If I recall, this happened in the code
> review where the "Processor" part was requested to be removed since it
> was redundant.
> 
> There are a number of other properties in your compile fail that need
> similar updating.
> 

RE: Need update CI build config for new repo smbios-mdr.

[Ren, Zhikui]

Thanks, Jason.

Kwin,

I have updated the patch that is compatible with the current dbus interface, it builds successfully now.
https://gerrit.openbmc-project.xyz/c/openbmc/smbios-mdr/+/36177

Thanks,
Zhikui



-----Original Message-----
From: openbmc <openbmc-bounces+zhikui.ren=intel.com@lists.ozlabs.org> On Behalf Of Bills, Jason M
Sent: Wednesday, September 2, 2020 11:25 AM
To: openbmc@lists.ozlabs.org
Subject: Re: Need update CI build config for new repo smbios-mdr.



On 9/2/2020 8:49 AM, Patrick Williams wrote:
> On Wed, Sep 02, 2020 at 02:02:00AM +0000, Wang, Kuiying wrote:
>> Hi Williams,
>> The key thing is sdbusplus interface is not match.
>> You could config CI based on this patch 
>> https://gerrit.openbmc-project.xyz/#/c/openbmc/smbios-mdr/+/36011/
>> That's ok, if it can pass the build.
>>
>> Thanks,
>> Kwin.
>>
> 
> Here is a snippet of the compile log:
> 
> /home/jenkins-slave/workspace/ci-repository/openbmc/smbios-mdr/src/cpuinfo_main.cpp:34:10: fatal error: peci.h: No such file or directory
>     34 | #include <peci.h>
>        |          ^~~~~~~~
> compilation terminated.
> 
> 
> This one might be a missing dependency?  Where is 'peci.h' from?  Is 
> it from a kernel header for the ioctls or some other repository?  Do 
> you need to stub this out when building on x86?
peci.h comes from libpeci which needs to be pulled in as an ExternalProject in CMake when not building with Yocto.

Here is an example of how I got libpeci working for the host-error-monitor to pass CI: 
https://gerrit.openbmc-project.xyz/c/openbmc/host-error-monitor/+/32545/1/CMakeLists.txt.

> 
> 
> make[2]: *** [CMakeFiles/cpuinfoapp.dir/build.make:63: 
> CMakeFiles/cpuinfoapp.dir/src/cpuinfo_main.cpp.o] Error 1
> make[1]: *** [CMakeFiles/Makefile2:78: CMakeFiles/cpuinfoapp.dir/all] 
> Error 2
> make[1]: *** Waiting for unfinished jobs....
> In file included from /home/jenkins-slave/workspace/ci-repository/openbmc/smbios-mdr/src/cpu.cpp:17:
> /home/jenkins-slave/workspace/ci-repository/openbmc/smbios-mdr/include/cpu.hpp:113:17: error: âstd::string phosphor::smbios::Cpu::processorSocket(std::string)â marked âoverrideâ, but does not override
>    113 |     std::string processorSocket(std::string value) override;
> 
> This appears to be a case where the current phosphor-dbus-interfaces 
> doesn't match whatever your commit is trying to do.  You've got 
> additional methods for handling dbus properties, but those properties 
> do not exist in phosphor-dbus-interface's Cpu interface.
> 
> I suspect you're trying to implement
> xyz/openbmc_project/Inventory/Item/Cpu, which has a 'Socket' property 
> but not a 'ProcessorSocket'.  If I recall, this happened in the code 
> review where the "Processor" part was requested to be removed since it 
> was redundant.
> 
> There are a number of other properties in your compile fail that need 
> similar updating.
> 

RE: Need update CI build config for new repo smbios-mdr.

[Wang, Kuiying]

Thanks a lot.
It's done https://gerrit.openbmc-project.xyz/#/c/openbmc/smbios-mdr/+/36177/


Thanks,
Kwin.

-----Original Message-----
From: Patrick Williams <patrick@stwcx.xyz> 
Sent: Wednesday, September 2, 2020 11:50 PM
To: Wang, Kuiying <kuiying.wang@intel.com>
Cc: openbmc@lists.ozlabs.org; Brad Bishop <bradleyb@fuzziesquirrel.com>
Subject: Re: Need update CI build config for new repo smbios-mdr.

On Wed, Sep 02, 2020 at 02:02:00AM +0000, Wang, Kuiying wrote:
> Hi Williams,
> The key thing is sdbusplus interface is not match.
> You could config CI based on this patch 
> https://gerrit.openbmc-project.xyz/#/c/openbmc/smbios-mdr/+/36011/
> That's ok, if it can pass the build.
> 
> Thanks,
> Kwin.
> 

Here is a snippet of the compile log:

/home/jenkins-slave/workspace/ci-repository/openbmc/smbios-mdr/src/cpuinfo_main.cpp:34:10: fatal error: peci.h: No such file or directory
   34 | #include <peci.h>
      |          ^~~~~~~~
compilation terminated.


This one might be a missing dependency?  Where is 'peci.h' from?  Is it from a kernel header for the ioctls or some other repository?  Do you need to stub this out when building on x86?


make[2]: *** [CMakeFiles/cpuinfoapp.dir/build.make:63: CMakeFiles/cpuinfoapp.dir/src/cpuinfo_main.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:78: CMakeFiles/cpuinfoapp.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
In file included from /home/jenkins-slave/workspace/ci-repository/openbmc/smbios-mdr/src/cpu.cpp:17:
/home/jenkins-slave/workspace/ci-repository/openbmc/smbios-mdr/include/cpu.hpp:113:17: error: âstd::string phosphor::smbios::Cpu::processorSocket(std::string)â marked âoverrideâ, but does not override
  113 |     std::string processorSocket(std::string value) override;

This appears to be a case where the current phosphor-dbus-interfaces doesn't match whatever your commit is trying to do.  You've got additional methods for handling dbus properties, but those properties do not exist in phosphor-dbus-interface's Cpu interface.

I suspect you're trying to implement
xyz/openbmc_project/Inventory/Item/Cpu, which has a 'Socket' property but not a 'ProcessorSocket'.  If I recall, this happened in the code review where the "Processor" part was requested to be removed since it was redundant.

There are a number of other properties in your compile fail that need similar updating.

--
Patrick Williams