From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Dongchun Zhu <dongchun.zhu@mediatek.com>
Cc: mark.rutland@arm.com, drinkcat@chromium.org,
andriy.shevchenko@linux.intel.com, louis.kuo@mediatek.com,
srv_heupstream@mediatek.com, devicetree@vger.kernel.org,
linus.walleij@linaro.org, shengnan.wang@mediatek.com,
tfiga@chromium.org, bgolaszewski@baylibre.com,
sj.huang@mediatek.com, robh+dt@kernel.org,
linux-mediatek@lists.infradead.org, sakari.ailus@linux.intel.com,
matthias.bgg@gmail.com, bingbu.cao@intel.com, mchehab@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH V10 2/2] media: i2c: dw9768: Add DW9768 VCM driver
Date: Wed, 2 Sep 2020 14:35:35 +0900 [thread overview]
Message-ID: <20200902053535.GC2264887@google.com> (raw)
In-Reply-To: <20200703080404.29770-3-dongchun.zhu@mediatek.com>
On (20/07/03 16:04), Dongchun Zhu wrote:
[..]
> +static int dw9768_probe(struct i2c_client *client)
> +{
> + struct device *dev = &client->dev;
> + struct dw9768 *dw9768;
> + unsigned int i;
> + int ret;
> +
> + dw9768 = devm_kzalloc(dev, sizeof(*dw9768), GFP_KERNEL);
> + if (!dw9768)
> + return -ENOMEM;
> +
> + /* Initialize subdev */
> + v4l2_i2c_subdev_init(&dw9768->sd, client, &dw9768_ops);
> +
[..]
> + dw9768->sd.entity.function = MEDIA_ENT_F_LENS;
> +
> + pm_runtime_enable(dev);
> + if (!pm_runtime_enabled(dev)) {
> + ret = dw9768_runtime_resume(dev);
> + if (ret < 0) {
> + dev_err(dev, "failed to power on: %d\n", ret);
> + goto err_clean_entity;
> + }
> + }
> +
> + ret = v4l2_async_register_subdev(&dw9768->sd);
> + if (ret < 0) {
> + dev_err(dev, "failed to register V4L2 subdev: %d", ret);
> + goto err_power_off;
> + }
I would expect to see a slightly different order here: first set
everything up, then expose the device to PM subsystem.
[..]
> +static int dw9768_remove(struct i2c_client *client)
> +{
> + struct v4l2_subdev *sd = i2c_get_clientdata(client);
> + struct dw9768 *dw9768 = sd_to_dw9768(sd);
> +
> + v4l2_async_unregister_subdev(&dw9768->sd);
> + v4l2_ctrl_handler_free(&dw9768->ctrls);
> + media_entity_cleanup(&dw9768->sd.entity);
> + pm_runtime_disable(&client->dev);
> + if (!pm_runtime_status_suspended(&client->dev))
> + dw9768_runtime_suspend(&client->dev);
> + pm_runtime_set_suspended(&client->dev);
Ditto. Shall we first disable PM (so that we won't get any unexpected
PM callbacks) and then destroy the device?
-ss
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Dongchun Zhu <dongchun.zhu@mediatek.com>
Cc: mark.rutland@arm.com, drinkcat@chromium.org,
andriy.shevchenko@linux.intel.com, louis.kuo@mediatek.com,
srv_heupstream@mediatek.com, devicetree@vger.kernel.org,
linus.walleij@linaro.org, shengnan.wang@mediatek.com,
tfiga@chromium.org, bgolaszewski@baylibre.com,
sj.huang@mediatek.com, robh+dt@kernel.org,
linux-mediatek@lists.infradead.org, sakari.ailus@linux.intel.com,
matthias.bgg@gmail.com, bingbu.cao@intel.com, mchehab@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH V10 2/2] media: i2c: dw9768: Add DW9768 VCM driver
Date: Wed, 2 Sep 2020 14:35:35 +0900 [thread overview]
Message-ID: <20200902053535.GC2264887@google.com> (raw)
In-Reply-To: <20200703080404.29770-3-dongchun.zhu@mediatek.com>
On (20/07/03 16:04), Dongchun Zhu wrote:
[..]
> +static int dw9768_probe(struct i2c_client *client)
> +{
> + struct device *dev = &client->dev;
> + struct dw9768 *dw9768;
> + unsigned int i;
> + int ret;
> +
> + dw9768 = devm_kzalloc(dev, sizeof(*dw9768), GFP_KERNEL);
> + if (!dw9768)
> + return -ENOMEM;
> +
> + /* Initialize subdev */
> + v4l2_i2c_subdev_init(&dw9768->sd, client, &dw9768_ops);
> +
[..]
> + dw9768->sd.entity.function = MEDIA_ENT_F_LENS;
> +
> + pm_runtime_enable(dev);
> + if (!pm_runtime_enabled(dev)) {
> + ret = dw9768_runtime_resume(dev);
> + if (ret < 0) {
> + dev_err(dev, "failed to power on: %d\n", ret);
> + goto err_clean_entity;
> + }
> + }
> +
> + ret = v4l2_async_register_subdev(&dw9768->sd);
> + if (ret < 0) {
> + dev_err(dev, "failed to register V4L2 subdev: %d", ret);
> + goto err_power_off;
> + }
I would expect to see a slightly different order here: first set
everything up, then expose the device to PM subsystem.
[..]
> +static int dw9768_remove(struct i2c_client *client)
> +{
> + struct v4l2_subdev *sd = i2c_get_clientdata(client);
> + struct dw9768 *dw9768 = sd_to_dw9768(sd);
> +
> + v4l2_async_unregister_subdev(&dw9768->sd);
> + v4l2_ctrl_handler_free(&dw9768->ctrls);
> + media_entity_cleanup(&dw9768->sd.entity);
> + pm_runtime_disable(&client->dev);
> + if (!pm_runtime_status_suspended(&client->dev))
> + dw9768_runtime_suspend(&client->dev);
> + pm_runtime_set_suspended(&client->dev);
Ditto. Shall we first disable PM (so that we won't get any unexpected
PM callbacks) and then destroy the device?
-ss
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Dongchun Zhu <dongchun.zhu@mediatek.com>
Cc: linus.walleij@linaro.org, bgolaszewski@baylibre.com,
mchehab@kernel.org, andriy.shevchenko@linux.intel.com,
robh+dt@kernel.org, mark.rutland@arm.com,
sakari.ailus@linux.intel.com, drinkcat@chromium.org,
tfiga@chromium.org, matthias.bgg@gmail.com, bingbu.cao@intel.com,
srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, sj.huang@mediatek.com,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
louis.kuo@mediatek.com, shengnan.wang@mediatek.com
Subject: Re: [PATCH V10 2/2] media: i2c: dw9768: Add DW9768 VCM driver
Date: Wed, 2 Sep 2020 14:35:35 +0900 [thread overview]
Message-ID: <20200902053535.GC2264887@google.com> (raw)
In-Reply-To: <20200703080404.29770-3-dongchun.zhu@mediatek.com>
On (20/07/03 16:04), Dongchun Zhu wrote:
[..]
> +static int dw9768_probe(struct i2c_client *client)
> +{
> + struct device *dev = &client->dev;
> + struct dw9768 *dw9768;
> + unsigned int i;
> + int ret;
> +
> + dw9768 = devm_kzalloc(dev, sizeof(*dw9768), GFP_KERNEL);
> + if (!dw9768)
> + return -ENOMEM;
> +
> + /* Initialize subdev */
> + v4l2_i2c_subdev_init(&dw9768->sd, client, &dw9768_ops);
> +
[..]
> + dw9768->sd.entity.function = MEDIA_ENT_F_LENS;
> +
> + pm_runtime_enable(dev);
> + if (!pm_runtime_enabled(dev)) {
> + ret = dw9768_runtime_resume(dev);
> + if (ret < 0) {
> + dev_err(dev, "failed to power on: %d\n", ret);
> + goto err_clean_entity;
> + }
> + }
> +
> + ret = v4l2_async_register_subdev(&dw9768->sd);
> + if (ret < 0) {
> + dev_err(dev, "failed to register V4L2 subdev: %d", ret);
> + goto err_power_off;
> + }
I would expect to see a slightly different order here: first set
everything up, then expose the device to PM subsystem.
[..]
> +static int dw9768_remove(struct i2c_client *client)
> +{
> + struct v4l2_subdev *sd = i2c_get_clientdata(client);
> + struct dw9768 *dw9768 = sd_to_dw9768(sd);
> +
> + v4l2_async_unregister_subdev(&dw9768->sd);
> + v4l2_ctrl_handler_free(&dw9768->ctrls);
> + media_entity_cleanup(&dw9768->sd.entity);
> + pm_runtime_disable(&client->dev);
> + if (!pm_runtime_status_suspended(&client->dev))
> + dw9768_runtime_suspend(&client->dev);
> + pm_runtime_set_suspended(&client->dev);
Ditto. Shall we first disable PM (so that we won't get any unexpected
PM callbacks) and then destroy the device?
-ss
next prev parent reply other threads:[~2020-09-02 5:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-03 8:04 [PATCH V10 0/2] media: i2c: Add support for DW9768 VCM Dongchun Zhu
2020-07-03 8:04 ` Dongchun Zhu
2020-07-03 8:04 ` Dongchun Zhu
2020-07-03 8:04 ` [PATCH V10 1/2] media: dt-bindings: media: i2c: Document DW9768 bindings Dongchun Zhu
2020-07-03 8:04 ` Dongchun Zhu
2020-07-03 8:04 ` Dongchun Zhu
2020-07-03 8:04 ` [PATCH V10 2/2] media: i2c: dw9768: Add DW9768 VCM driver Dongchun Zhu
2020-07-03 8:04 ` Dongchun Zhu
2020-07-03 8:04 ` Dongchun Zhu
2020-09-02 5:35 ` Sergey Senozhatsky [this message]
2020-09-02 5:35 ` Sergey Senozhatsky
2020-09-02 5:35 ` Sergey Senozhatsky
2020-09-02 12:38 ` Tomasz Figa
2020-09-02 12:38 ` Tomasz Figa
2020-09-02 12:38 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200902053535.GC2264887@google.com \
--to=sergey.senozhatsky.work@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=bingbu.cao@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dongchun.zhu@mediatek.com \
--cc=drinkcat@chromium.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=louis.kuo@mediatek.com \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=shengnan.wang@mediatek.com \
--cc=sj.huang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.