From: Sudeep Holla <sudeep.holla@arm.com>
To: Ionela Voinescu <ionela.voinescu@arm.com>
Cc: rjw@rjwysocki.net, viresh.kumar@linaro.org,
dietmar.eggemann@arm.com, catalin.marinas@arm.com,
will@kernel.org, valentin.schneider@arm.com,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/5] arch_topology: validate input frequencies to arch_set_freq_scale()
Date: Wed, 2 Sep 2020 14:32:00 +0100 [thread overview]
Message-ID: <20200902133200.GH25462@bogus> (raw)
In-Reply-To: <20200901205549.30096-2-ionela.voinescu@arm.com>
On Tue, Sep 01, 2020 at 09:55:45PM +0100, Ionela Voinescu wrote:
> The current frequency passed to arch_set_freq_scale() could end up
> being 0, signaling an error in setting a new frequency. Also, if the
> maximum frequency in 0, this will result in a division by 0 error.
>
> Therefore, validate these input values before using them for the
> setting of the frequency scale factor.
>
> Signed-off-by: Ionela Voinescu <ionela.voinescu@arm.com>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> Cc: Sudeep Holla <sudeep.holla@arm.com>
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
--
Regards,
Sudeep
WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <sudeep.holla@arm.com>
To: Ionela Voinescu <ionela.voinescu@arm.com>
Cc: linux-pm@vger.kernel.org, viresh.kumar@linaro.org,
rjw@rjwysocki.net, linux-kernel@vger.kernel.org,
dietmar.eggemann@arm.com, catalin.marinas@arm.com,
will@kernel.org, valentin.schneider@arm.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 1/5] arch_topology: validate input frequencies to arch_set_freq_scale()
Date: Wed, 2 Sep 2020 14:32:00 +0100 [thread overview]
Message-ID: <20200902133200.GH25462@bogus> (raw)
In-Reply-To: <20200901205549.30096-2-ionela.voinescu@arm.com>
On Tue, Sep 01, 2020 at 09:55:45PM +0100, Ionela Voinescu wrote:
> The current frequency passed to arch_set_freq_scale() could end up
> being 0, signaling an error in setting a new frequency. Also, if the
> maximum frequency in 0, this will result in a division by 0 error.
>
> Therefore, validate these input values before using them for the
> setting of the frequency scale factor.
>
> Signed-off-by: Ionela Voinescu <ionela.voinescu@arm.com>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> Cc: Sudeep Holla <sudeep.holla@arm.com>
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-02 15:46 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 20:55 [PATCH v5 0/5] cpufreq: improve frequency invariance support Ionela Voinescu
2020-09-01 20:55 ` Ionela Voinescu
2020-09-01 20:55 ` [PATCH v5 1/5] arch_topology: validate input frequencies to arch_set_freq_scale() Ionela Voinescu
2020-09-01 20:55 ` Ionela Voinescu
2020-09-02 13:32 ` Sudeep Holla [this message]
2020-09-02 13:32 ` Sudeep Holla
2020-09-01 20:55 ` [PATCH v5 2/5] cpufreq: move invariance setter calls in cpufreq core Ionela Voinescu
2020-09-01 20:55 ` Ionela Voinescu
2020-09-02 13:30 ` Sudeep Holla
2020-09-02 13:30 ` Sudeep Holla
2020-09-01 20:55 ` [PATCH v5 3/5] cpufreq: report whether cpufreq supports Frequency Invariance (FI) Ionela Voinescu
2020-09-01 20:55 ` Ionela Voinescu
2020-09-02 13:28 ` Sudeep Holla
2020-09-02 13:28 ` Sudeep Holla
2020-09-03 13:45 ` Ionela Voinescu
2020-09-03 13:45 ` Ionela Voinescu
2020-09-03 14:19 ` Sudeep Holla
2020-09-03 14:19 ` Sudeep Holla
2020-09-01 20:55 ` [PATCH v5 4/5] arch_topology, cpufreq: constify arch_* cpumasks Ionela Voinescu
2020-09-01 20:55 ` Ionela Voinescu
2020-09-02 13:25 ` Sudeep Holla
2020-09-02 13:25 ` Sudeep Holla
2020-09-01 20:55 ` [PATCH v5 5/5] arch_topology, arm, arm64: define arch_scale_freq_invariant() Ionela Voinescu
2020-09-01 20:55 ` Ionela Voinescu
2020-09-02 13:24 ` Sudeep Holla
2020-09-02 13:24 ` Sudeep Holla
2020-09-03 13:32 ` [PATCH v5 0/5] cpufreq: improve frequency invariance support Ionela Voinescu
2020-09-03 13:32 ` Ionela Voinescu
2020-09-04 4:38 ` Viresh Kumar
2020-09-04 4:38 ` Viresh Kumar
2020-09-18 17:12 ` Rafael J. Wysocki
2020-09-18 17:12 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200902133200.GH25462@bogus \
--to=sudeep.holla@arm.com \
--cc=catalin.marinas@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=ionela.voinescu@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=valentin.schneider@arm.com \
--cc=viresh.kumar@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.