From: Al Viro <viro@zeniv.linux.org.uk>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, maz@kernel.org, tiwai@suse.com,
syzkaller-bugs@googlegroups.com, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, dan.carpenter@oracle.com
Subject: Re: general protection fault in snd_ctl_release
Date: Wed, 2 Sep 2020 16:35:30 +0100 [thread overview]
Message-ID: <20200902153530.GK1236603@ZenIV.linux.org.uk> (raw)
In-Reply-To: <s5h36409pbb.wl-tiwai@suse.de>
On Wed, Sep 02, 2020 at 05:22:00PM +0200, Takashi Iwai wrote:
> Marc, Al, could you guys check this bug?
That's racy; the first one should be get_file_rcu() instead of
file_count()+get_file(), the second is not needed at all (we
have the file pinned down by the caller). See vfs.git#work.epoll
for fix
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@zeniv.linux.org.uk>
To: Takashi Iwai <tiwai@suse.de>
Cc: maz@kernel.org, alsa-devel@alsa-project.org,
dan.carpenter@oracle.com, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, o-takashi@sakamocchi.jp,
perex@perex.cz, syzkaller-bugs@googlegroups.com, tiwai@suse.com
Subject: Re: general protection fault in snd_ctl_release
Date: Wed, 2 Sep 2020 16:35:30 +0100 [thread overview]
Message-ID: <20200902153530.GK1236603@ZenIV.linux.org.uk> (raw)
In-Reply-To: <s5h36409pbb.wl-tiwai@suse.de>
On Wed, Sep 02, 2020 at 05:22:00PM +0200, Takashi Iwai wrote:
> Marc, Al, could you guys check this bug?
That's racy; the first one should be get_file_rcu() instead of
file_count()+get_file(), the second is not needed at all (we
have the file pinned down by the caller). See vfs.git#work.epoll
for fix
next prev parent reply other threads:[~2020-09-02 15:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 6:57 general protection fault in snd_ctl_release syzbot
2020-09-02 15:22 ` Takashi Iwai
2020-09-02 15:22 ` Takashi Iwai
2020-09-02 15:35 ` Al Viro [this message]
2020-09-02 15:35 ` Al Viro
2020-09-02 15:46 ` Takashi Iwai
2020-09-02 15:46 ` Takashi Iwai
2020-09-02 17:23 ` Takashi Iwai
2020-09-02 17:23 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200902153530.GK1236603@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=alsa-devel@alsa-project.org \
--cc=dan.carpenter@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.